silverwind 
							
						 
					 
					
						
						
							
						
						68ec9b4859 
					 
					
						
						
							
							Migrate margin and padding helpers to tailwind ( #30043 )  
						
						... 
						
						
						
						This will conclude the refactor of 1:1 class replacements to tailwind,
except `gt-hidden`. Commands ran:
```bash
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-0#tw-$1$2-0#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-1#tw-$1$2-0.5#g' {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-2#tw-$1$2-1#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-3#tw-$1$2-2#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-4#tw-$1$2-4#g'   {web_src/js,templates,routers,services}/**/*
perl -p -i -e 's#gt-(p|m)([lrtbxy])?-5#tw-$1$2-8#g'   {web_src/js,templates,routers,services}/**/*
``` 
						
						
					 
					
						2024-03-24 17:42:49 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						90a4f9a49e 
					 
					
						
						
							
							Migrate gap helpers to tailwind ( #30034 )  
						
						... 
						
						
						
						Commands ran:
```sh
perl -p -i -e 's#gt-gap-0#tw-gap-0#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-1#tw-gap-0.5#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-2#tw-gap-1#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-3#tw-gap-2#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-4#tw-gap-4#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-5#tw-gap-8#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-0#tw-gap-x-0#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-1#tw-gap-x-0.5#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-2#tw-gap-x-1#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-3#tw-gap-x-2#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-4#tw-gap-x-4#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-x-5#tw-gap-x-8#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-0#tw-gap-y-0#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-1#tw-gap-y-0.5#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-2#tw-gap-y-1#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-3#tw-gap-y-2#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-4#tw-gap-y-4#g'   web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-gap-y-5#tw-gap-y-8#g'   web_src/js/**/* templates/**/* 
						
						
					 
					
						2024-03-24 14:31:35 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						5bd0773741 
					 
					
						
						
							
							Dont show expansion for empty actions steps ( #29977 )  
						
						... 
						
						
						
						This hides the chevron icon and makes the step header unclickable for
skipped steps because there is no content to expand on those.
Before:
<img width="272" alt="Screenshot 2024-03-21 at 20 06 47"
src="https://github.com/go-gitea/gitea/assets/115237/9bb328d1-6f74-48a9-af19-de9b351e3707 ">
After:
<img width="295" alt="Screenshot 2024-03-21 at 20 03 07"
src="https://github.com/go-gitea/gitea/assets/115237/72a26e14-5a28-4606-8c3c-184b405872c8 ">
---------
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-24 13:38:10 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						db01bf6cc8 
					 
					
						
						
							
							Various code view improvements ( #30014 )  
						
						... 
						
						
						
						1. Restore missing styles for message close icon
2. Move `code-line-button` so that it does not go off-screen on small
viewports
3. Make `code-line-button` look and behave like other buttons
4. Make `code-line-button` work in blame
5. Make the active selection span the whole line, not just the code part
6. Tweak colors, make dark theme code bg darker, make line numbers same
color in diff and file view.
7. Move code background to parent, fixing border radius and other
problems
8. Enable code wrap in blame
9. Improve blame responsiveness
10. Remove `--color-code-sidebar-bg` in blame, now it uses same
background as code
11. Rename `--color-active-line` to `--color-highlight-bg`
12. Add `--color-highlight-bg`
13. Fix button group borders on hover and border-right on last button.
<img width="1343" alt="Screenshot 2024-03-23 at 22 34 13"
src="https://github.com/go-gitea/gitea/assets/115237/fcbb919f-5dc3-43f0-97f6-870d6f412554 ">
<img width="1334" alt="Screenshot 2024-03-23 at 22 34 26"
src="https://github.com/go-gitea/gitea/assets/115237/ca44c3b7-4328-4645-ba49-b0dc6a5ac06d ">
<img width="1338" alt="Screenshot 2024-03-23 at 22 34 57"
src="https://github.com/go-gitea/gitea/assets/115237/00eb0b5a-1ec7-4669-a94a-4602b9d1c1ac ">
<img width="1337" alt="Screenshot 2024-03-23 at 22 34 42"
src="https://github.com/go-gitea/gitea/assets/115237/752edc4a-064f-413c-9dff-c086187fcd85 ">
Fixes: https://github.com/go-gitea/gitea/issues/18074  
						
						
					 
					
						2024-03-24 12:14:03 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						e4a481e0ca 
					 
					
						
						
							
							Remove remaining jQuery .css code ( #30015 )  
						
						... 
						
						
						
						The linter missed these because they were set on a object. Tested and I
also renamed those properties to add `$` indicating a jQuery selection.
---------
Co-authored-by: delvh <dev.lh@web.de >
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-24 03:01:57 +01:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						900dd79d8a 
					 
					
						
						
							
							Remove jQuery .attr from the common global functions ( #30023 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `getAttribute`
- Tested the show/hide modal buttons, they work as before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-23 21:31:19 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						75e2e5c736 
					 
					
						
						
							
							Migrate font-size helpers to tailwind ( #30029 )  
						
						... 
						
						
						
						Migrate `gt-font-*` to `tw-text-*` All tailwind-original class names are
also available and render like they would with 16px root font size.
We currently have root font size at 14px, but I would like to eventually
migrate us to 16px so that the tailwind docs apply to us unchangend and
because 16px is the recommended root font size for web pages in general.
Also the number 16 is much better dividable than 14 so will result in
more integers. 
						
						
					 
					
						2024-03-23 21:22:15 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						fabe01478a 
					 
					
						
						
							
							Migrate font-weight helpers to tailwind ( #30027 )  
						
						... 
						
						
						
						Commands ran:
```sh
perl -p -i -e 's#gt-font-light#tw-font-light#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-normal#tw-font-normal#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-medium#tw-font-medium#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-semibold#tw-font-semibold#g' web_src/js/**/* templates/**/*
perl -p -i -e 's#gt-font-bold#tw-font-bold#g' web_src/js/**/* templates/**/*
``` 
						
						
					 
					
						2024-03-23 18:45:11 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						d9e33959b3 
					 
					
						
						
							
							Remove jQuery from the issue "go to" button ( #30028 )  
						
						... 
						
						
						
						- Switched to plain JavaScript
- Tested the "go to" button functionality and it works as before
# Demo using JavaScript without jQuery

Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-23 18:18:45 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						74c1378dfb 
					 
					
						
						
							
							Remove jQuery .attr from the diff page ( #30021 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `getAttribute` and
`setAttribute`
- Tested the review box counter and Previous/Next code review
conversation buttons. They work as before
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2024-03-23 13:37:18 +01:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						26dbca7411 
					 
					
						
						
							
							Remove jQuery .attr from the repository settings ( #30018 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `getAttribute` and
`setAttribute`
- Tested the collaborator access mode change, team search box, and
branch protection form. They all work as before
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-23 12:28:53 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						d0d7b4b6d1 
					 
					
						
						
							
							Remove jQuery .attr from the image diff again ( #30022 )  
						
						... 
						
						
						
						- Follows https://github.com/go-gitea/gitea/pull/29917 
Missed these
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-23 12:51:34 +01:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						bc92478575 
					 
					
						
						
							
							Remove jQuery .attr from the branch/tag selector ( #30010 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.setAttribute`
- Tested the cherry-pick from the branch/tag selector and it works as
before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-22 23:26:56 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						d4ac1bd26e 
					 
					
						
						
							
							Remove jQuery .attr from the commit graph ( #30006 )  
						
						... 
						
						
						
						Switched from jQuery `.attr` to plain javascript `.getAttribute` and
`.setAttribute`
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-22 23:22:01 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						dade40407e 
					 
					
						
						
							
							Remove jQuery from the citation modal (except fomantic) ( #30008 )  
						
						... 
						
						
						
						- Switched to plain JavaScript
- Tested the citation modal functionality and it works as before
# Demo using JavaScript without jQuery

---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2024-03-23 00:17:28 +01:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						5c91d7920f 
					 
					
						
						
							
							Remove jQuery .attr from the project page ( #30004 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the issue movement between columns, column background color
setting, and column deletion. It all works as before
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-22 20:56:38 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						04f9ad0568 
					 
					
						
						
							
							Fix incorrect tailwind migration ( #30007 )  
						
						... 
						
						
						
						Fixes https://github.com/go-gitea/gitea/issues/30005 . Regression from
https://github.com/go-gitea/gitea/pull/29945 .
There was only once instance of `tw-content-center` before that PR, so I
just ran below command and reverted that one instance.
```sh
perl -p -i -e 's#tw-content-center#tw-items-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
``` 
						
						
					 
					
						2024-03-22 20:51:29 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						3d751b6ec1 
					 
					
						
						
							
							Enforce trailing comma in JS on multiline ( #30002 )  
						
						... 
						
						
						
						To keep blame info accurate and to avoid [changes like
this](https://github.com/go-gitea/gitea/pull/29977/files#diff-c3422631a14edbe1e508c4b22f0c718db318be08a6e889427802f9b6165d88d6R359 ),
it's good to always have a trailing comma, so let's enforce it in JS.
This rule is completely automatically fixable with `make lint-js-fix`
and that's what I did here. 
						
						
					 
					
						2024-03-22 14:06:53 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						f88ad5424f 
					 
					
						
						
							
							Replace 10 more gt- classes with tw- ( #29945 )  
						
						... 
						
						
						
						Likely the biggest change of the tailwind refactors. Only thing of note
is that `tw-flex-1` resolves to `flex: 1 1 0%` while our `gt-f1` was
`flex: 1 1 0`, I don't think it will make any difference. Commands I've
ran:
```sh
perl -p -i -e 's#gt-vm#tw-align-middle#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-fw#tw-flex-wrap#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-f1#tw-flex-1#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-fc#tw-flex-col#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-sb#tw-justify-between#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-je#tw-justify-end#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-jc#tw-justify-center#g' web_src/js/**/* templates/**/* models/**/*
perl -p -i -e 's#gt-ac#tw-content-center#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
perl -p -i -e 's#gt-df#tw-flex#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
perl -p -i -e 's#gt-dib#tw-inline-block#g' web_src/js/**/* templates/**/* models/**/* tests/**/*
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com > 
						
						
					 
					
						2024-03-22 13:45:10 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						29118743a5 
					 
					
						
						
							
							Small refactors in anchors.js ( #29947 )  
						
						... 
						
						
						
						Some minor refactors, remove unnecessary `:is` selector and move the
`:target` check out of the function. Might as well backport for the rare
browser that does not support `:is`. 
						
						
					 
					
						2024-03-22 12:28:38 +00:00 
						 
				 
			
				
					
						
							
							
								HEREYUA 
							
						 
					 
					
						
						
							
						
						bf34723491 
					 
					
						
						
							
							Fix: Abnormal strings appear when comments are saved after editing ( #29991 )  
						
						... 
						
						
						
						Partially resolved(The second problem):
[#29986 ](https://github.com/go-gitea/gitea/issues/29986 )
**Before**
HTML strings appear when comments are saved after editing

**After**
https://github.com/go-gitea/gitea/assets/37935145/525601f9-3ee1-4266-9105-36d82b91b1c8  
						
						
					 
					
						2024-03-22 11:22:36 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						226231ea27 
					 
					
						
						
							
							Fix some pending problems ( #29985 )  
						
						... 
						
						
						
						These changes are quite independent and trivial, so I don't want to open
too many PRs.
* https://github.com/go-gitea/gitea/pull/29882#discussion_r1529607091 
    * the `f.Close` should be called properly
* the error message could be more meaningful
(https://github.com/go-gitea/gitea/pull/29882#pullrequestreview-1942557935 )
*
https://github.com/go-gitea/gitea/pull/29859#pullrequestreview-1942324716 
    * the new translation strings don't take arguments
* https://github.com/go-gitea/gitea/pull/28710#discussion_r1443778807 
    * stale for long time
*  #28140  
    * a form was forgotten to be changed to work with backend code 
						
						
					 
					
						2024-03-22 19:17:30 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						d6fed9ab88 
					 
					
						
						
							
							Fix various loading states, remove .loading class ( #29920 )  
						
						... 
						
						
						
						Various code was using fomantic `loading` class which I think got broken
a while ago and rendered only a full circle. Fix those to use
`is-loading`.
Before:
<img width="295" alt="Screenshot 2024-03-19 at 22 56 26"
src="https://github.com/go-gitea/gitea/assets/115237/dbe83395-5db4-4868-90bc-3613866a35f0 ">
After:
<img width="60" alt="Screenshot 2024-03-19 at 22 54 35"
src="https://github.com/go-gitea/gitea/assets/115237/8ac19b7e-035a-4c6d-850b-53a234ef69c2 ">
<img width="294" alt="Screenshot 2024-03-19 at 22 54 56"
src="https://github.com/go-gitea/gitea/assets/115237/34e819d7-25f7-43a1-9d48-4a68dcd2b6ad ">
<img width="320" alt="Screenshot 2024-03-19 at 22 55 16"
src="https://github.com/go-gitea/gitea/assets/115237/05127544-47ff-4e18-9fd8-c84e44c374f8 ">
<img width="153" alt="Screenshot 2024-03-19 at 23 01 43"
src="https://github.com/go-gitea/gitea/assets/115237/a33248c6-b11d-40ff-82d8-f5a3d85b55aa ">
<img width="1300" alt="Screenshot 2024-03-19 at 23 56 25"
src="https://github.com/go-gitea/gitea/assets/115237/562ca876-b5d5-4295-961e-9d2cdab31ab0 ">
<img width="136" alt="Screenshot 2024-03-20 at 00 00 38"
src="https://github.com/go-gitea/gitea/assets/115237/44838ac4-67f3-4fec-a8e3-978cc5dbdb72 "> 
						
						
					 
					
						2024-03-21 16:31:15 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						82979588f4 
					 
					
						
						
							
							Switch to happy-dom for testing ( #29948 )  
						
						... 
						
						
						
						Use `happy-dom` again in vitest as it has caught up recently to `jsdom`
in terms of features and it is a much more lightweight solution.
I encountered [one
bug](https://github.com/capricorn86/happy-dom/issues/1342 ), but it's an
easy workaround until fixed.
I regenerated the lockfile to get rid of the transitive dependencies so
that's why the diff also has some upgrades in it.
In total, this change removes 39 npm dependencies. 
						
						
					 
					
						2024-03-21 14:05:24 +00:00 
						 
				 
			
				
					
						
							
							
								HEREYUA 
							
						 
					 
					
						
						
							
						
						0b4ff15356 
					 
					
						
						
							
							Solving the issue of UI disruption when the review is deleted without refreshing ( #29951 )  
						
						... 
						
						
						
						**After deleting the review and refreshing, the display is normal.
However, Without refreshing, the interface will be broken**
https://github.com/go-gitea/gitea/assets/37935145/f5cb19a6-eb26-47b0-b8ee-15b575bbe1ac 
**after**
https://github.com/go-gitea/gitea/assets/37935145/aa65922c-2ebf-4fce-ad91-35661f70329a  
						
						
					 
					
						2024-03-21 18:38:27 +08:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						1a4f693f9f 
					 
					
						
						
							
							Fix JS error and improve error message styles ( #29963 )  
						
						... 
						
						
						
						Fixes: https://github.com/go-gitea/gitea/issues/29956 . This error
exposed a existing bug in the code, it was just never noticed because
the jQuery expression evaluated without error before while the new one
doesn't.
Also improves error message styles:
Before:
<img width="1338" alt="Screenshot 2024-03-21 at 09 16 07"
src="https://github.com/go-gitea/gitea/assets/115237/1cc1ef89-ad94-491e-bbca-75387f7547a0 ">
After:
<img width="1335" alt="Screenshot 2024-03-21 at 09 15 44"
src="https://github.com/go-gitea/gitea/assets/115237/312efc79-5353-4e2a-a703-1bccd3c01736 "> 
						
						
					 
					
						2024-03-21 10:16:11 +00:00 
						 
				 
			
				
					
						
							
							
								Lunny Xiao 
							
						 
					 
					
						
						
							
						
						76ec541051 
					 
					
						
						
							
							Fix and rewrite markup anchor processing ( #29931 )  
						
						... 
						
						
						
						Fix  #29877 
---------
Co-authored-by: silverwind <me@silverwind.io > 
					
						2024-03-21 01:02:53 +02:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						99d7ef5091 
					 
					
						
						
							
							Prevent layout shift in <overflow-menu> items ( #29831 )  
						
						... 
						
						
						
						There is a small layout shift in when active tab changes. Notice how the
actions SVG is unstable:

This is because the active item with bold text is wider then the
inactive one. I have applied [this
trick](https://stackoverflow.com/a/32570813/808699 ) to prevent this
layout shift. It's only active inside `<overflow-menu>` because I wanted
to avoid changing HTML and doing it in regular JS would cause a flicker.
I don't expect us to introduce other similar menus without
`<overflow-menu>`, so that place is likely fine.

I also changed the weight from 500 to 600, slightly reduced horizontal
padding, merged some tab-bar related CSS rules and a added a small
margin below repo-header so it does not look so crammed against the
buttons on top.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com > 
						
						
					 
					
						2024-03-20 17:00:35 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						adc61c5d71 
					 
					
						
						
							
							Remove jQuery .attr from the user search box ( #29919 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the user search box and it works as before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-20 00:09:52 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						dd043854ee 
					 
					
						
						
							
							Remove jQuery .attr from the archive download and compare page branch selector ( #29918 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the archive download and compare page branch selector
functionality and it works as before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-20 00:04:24 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						cb98e27992 
					 
					
						
						
							
							Remove jQuery .attr from the image diff ( #29917 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.setAttribute`
- Tested the image diff functionality and it works as before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-19 23:49:15 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						4cfda02419 
					 
					
						
						
							
							Remove jQuery .attr from the quick pull request button text ( #29916 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the quick pull request button text change functionality and it
works as before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-19 23:44:21 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						55a8f4510a 
					 
					
						
						
							
							Remove jQuery .attr from the issue author dropdown ( #29915 )  
						
						... 
						
						
						
						- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the issue author dropdown functionality and it works as before
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-19 23:39:36 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						fa100618c4 
					 
					
						
						
							
							Forbid jQuery .css and refactor all usage ( #29852 )  
						
						... 
						
						
						
						Tested all functionality. There is a [pre-existing
bug](https://github.com/go-gitea/gitea/issues/29853 ) when moving a
project panels which is not caused by this refactoring.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com > 
						
						
					 
					
						2024-03-19 16:28:46 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						34290a00c4 
					 
					
						
						
							
							Migrate border and margin classes to Tailwind ( #29828 )  
						
						... 
						
						
						
						Used all existing css vars, other migrations are 1:1.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com > 
						
						
					 
					
						2024-03-18 14:47:05 +00:00 
						 
				 
			
				
					
						
							
							
								wxiaoguang 
							
						 
					 
					
						
						
							
						
						b251e608c0 
					 
					
						
						
							
							Only do counting when count_only=true for repo dashboard ( #29884 )  
						
						... 
						
						
						
						Ref: #29878  
						
						
					 
					
						2024-03-18 11:05:17 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						33973ac567 
					 
					
						
						
							
							Avoid JS error on issue/pr list when logged out ( #29854 )  
						
						... 
						
						
						
						When logged out, the checkboxes are not there on the issue/pr lists,
which would cause an error here.
Fixes: https://github.com/go-gitea/gitea/issues/29862 
---------
Co-authored-by: delvh <dev.lh@web.de > 
						
						
					 
					
						2024-03-17 12:50:32 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						4b1c88628a 
					 
					
						
						
							
							Load citation JS only when needed ( #29855 )  
						
						... 
						
						
						
						Previously, the citation js would load every time when opening a citable
repo. Now it only loads when the user clicks the button for it. The
loading state is representend with a spinner on the button:
<img width="83" alt="Screenshot 2024-03-17 at 00 25 13"
src="https://github.com/go-gitea/gitea/assets/115237/29649089-13f3-4974-ab81-e12c0f8e651f ">
Diff ist best viewed with whitespace hidden.
---------
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-17 11:04:59 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						43aa914b17 
					 
					
						
						
							
							fix double border and border-radius on empty action steps ( #29845 )  
						
						... 
						
						
						
						Before, double border-bottom and incorrect border-radius:
<img width="914" alt="Screenshot 2024-03-16 at 14 46 31"
src="https://github.com/go-gitea/gitea/assets/115237/6ea63c42-754c-420c-a0f5-c889a8507d9f ">
After, both fixed:
<img width="917" alt="Screenshot 2024-03-16 at 14 45 59"
src="https://github.com/go-gitea/gitea/assets/115237/9d3f2dba-6b22-441d-8e99-5809d5f1f1c0 "> 
						
						
					 
					
						2024-03-16 17:03:56 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						21fe512aac 
					 
					
						
						
							
							Forbid jQuery .prop and fix related issues ( #29832 )  
						
						... 
						
						
						
						The issue checkbox code received a few more cleanups and I specifically
tested it. The other changes are trivial. Also, I checked the cases for
how many elements match the jQuery selection to determine querySelector
vs. querySelectorAll.
---------
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-16 15:08:10 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						f9b4efd42c 
					 
					
						
						
							
							Forbid HTML injection using jQuery ( #29843 )  
						
						... 
						
						
						
						See
https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/no-append-html.md 
Tested the following components and they work as before:
- notification table
- issue author dropdown
- comment edit box attachments div
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-16 13:25:27 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						3cd64949ae 
					 
					
						
						
							
							Forbid variables containing jQuery collections not having the $ prefix ( #29839 )  
						
						... 
						
						
						
						See
https://github.com/wikimedia/eslint-plugin-no-jquery/blob/master/docs/rules/variable-pattern.md 
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2024-03-16 12:22:16 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						043f55fabf 
					 
					
						
						
							
							Remove jQuery AJAX from the notifications ( #29817 )  
						
						... 
						
						
						
						- Removed 2 jQuery AJAX calls and replaced with our fetch wrapper
- Deleted an AJAX call that wasn't attached to any element since #24989 
- Tested the notification count and notification table functionality and
it works as before
# Demo using `fetch` instead of jQuery AJAX

---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2024-03-16 02:56:17 +01:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						3f1e4896b6 
					 
					
						
						
							
							Remove the time-since class ( #29826 )  
						
						... 
						
						
						
						It serves no purpose.
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-15 21:57:53 +00:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						3979970938 
					 
					
						
						
							
							Remove jQuery AJAX from the project page ( #29814 )  
						
						... 
						
						
						
						Removed all jQuery AJAX calls and replaced with our fetch wrapper.
Tested the following functionalities and they work as before:
- column creation
- column deletion
- issue movement between columns
- column reordering
- column edit
- default column changing
# Demo using `fetch` instead of jQuery AJAX

---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com > 
						
						
					 
					
						2024-03-15 22:23:56 +01:00 
						 
				 
			
				
					
						
							
							
								Yarden Shoham 
							
						 
					 
					
						
						
							
						
						bfb0a5a41e 
					 
					
						
						
							
							Remove jQuery AJAX from the comment edit box ( #29812 )  
						
						... 
						
						
						
						- Removed all jQuery AJAX calls and replaced with our fetch wrapper
- Tested the file addition and removal functionality and it works as
before
# Demo using `fetch` instead of jQuery AJAX

---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com >
Co-authored-by: silverwind <me@silverwind.io > 
						
						
					 
					
						2024-03-15 19:02:43 +01:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						0d3ec8e2ad 
					 
					
						
						
							
							Use Temporal.PlainDate for absolute dates ( #29804 )  
						
						... 
						
						
						
						Use the upcoming
[Temporal.PlainDate](https://tc39.es/proposal-temporal/docs/plaindate.html )
via polyfill. If there is any remaining bugs in `<absolute-date>` this
will iron them out. I opted for the lightweight polyfill because both
seem to achieve our goal of localizeable absolute dates.
- With
[`@js-temporal/polyfill`](https://www.npmjs.com/package/@js-temporal/polyfill )
chunk size goes from 81.4 KiB to 274 KiB
- With
[`temporal-polyfill`](https://www.npmjs.com/package/temporal-polyfill )
chunk size goes from 81.4 KiB to 142 KiB
Also see [this
table](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#comparison-with-js-temporalpolyfill )
for more comparisons of these polyfills. Soon there will be
[treeshakable
API](https://github.com/fullcalendar/temporal-polyfill?tab=readme-ov-file#tree-shakable-api )
as well which will further reduce size. 
						
						
					 
					
						2024-03-15 09:13:01 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						94512ee062 
					 
					
						
						
							
							Fix Citation modal responsiveness and clipboard copy ( #29799 )  
						
						... 
						
						
						
						The modal was broken in two ways:
- On small screens, the input box was partially hanging outside the
modal. Fixed with flexbox and increased modal width.
- The clipboard copy was not working because the modal had both
`data-clipboard-text` and `data-clipboard-target`, while we only support
one of those. Made a small tweak in clipboard as well so that it will
still fall back to target if text is empty. 
						
						
					 
					
						2024-03-15 02:38:13 +00:00 
						 
				 
			
				
					
						
							
							
								silverwind 
							
						 
					 
					
						
						
							
						
						256a1eeb9a 
					 
					
						
						
							
							Add <overflow-menu>, rename webcomponents ( #29400 )  
						
						... 
						
						
						
						1. Add `<overflow-menu>` web component
2. Rename `<gitea-origin-url>` to `<origin-url>` and make filenames
match.
<img width="439" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/2fbe4ca4-110b-4ad2-8e17-c1e116ccbd74 ">
<img width="444" alt="Screenshot 2024-03-02 at 21 36 52"
src="https://github.com/go-gitea/gitea/assets/115237/aa8f786e-dc8c-4030-b12d-7cfb74bdfd6e ">
<img width="537" alt="Screenshot 2024-03-03 at 03 05 06"
src="https://github.com/go-gitea/gitea/assets/115237/fddd50aa-adf1-4b4b-bd7f-caf30c7b2245 ">


TODO:
- [x] Check if removal of `requestAnimationFrame` is possible to avoid
flash of content. Likely needs a `MutationObserver`.
- [x] Hide tippy when button is removed from DOM.
- [x] ~~Implement right-aligned items
(https://github.com/go-gitea/gitea/pull/28976 )~~. Not going to do it.
- [x] Clean up CSS so base element has no background and add background
via tailwind instead.
- [x] Use it for org and user page.
---------
Co-authored-by: Giteabot <teabot@gitea.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com > 
						
						
					 
					
						2024-03-15 02:05:31 +00:00 
						 
				 
			
				
					
						
							
							
								Denys Konovalov 
							
						 
					 
					
						
						
							
						
						e0b002a4a8 
					 
					
						
						
							
							Unify search boxes ( #29530 )  
						
						... 
						
						
						
						Unify all but a few search boxes to use uniform style, uniform
translations and shared templates where possible.
Remove a few duplicated search templates, e. g. code search.
<details><summary>Example after screenshots:</summary>




</details>
Also includes #29700  
Co-authored-by: 6543 <6543@obermui.de >
---------
Co-authored-by: 6543 <m.huber@kithara.com >
Co-authored-by: 6543 <6543@obermui.de >
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Giteabot <teabot@gitea.io > 
						
						
					 
					
						2024-03-14 23:24:59 +00:00