6543 and GitHub
fbe80e6df2
Add proper error message if session provider can not be created ( #35520 )
...
the middleware that creates the session provider just panics if on
creation the config is wrong.
this is not catched and so you just get an cryptic stacktrace with no
point where to look at (as user).
## Before
```
2025/09/16 03:56:37 ...xer/stats/indexer.go:87:populateRepoIndexer() [I] Done (re)populating the repo stats indexer with existing repositories
2025/09/16 03:56:37 modules/ssh/ssh.go:387:Listen() [I] Adding SSH host key: /var/lib/gitea/data/ssh/gitea.rsa
2025/09/16 03:56:37 modules/ssh/init.go:26:Init() [I] SSH server started on :1234. Cipher list ([chacha20-poly1305@openssh.com aes128-ctr aes192-ctr aes256-ctr aes128-gcm@openssh.com aes256-gcm@openssh.com ]), key exchange algorithms ([curve25519-sha256 ecdh-sha2-nistp256 ecdh-sha2-nistp384 ecdh-sha2-nistp521 diffie-hellman-group14-sha256 diffie-hellman-group14-sha1]), MACs ([hmac-sha2-256-etm@openssh.com hmac-sha2-256 hmac-sha1])
2025/09/16 03:56:37 ...s/graceful/server.go:50:NewServer() [I] Starting new SSH server: tcp::1234 on PID: 83337
2025/09/16 03:56:38 cmd/web.go:231:func1() [F] PANIC: dial tcp 127.0.0.1:6379: connect: connection refused
gitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:239 (0x1cdb908)
code.gitea.io/gitea/routers/common/middleware.go:108 (0x2547f5a)
code.gitea.io/gitea/routers/web/web.go:270 (0x278b8e9)
code.gitea.io/gitea/routers/init.go:185 (0x2850d89)
code.gitea.io/gitea/cmd/web.go:211 (0x295c5ad)
code.gitea.io/gitea/cmd/web.go:262 (0x295cacb)
code.gitea.io/gitea/cmd/main.go:111 (0x2953422)
github.com/urfave/cli/v2@v2.27 .2/command.go:276 (0x1cc3dfd)
github.com/urfave/cli/v2@v2.27 .2/command.go:269 (0x1cc4084)
github.com/urfave/cli/v2@v2.27 .2/app.go:333 (0x1cc086a)
github.com/urfave/cli/v2@v2.27 .2/app.go:307 (0x2953f18)
code.gitea.io/gitea/cmd/main.go:172 (0x2953efc)
code.gitea.io/gitea/main.go:46 (0x2998498)
runtime/proc.go:283 (0x4471ca)
runtime/asm_amd64.s:1700 (0x484a20)
```
## After
```
2025/09/22 22:52:35 .../templates/htmlrenderer.go:118:initHTMLRenderer() [D] Creating static HTML Renderer
2025/09/22 22:52:35 routers/web/web.go:273:Routes() [F] common.Sessioner failed: failed to create session middleware: dial tcp 127.0.0.1:6379: connect: connection refused
```
---------
Signed-off-by: 6543 <6543@obermui.de >
2025-09-28 12:24:19 +00:00
Lunny Xiao and GitHub
1f32170060
Move some functions to gitrepo package ( #35503 )
2025-09-26 10:14:20 -07:00
7bf2972379
Move GetDiverging functions to gitrepo ( #35524 )
...
Extracted from #35469
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-26 15:15:42 +00:00
wxiaoguang and GitHub
d83676c97a
Fix markup init after issue comment editing ( #35536 )
...
Fix #35533
2025-09-25 09:29:32 -07:00
Lunny Xiao and GitHub
198f37e33c
Move updateref and removeref to gitrepo and remove unnecessary open repository ( #35511 )
...
Extracted from #35077
`UpdateRef` and `RemoveRef` will call git commands even for gogit
version.
2025-09-19 08:04:18 -07:00
9a0ec53ee3
Stream repo zip/tar.gz/bundle achives by default ( #35487 )
...
Initial implementation of linked proposal.
* Closes #29942
* Fix #34003
* Fix #30443
---------
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-19 11:51:21 +08:00
Lunny Xiao and GitHub
9332ff291b
Move git command to git/gitcmd ( #35483 )
...
The name cmd is already used in many places and may cause conflicts, so
I chose `gitcmd` instead to minimize potential naming conflicts.
2025-09-15 23:33:12 -07:00
wxiaoguang and GitHub
4fe1066a17
Replace gobwas/glob package ( #35478 )
...
https://github.com/gobwas/glob is unmaintained and has bugs.
2025-09-13 18:01:00 +00:00
84812e42df
Fix SSH signing key path will be displayed in the pull request UI ( #35381 )
...
Closes #35361
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-12 03:00:18 +00:00
89d7929711
Fix package link setting can only list limited repositories ( #35394 )
...
Fix #24801
<img width="1123" height="503" alt="image"
src="https://github.com/user-attachments/assets/823f4214-e08a-4506-9018-057c50e7fc52 "
/>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2025-09-11 01:50:17 +02:00
Lunny Xiao and GitHub
274f4aea7e
Fix a compare page 404 bug when the pull request disabled ( #35441 )
2025-09-09 21:04:32 -07:00
e4cb48a7e0
Fix bug when issue disabled, pull request number in the commit message cannot be redirected ( #35420 )
...
Fix #35419
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-09 12:14:06 -07:00
Lunny Xiao and GitHub
3e3c36bc30
split admin config settings templates to make it maintain easier ( #35294 )
2025-09-04 15:42:26 +00:00
d2e994db2c
Move git config/remote to gitrepo package and add global lock to resolve possible conflict when updating repository git config file ( #35151 )
...
Partially fix #32018
`git config` and `git remote` write operations create a temporary file
named `config.lock`. Since these operations are not atomic, they must
not be run in parallel. If two requests attempt to modify the same
repository concurrently—such as during a compare operation—one may fail
due to the presence of an existing `config.lock` file.
In cases where `config.lock` is left behind due to an unexpected program
exit, a global lock mechanism could allow us to safely remove the stale
lock file when a related error is detected. While this behavior is not
yet implemented in this PR, it is planned for a future enhancement.
---------
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-09-01 18:47:04 +00:00
Lunny Xiao and GitHub
4e1b8db1fc
Move HasWiki to repository service package ( #33912 )
...
Move HasWiki out of the models package to avoid referencing the absolute
wiki path directly.
2025-09-01 11:12:58 -07:00
aef4a3514c
Remove the duplicated function GetTags ( #35375 )
...
This PR removes the GetTags function from the git module and keeps only
GetTagInfos. All previous usages of GetTags have been replaced with
database-based tag functions.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-08-29 01:11:42 +00:00
wxiaoguang and GitHub
0cbaa0b662
Remove incorrect "db.DefaultContext" usages ( #35366 )
2025-08-28 03:52:43 +00:00
wxiaoguang and GitHub
60246730b5
Remove wrong "git.DefaultContext" ( #35364 )
2025-08-27 16:31:21 +00:00
wxiaoguang and GitHub
e837c998b7
Fix context usages ( #35348 )
2025-08-27 11:00:01 +00:00
c7b99c8cc7
Prevent duplicate actions email ( #35215 )
...
Trying to prevent duplicate action emails by adding an extra check on job status.
---------
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com >
Co-authored-by: Christopher Homberger <christopher.homberger@web.de >
2025-08-24 09:30:56 -07:00
Lunny Xiao and GitHub
3a969a58c2
Fix atom/rss mixed error ( #35345 )
2025-08-23 22:29:52 +00:00
a2d88cd597
Remove deprecated auth sources ( #35272 )
...
Entra ID users should use the OIDC oauth2 provider.
They will still be shown if the instance has a previous Azure AD source
configured.
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2025-08-23 20:39:05 +00:00
e844a41248
Use configurable remote name for git commands ( #35172 )
...
Closes #19403 , and makes it possible to use any remote name in code
snippets for an empty repository and pull request.
This change is very helpful to me, because I always use different name
for my gitea remote.
Uses setting config module to store the value. Default is `origin` for
backward compatibility.
### Screenshots
<details>
<summary>Empty repo</summary>
<img width="791" height="398" alt="image"
src="https://github.com/user-attachments/assets/7214053d-a8dd-4e77-8c9d-78936d9859e0 "
/>
</details>
<details>
<summary>Pull Request</summary>
<img width="591" height="452" alt="image"
src="https://github.com/user-attachments/assets/ebc3d25c-5d6d-481d-819d-9706af3c5594 "
/>
</details>
<details>
<summary>Settings page</summary>
<img width="1438" height="839" alt="image"
src="https://github.com/user-attachments/assets/d92bfa2c-7adc-4efe-95fa-0c55ad13b3f5 "
/>
</details>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-08-21 10:14:35 -07:00
c0f24bd803
Move organization's visibility change to danger zone. ( #34814 )
...
<img width="1185" alt="image"
src="https://github.com/user-attachments/assets/d48c4db2-df7c-43b3-986c-62e042190a51 "
/>
<img width="829" alt="image"
src="https://github.com/user-attachments/assets/772b8a14-6837-41f2-9d78-9f0489ef1c7d "
/>
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-08-20 20:57:42 -07:00
Nicolas Auvray and GitHub
c760e3b2b5
Display pull request in merged commit view ( #35202 )
...
Fixes #34634
---
I am not a Web dev so I'm open to any change on the design. The
important thing for me is to have the feature implemented.
Here are screenshots on a test instance:
<img width="2758" height="420" alt="Capture d'écran 2025-08-02 161710"
src="https://github.com/user-attachments/assets/30abbeb5-6139-4a91-9348-36e78f1646e6 "
/>
<img width="2769" height="520" alt="Capture d'écran 2025-08-02 161725"
src="https://github.com/user-attachments/assets/29871f05-f0b5-4a31-9ada-812780269c7d "
/>
2025-08-04 23:30:12 +00:00
Lunny Xiao and GitHub
be2a6b4414
Fix bug when review pull request commits ( #35192 )
...
The commit range in the UI follows a half-open, half-closed convention:
(,]. When reviewing a range of commits, the beforeCommitID should be set
to the commit immediately preceding the first selected commit. For
single-commit reviews, we must identify and use the previous commit of
that specific commit.
The endpoint ViewPullFilesStartingFromCommit is currently unused and can
be safely removed.
Fix #35157
Replace #35184
Partially extract from #35077
2025-08-03 10:23:10 -07:00
Lunny Xiao and GitHub
84d31bc842
A small refactor to use context in the service layer ( #35179 )
2025-07-31 03:43:54 +00:00
wxiaoguang and GitHub
c3f5ea3b1f
Fix repo file list partial reloading for submodules ( #35183 )
...
Fix the TODO and add more tests
2025-07-31 09:34:51 +08:00
wxiaoguang and GitHub
85b5877bb0
Fix various bugs ( #35177 )
...
* Fix #35144
* Fix #35117
* Fix https://github.com/go-gitea/gitea/issues/35054#issuecomment-3131793977
* Fix #35136
2025-07-30 07:08:59 +00:00
wxiaoguang and GitHub
86aafea3fb
Fix session gob ( #35128 )
...
Fix #35126
2025-07-20 01:49:36 +00:00
wxiaoguang and GitHub
8f91bfe9d8
Fix submodule parsing when the gitmodules is missing ( #35109 )
...
Follow up #35096 , fix #35095 , fix #35115 and add more tests
The old code used some fragile behaviors which depend on the "nil"
receiver. This PR should be a complete fix for more edge cases.
2025-07-18 09:42:44 +00:00
Lunny Xiao and GitHub
37958e486a
Rename pull request GetGitRefName to GetGitHeadRefName ( #35093 )
2025-07-16 21:33:33 +08:00
e1e4815a1c
Redirect to a presigned URL of HEAD for HEAD requests ( #35088 )
...
Resolves https://github.com/go-gitea/gitea/issues/35086 .
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-16 11:22:45 +00:00
0d00ec7eed
Send email on Workflow Run Success/Failure ( #34982 )
...
Closes #23725
/claim #23725
---------
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: ChristopherHX <christopher.homberger@web.de >
2025-07-15 18:54:31 -07:00
d08459820d
Improve submodule relative path handling ( #35056 )
...
Fix #35054
---------
Co-authored-by: Giteabot <teabot@gitea.io >
2025-07-14 23:28:34 +08:00
56eccb4995
Add Notifications section in User Settings ( #35008 )
...
Related: #34982
---------
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-11 10:17:52 +08:00
wxiaoguang and GitHub
a5a3d9b101
Refactor OpenIDConnect to support SSH/FullName sync ( #34978 )
...
* Fix #26585
* Fix #28327
* Fix #34932
2025-07-10 18:35:59 +00:00
32152a0ac0
Also display "recently pushed branch" alert on PR view ( #35001 )
...
This commit adds the "You recently pushed to branch X" alert also to PR
overview, as opposed to only the repository's home page.
GitHub also shows this alert on the PR list, as well as the home page.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
Co-authored-by: Giteabot <teabot@gitea.io >
2025-07-10 17:17:56 +00:00
ea809a5220
Partially refresh notifications list ( #35010 )
...
This PR prevents full reloads for the notifications list when changing a
notifications status (read, unread, pinned).
---------
Co-authored-by: Anton Bracke <anton.bracke@fastleansmart.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-10 04:15:14 +00:00
wxiaoguang and GitHub
55f350542c
Refactor mail template and support preview ( #34990 )
2025-07-09 10:25:25 +08:00
NorthRealm and GitHub
6b42ea1e54
Rerun job only when run is done ( #34970 )
...
For consistency, limit rerunning Job(s) to only when Run is in Done status.
2025-07-06 10:47:02 -07:00
silverwind and GitHub
95a935aca0
Enable gocritic equalFold and fix issues ( #34952 )
...
Continuation of https://github.com/go-gitea/gitea/pull/34678 .
---------
Signed-off-by: silverwind <me@silverwind.io >
2025-07-06 16:53:34 +00:00
wxiaoguang and GitHub
e0745eb14d
Refactor webhook and fix feishu/lark secret ( #34961 )
2025-07-06 06:04:08 +00:00
wxiaoguang and GitHub
3533263ced
Improve OAuth2 provider (correct Issuer, respect ENABLED) ( #34966 )
...
1. Make "Issuer" strictly follow the spec (see comment)
2. Make "/.well-known/openid-configuration" respond 404 if the OAuth2
provider is not enabled.
Then by the way, remove the JSEscape template helper because it is not
needed any more.
2025-07-06 13:36:45 +08:00
wxiaoguang and GitHub
70685a9489
Fix git graph page ( #34948 )
...
fix #34946
2025-07-04 15:41:19 +00:00
71e151cc22
Refactor head navbar icons ( #34922 )
...
Co-authored-by: silverwind <me@silverwind.io >
Co-authored-by: Giteabot <teabot@gitea.io >
2025-07-04 13:03:22 +02:00
wxiaoguang and GitHub
d6d643fe86
Fix http auth header parsing ( #34936 )
...
Using `strings.EqualFold` is wrong in many cases.
2025-07-03 03:02:38 +00:00
wxiaoguang and GitHub
90f96c301e
Fix PR toggle WIP ( #34920 )
...
Fix #34919
---------
Signed-off-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-01 16:32:39 +08:00
8dbf13b1cb
Follow file symlinks in the UI to their target ( #28835 )
...
Symlinks are followed when you click on a link next to an entry, either
until a file has been found or until we know that the link is dead.
When the link cannot be accessed, we fall back to the current behavior
of showing the document containing the target.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-07-01 06:55:36 +08:00
09bb19ad01
Fix: RPM package download routing & missing package version count ( #34909 )
...
* Fix RPM package download routing
* Fix missing package version count
---------
Signed-off-by: Exploding Dragon <explodingfkl@gmail.com >
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com >
2025-06-30 23:02:30 +08:00
6543andGitHub
Lunny XiaoandGitHub
Nicolas AuvrayandGitHub
