SagePtr
043ab2cd59
Fix null pointer dereference in ParseCommitWithSignature ( #4962 )
2018-09-20 13:49:07 +08:00
Morgan Bazalgette
b730498f02
Don't write to log NoCommitterAccount ( #3621 )
...
* Don't write to log NoCommitterAccount
It's way too verbose, and the information is also printed to the user
already. Fixes #3602 .
* ignore err only if it's a ErrUserNotExist
* Replace with IsErrUserNotExist
2018-03-04 10:45:01 +08:00
Lunny Xiao
f2e20c81b6
Refactor struct's time to remove unnecessary memory usage ( #3142 )
...
* refactor struct's time to remove unnecessary memory usage
* use AsTimePtr simple code
* fix tests
* fix time compare
* fix template on gpg
* use AddDuration instead of Add
2017-12-11 06:37:04 +02:00
Julian Scholle
92123fe82a
GPG key email verification no longer case sensitive ( #2661 ) ( #2663 )
...
* GPG key email verification no longer case sensitive (#2661 )
* case insensitive GPG key email verification now cached (#2661 )
Signed-off-by: Julian Scholle <julian.scholle@googlemail.com >
2017-10-06 23:28:21 +03:00
Ethan Koenig
aa962deec0
Replace deprecated Id method with ID ( #2655 )
2017-10-05 07:43:04 +03:00
Lunny Xiao
a8717e5e3a
Use AfterLoad instead of AfterSet on Structs ( #2628 )
...
* use AfterLoad instead of AfterSet on Structs
* fix the comments on AfterLoad
* fix the comments on action AfterLoad
2017-10-01 19:52:35 +03:00
Ethan Koenig
4cb9394a97
Fix lint errors ( #2547 )
2017-09-19 11:08:30 +03:00
Antoine GIRARD
7c417bbb0d
Only check at least one email gpg key ( #2266 )
...
* Only require one email (possibly not yet validated)
* Update message error and check validation of commit
* Add integrations tests
* Complete integration for import
* Add pre-check/optimization
* Add some test (not finished)
* Finish
* Fix fixtures
* Fix typo
* Don't guess key ID
2017-09-05 21:45:18 +08:00
Lunny Xiao
33f3165296
remove unnecessary blank lines and wrong error log
2017-06-28 19:00:08 +02:00
Lauris BH
6db387a21e
Refactor session close as xorm already does everything needed internally ( #2020 )
2017-06-21 08:57:05 +08:00
Lauris BH
1a906f800d
Fix GPG email checking to be case insensitive ( #1988 )
2017-06-17 18:56:40 +08:00
Antoine GIRARD
274149dd14
Switch to keybase go-crypto (for some elliptic curve key) + test ( #1925 )
...
* Switch to keybase go-crypto (for some elliptic curve key) + test
* Use assert.NoError
and add a little more context to failing test description
* Use assert.(No)Error everywhere 🌈
and assert.Error in place of .Nil/.NotNil
2017-06-14 08:43:43 +08:00
Antoine GIRARD
8371f94d06
Rework SSH key management UI to add GPG ( #1293 )
...
* Rework SSH key management UI to add GPG
* Add more detail to gpg key display
* Update CHANGELOG.md
* Implement deletion UI
* Implement adding gpg UI
* Various fixes
- Fix duplicate entry in locale
- Re-generate hash before verification since they are consumed
* Add missing translation
* Split template
* Catch not found/verified email error
2017-04-26 21:10:43 +08:00
Antoine GIRARD
14fe9010ae
GPG commit validation ( #1150 )
...
* GPG commit validation
* Add translation
+ some little fix
* Move hash calc after retrieving of potential key + missing translation
* Add some little test
2017-03-22 18:43:54 +08:00
Lunny Xiao
608cd54a68
fix gpg wrong column types
2017-03-20 02:55:07 +01:00
Antoine GIRARD
ca1c3f1926
Implement GPG api ( #710 )
...
* Implement GPG API
* Better handle error
* Apply review recommendation + simplify database operations
* Remove useless comments
2017-03-16 09:27:35 +08:00
