zeripath and GitHub
66b31786d3
Prevent panic in stopwatch ( #10670 ) ( #10673 )
...
Signed-off-by: Andrew Thornton <art27@cantab.net >
2020-03-08 21:14:27 +02:00
John Olheiser and GitHub
21eaeb8418
Issue writers perms can modify issues ( #10623 ) ( #10626 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-03-06 04:42:20 +00:00
Lauris BH and GitHub
9a929ad17f
Handle deleted base branch in PR ( #10618 ) ( #10619 )
...
Signed-off-by: Andrew Thornton <art27@cantab.net >
2020-03-05 22:23:34 +02:00
John Olheiser and GitHub
6f5656ab0e
Logout POST action ( #10582 ) ( #10585 )
...
* Change logout to POST
* Update for redirect
* Revert octicon to font
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-03-03 13:54:15 +08:00
e4a876cee1
Admin page for managing user e-mail activation ( #10557 ) ( #10579 )
...
* Admin page for managing user e-mail activation (#10557 )
* Implement mail activation admin panel
* Apply suggestions by @lunny
* Add UI for user activated emails
* Prevent admin from self-deactivate; add modal
Co-authored-by: zeripath <art27@cantab.net >
* Fix pagination options downgrade
Co-authored-by: zeripath <art27@cantab.net >
2020-03-02 17:09:37 -03:00
James Lakin and GitHub
65dceb6a40
Fix redirection path if Slack webhook channel is invalid ( #10566 )
...
The path to the hook config is already defined by orgRepoCtx
2020-03-02 13:54:07 +02:00
Andreas Shimokawa and GitHub
76878fd69b
Fix 404 after activating secondary email (backport of #10547 ) ( #10553 )
2020-03-01 13:27:13 +01:00
caa2aeaa52
Show Signer in commit lists and add basic trust ( #10425 ) ( #10524 )
...
Backport #10425
Backport #10511
* Show Signer in commit lists and add basic trust (#10425 )
Show the avatar of the signer in the commit list pages as we do not
enforce that the signer is an author or committer. This makes it
clearer who has signed the commit.
Also display commits signed by non-members differently from
members and in particular make it clear when a non-member signer
is different from the committer to help reduce the risk of
spoofing.
Signed-off-by: Andrew Thornton <art27@cantab.net >
Fix the signing icon in the view_list.tmpl page (#10511 )
Co-Authored-By: silverwind <me@silverwind.io >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-28 14:18:02 -03:00
6543 and GitHub
11300ee582
Fix potential bugs ( #10513 ) ( #10518 )
...
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
2020-02-28 00:12:23 -03:00
5d11ccc9e1
Handle push rejection message in Merge & Web Editor ( #10373 ) ( #10497 )
...
Backport #10373
* Handle push rejection message in Merge
* Fix sanitize, adjust message handling
* Handle push-rejection in webeditor CRUD too
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-02-27 15:37:11 +02:00
John Olheiser and GitHub
1fbdd9335f
Fix double PR notification from API ( #10482 ) ( #10486 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-26 22:39:39 +02:00
John Olheiser and GitHub
e9061a537c
Fix admin notices ( #10480 ) ( #10483 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-26 11:14:37 -06:00
John Olheiser and GitHub
ed664a9e1d
Change admin dashboard to POST ( #10465 ) ( #10466 )
...
* Change admin dashboard to POST (#10465 )
* Add form and convert to POST
* Redirect for flash
* Convert octicons back to fa for 1.11
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-25 17:42:43 -06:00
4cb18601ff
Change action GETs to POST ( #10462 ) ( #10464 )
...
* Change action GETs to POST
* submite = submit + smite
* No more # href
* Fix test
* Match other tests
* Explicit csrf
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-25 15:08:21 -06:00
6543 and GitHub
9e6ad64d48
Trigger webhooks on issue label-change via API too ( #10421 ) ( #10439 )
...
* trigger webhooks with api too
* fix comment
* notify report old too
* CI restart
* restart CI again
* remove duplicated code
2020-02-24 14:30:59 +00:00
d3b6f001fe
Various fixes in login sources ( #10428 ) ( #10429 )
...
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com >
2020-02-23 22:46:17 +02:00
Lauris BH and GitHub
80eb50655a
Fix followers and following tabs in profile ( #10202 ) ( #10203 )
2020-02-09 21:00:24 +00:00
John Olheiser and GitHub
2cd2614eaa
Fix push-create SSH bugs ( #10145 ) ( #10151 )
...
* Attempt to fix push-create SSH bugs
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix binding
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Invalid ctx
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-02-05 15:50:06 +01:00
6543 and GitHub
0129e76ef5
Prevent DeleteUser API abuse ( #10125 ) ( #10128 )
...
* fix & co
* word suggestions from @jolheiser
2020-02-03 19:44:06 +02:00
6896dad675
working part of #9998 ( #10114 ) ( #10115 )
...
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: zeripath <art27@cantab.net >
2020-02-03 11:19:04 +08:00
Lunny Xiao and GitHub
049af0d3d0
Fix branch page pull request title and link error ( #10092 ) ( #10097 )
...
* Fix branch page pull request title and link error (#10092 )
2020-02-01 15:14:56 +00:00
Lunny Xiao and GitHub
491cbeca67
Fix milestone API state parameter unhandled ( #10049 ) ( #10052 )
...
* Fix milestone API state parameter unhandled
* Fix test
2020-01-29 18:01:44 +02:00
zeripath and Lauris BH
895d92ffe5
Ensure that feeds are appropriately restricted ( #10018 ) ( #10019 )
...
* Ensure that feeds are appropriately restricted
* Placate golangci-lint
2020-01-28 23:54:09 +02:00
Lunny Xiao and zeripath
1e73dd2446
Fix wiki raw view on sub path ( #10002 ) ( #10040 )
...
* Fix wiki raw view on sub path
* Add test for subpath wiki raw file
* Fix bug
2020-01-28 15:10:25 +00:00
Lunny Xiao and Lauris BH
0dced15c1a
Fix wrong hint when status checking is running on pull request view ( #9886 ) ( #9928 )
...
* Fix wrong hint when status checking is running on pull request view
* fix lint
* fix test
* fix test
* fix wrong tmpl
* fix import
* rename function name
2020-01-22 08:06:11 +02:00
ff508c9c9b
Add option to prevent LDAP from deactivating everything on empty search ( #9879 ) ( #9896 )
...
* Add option to prevent LDAP from deactivating everything on empty search
* Update options/locale/locale_en-US.ini
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2020-01-20 21:18:23 +02:00
f96c1a2c79
Fix wrong permissions check when issues/prs shared operations ( #9885 ) ( #9889 )
...
* Fix wrong permissions check when issues/prs shared operations
* move redirect to the last of the function
* fix swagger
Co-authored-by: zeripath <art27@cantab.net >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-20 17:59:33 +02:00
e878d743f4
Ensure that 2fa is checked on reset-password ( #9857 ) ( #9876 )
...
* Ensure that 2fa is checked on reset-password
* Apply suggestions from code review
Co-Authored-By: Lauris BH <lauris@nix.lv >
* Properly manage scratch_code regeneration
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-19 23:21:21 +00:00
Lunny Xiao and techknowlogick
8add1dfacc
Fix issues/pulls dependencies problems ( #9842 ) ( #9864 )
...
* Fix issues/pulls dependencies problems
* fix swagger and api param name
* fix js
2020-01-19 12:56:57 -05:00
6543 and techknowlogick
95cb921097
fix ( #9837 )
2020-01-17 23:31:46 -05:00
fe46185407
Fix download file wrong content-type ( #9825 ) ( #9834 )
...
* Fix download file wrong content-type
* change the error text to be more precise
* fix test
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-17 15:11:20 +01:00
Lunny Xiao and Antoine GIRARD
69a2a29c33
Fix wrong identify poster on a migrated pull request when submi… ( #9827 ) ( #9830 )
2020-01-17 13:38:11 +01:00
e2ddc42377
Fix compare ( #9808 ) ( #9814 )
...
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: techknowlogick <matti@mdranta.net >
2020-01-17 10:08:28 +08:00
3521177a34
Fix push-to-create ( #9772 ) ( #9797 )
...
* Fix push-to-create
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Check URL path and service
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Send dummy payload on receive-pack GET
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* The space was actually a NUL byte
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Use real bare repo instead of manufactured payload
Signed-off-by: jolheiser <john.olheiser@gmail.com >
Co-authored-by: zeripath <art27@cantab.net >
2020-01-16 07:40:37 +02:00
Lunny Xiao and zeripath
c8bb0ecf52
Fix missing msteam webhook on organization ( #9781 ) ( #9794 )
2020-01-16 03:09:47 +00:00
David Svantesson and Antoine GIRARD
42663a687c
Fix add team on collaborator page when same name as organization ( #9778 )
2020-01-15 14:18:18 +01:00
dbeef6bb02
[BugFix] [API] /repos/issues/search ( #9698 ) ( #9724 )
...
* fix
* fix options
* add TEST
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com >
2020-01-12 10:20:49 +00:00
Lunny Xiao and zeripath
b9309e52f0
Move wiki related funtions from models to services/wiki ( #9355 )
...
* Move wiki related funtions from models to services/wiki
2020-01-07 18:27:36 +00:00
zeripath and GitHub
e5d8e2d10c
Branches not at ref commit ID should not be listed as Merged ( #9614 )
...
Once a branch has been merged if the commit ID no longer equals that of
the pulls ref commit id don't offer to delete the branch on the pull screen
and don't list it as merged on branches.
Fix #9201
When looking at the pull page we should also get the commits from the refs/pulls/x/head
Fix #9158
2020-01-07 17:06:14 +00:00
62eb1b0f25
Graceful Queues: Issue Indexing and Tasks ( #9363 )
...
* Queue: Add generic graceful queues with settings
* Queue & Setting: Add worker pool implementation
* Queue: Add worker settings
* Queue: Make resizing worker pools
* Queue: Add name variable to queues
* Queue: Add monitoring
* Queue: Improve logging
* Issues: Gracefulise the issues indexer
Remove the old now unused specific queues
* Task: Move to generic queue and gracefulise
* Issues: Standardise the issues indexer queue settings
* Fix test
* Queue: Allow Redis to connect to unix
* Prevent deadlock during early shutdown of issue indexer
* Add MaxWorker settings to queues
* Merge branch 'master' into graceful-queues
* Update modules/indexer/issues/indexer.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Update modules/indexer/issues/indexer.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Update modules/queue/queue_channel.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Update modules/queue/queue_disk.go
* Update modules/queue/queue_disk_channel.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* Rename queue.Description to queue.ManagedQueue as per @guillep2k
* Cancel pool workers when removed
* Remove dependency on queue from setting
* Update modules/queue/queue_redis.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
* As per @guillep2k add mutex locks on shutdown/terminate
* move unlocking out of setInternal
* Add warning if number of workers < 0
* Small changes as per @guillep2k
* No redis host specified not found
* Clean up documentation for queues
* Update docs/content/doc/advanced/config-cheat-sheet.en-us.md
* Update modules/indexer/issues/indexer_test.go
* Ensure that persistable channel queue is added to manager
* Rename QUEUE_NAME REDIS_QUEUE_NAME
* Revert "Rename QUEUE_NAME REDIS_QUEUE_NAME"
This reverts commit 1f83b4fc9b18600385+guillep2k@users.noreply.github.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com >
2020-01-07 12:23:09 +01:00
6543 and Lauris BH
bcac7cb934
fix swagger description of reaction API ( #9617 )
2020-01-06 06:58:13 +02:00
6543 and zeripath
133ae18b61
[BugFix] Hide public repos owned by private orgs ( #9609 )
...
* Restrict AllPublic to actually public repos.
* Add new parameter to add in AllLimited Repos
2020-01-05 18:48:47 +00:00
John Olheiser and techknowlogick
08424648ae
Fix create bugs ( #9606 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2020-01-04 21:39:14 -05:00
David Svantesson and techknowlogick
03d59bcd1d
Fix access issues on milestone and issue overview pages. ( #9603 )
...
* Fix access issues on milestone and issue overview pages.
* Fix filter algorithm
2020-01-04 20:23:29 -05:00
Antoine GIRARD and Lauris BH
8b24073713
Only serve attachments when linked to issue/release and if accessible by user ( #9340 )
...
* test: add current attachement responses
* refactor: check if attachement is linked and accessible by user
* chore: clean TODO
* fix: typo attachement -> attachment
* revert un-needed go.sum change
* refactor: move models logic to models
* fix TestCreateIssueAttachment which was wrongly successful
* fix unit tests with unittype added
* fix unit tests with changes
* use a valid uuid format for pgsql int. test
* test: add unit test TestLinkedRepository
* refactor: allow uploader to access unlinked attachement
* add missing blank line
* refactor: move to a separate function repo.GetAttachment
* typo
* test: remove err test return
* refactor: use repo perm for access checking generally + 404 for all reject
2020-01-05 01:20:08 +02:00
bedd7b2833
Fix error logged when repos qs is empty ( #9591 )
...
* Fix error logged when repos qs is empty
* Update routers/user/home.go
Co-Authored-By: Lauris BH <lauris@nix.lv >
Co-authored-by: techknowlogick <matti@mdranta.net >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-03 23:39:12 +02:00
ea707f5a77
Add branch protection option to block merge on requested changes. ( #9592 )
...
* Add branch protection option to block merge on requested changes.
* Add migration step
* Fix check to correct negation
* Apply suggestions from code review
Language improvement.
Co-Authored-By: John Olheiser <42128690+jolheiser@users.noreply.github.com >
* Copyright year.
Co-authored-by: John Olheiser <42128690+jolheiser@users.noreply.github.com >
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-03 19:47:09 +02:00
6543 and Lauris BH
134e3fdf3d
[API] dont reqToken on GetReactions ( fix #9543 ) ( #9548 )
...
* dont reqToken on GetReactions
* ctx.Repo.CanWrite has ctx.User.IsAdmin in It
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-02 23:27:31 +02:00
6543 and Lauris BH
9cf7048a6a
Dont trigger notification twice on issue assignee change ( #9582 )
2020-01-02 04:07:15 +02:00
c620eb5b2d
Fix #9189 - API Allow only specific Colums to be updated on Issue ( #9539 )
...
* dont insert "-1" in any case to issue.poster_id
* Make sure API cant override importand fields
* code format
* fix lint
* WIP test
* add missing poster_id
* fix test
* user.IsGhost handle nil
* CI.restart()
* make sure no -1 is realy added
* CI.restart()
* @lunny suggestion remove some not allowed fields
* seperate issue.LoadMilestone
* load milestone and return it on IssueEdit via API
* extend Test for TestAPIEditIssue
* fix fixtures
* declare allowedColumnsUpdateIssueByAPI only once
* Update Year
* no var just write id drecty into func cal
Co-authored-by: Lauris BH <lauris@nix.lv >
2020-01-01 17:51:10 -05:00
zeripathandGitHub
John OlheiserandGitHub
Lauris BHandGitHub
James LakinandGitHub
Andreas ShimokawaandGitHub
6543andGitHub
John OlheiserandGitHub
Lunny XiaoandGitHub
David SvantessonandAntoine GIRARD