gitea

tdsds.com/gitea

Fork 0

mirror of https://github.com/go-gitea/gitea synced 2024-11-05 09:44:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Giteabot	c9b2aaed0e	Improve user experience for outdated comments (#29050 ) (#29086 ) Backport #29050 by wxiaoguang Try to improve #28949 1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings consistent user experience, and sometimes the "outdated (source changed)" comments are still valuable. 2. Show a friendly message if the comment won't show, then the end users won't fell that "the comment disappears" (it is the special case when `ShowOutdatedComments = false`) Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>	2024-02-08 10:29:54 +08:00
wxiaoguang	f01bed2443	Avoid double-unescaping of form value (#26853 ) 1. The old `prepareQueryArg` did double-unescaping of form value. 2. By the way, remove the unnecessary `ctx.Flash = ...` in `MockContext`. Co-authored-by: Giteabot <teabot@gitea.io>	2023-09-01 12:01:36 +00:00
wxiaoguang	e8aae43f56	Move web/api context related testing function into a separate package (#26859 ) Just like `models/unittest`, the testing helper functions should be in a separate package: `contexttest` And complete the TODO: > // TODO: move this function to other packages, because it depends on "models" package	2023-09-01 11:26:07 +00:00

Author

SHA1

Message

Date

Giteabot

c9b2aaed0e

Improve user experience for outdated comments (#29050 ) (#29086 )

Backport #29050 by wxiaoguang

Try to improve #28949

1. Make `ctx.Data["ShowOutdatedComments"] = true` by default: it brings
consistent user experience, and sometimes the "outdated (source
changed)" comments are still valuable.
2. Show a friendly message if the comment won't show, then the end users
won't fell that "the comment disappears" (it is the special case when
`ShowOutdatedComments = false`)

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>

2024-02-08 10:29:54 +08:00

wxiaoguang

f01bed2443

Avoid double-unescaping of form value (#26853 )

1. The old `prepareQueryArg` did double-unescaping of form value.
2. By the way, remove the unnecessary `ctx.Flash = ...` in
`MockContext`.

Co-authored-by: Giteabot <teabot@gitea.io>

2023-09-01 12:01:36 +00:00

wxiaoguang

e8aae43f56

Move web/api context related testing function into a separate package (#26859 )

Just like `models/unittest`, the testing helper functions should be in a
separate package: `contexttest`

And complete the TODO:

> // TODO: move this function to other packages, because it depends on
"models" package

2023-09-01 11:26:07 +00:00

3 Commits