gitea

tdsds.com/gitea

Fork 0

mirror of https://github.com/go-gitea/gitea synced 2024-11-13 21:54:24 +00:00

Commit Graph

Author	SHA1	Message	Date
KN4CK3R	022552d5b6	Rework markup link rendering (#26745 ) (#28803 ) Backport #26745 Fixes #26548 This PR refactors the rendering of markup links. The old code uses `strings.Replace` to change some urls while the new code uses more context to decide which link should be generated. The added tests should ensure the same output for the old and new behaviour (besides the bug). We may need to refactor the rendering a bit more to make it clear how the different helper methods render the input string. There are lots of options (resolve links / images / mentions / git hashes / emojis / ...) but you don't really know what helper uses which options. For example, we currently support images in the user description which should not be allowed I think: <details> <summary>Profile</summary> https://try.gitea.io/KN4CK3R ![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5) </details>	2024-01-16 02:13:29 +00:00
Jason Song	59d2189875	Fix missing commit message body when the message has leading newlines (#25418 ) Commit with `echo "\nmessage after a blank line\nsecond line of the message" \| git commit --cleanup=verbatim -F -` and push. <img width="1139" alt="image" src="https://github.com/go-gitea/gitea/assets/9418365/f9a2c28c-e307-4c78-9e31-3d3ace7b9274">	2023-06-21 09:14:34 +00:00

Author

SHA1

Message

Date

KN4CK3R

022552d5b6

Rework markup link rendering (#26745 ) (#28803 )

Backport #26745
Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary>

https://try.gitea.io/KN4CK3R


![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

2024-01-16 02:13:29 +00:00

Jason Song

59d2189875

Fix missing commit message body when the message has leading newlines (#25418 )

Commit with `echo "\nmessage after a blank line\nsecond line of the
message" | git commit --cleanup=verbatim -F -` and push.

<img width="1139" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/f9a2c28c-e307-4c78-9e31-3d3ace7b9274">

2023-06-21 09:14:34 +00:00

2 Commits