John Olheiser
1707f59966
Remove text from action-only webhooks ( #9377 )
...
* Remove text from contextual webhooks
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Missed one in Telegram
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-17 08:28:19 +08:00
John Olheiser
33662399d5
Fix double webhook for new PR ( #9375 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-16 15:27:18 -05:00
John Olheiser
1bbb2a637c
Add SimpleMDE to compare page for PRs ( #9376 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-16 14:57:30 -05:00
GiteaBot
4714fa6642
[skip ci] Updated translations via Crowdin
2019-12-16 15:57:59 +00:00
Benno
121977c36f
Add SimpleMDE and Fix Image Paste for Issue/Comment Editor ( #9197 )
...
* update #9132 and #8834 - add SimpleMDE for issue and fix image paste for comment editor
* attache tribute to simplemde
* update #9197 force simplemde file input event when backspace press
2019-12-16 23:56:35 +08:00
Mario Lubenka
61db834904
Change target branch for pull request ( #6488 )
...
* Adds functionality to change target branch of created pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use const instead of var in JavaScript additions
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Check if branches are equal and if PR already exists before changing target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Make sure to check all commits
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Print error messages for user as error flash message
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Disallow changing target branch of closed or merged pull requests
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Resolve conflicts after merge of upstream/master
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Change order of branch select fields
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes duplicate check
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use ctx.Tr for translations
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Recompile JS
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Use correct translation namespace
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove redundant if condition
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves most change branch logic into pull service
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Completes comment
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Add Ref to ChangesPayload for logging changed target branches
instead of creating a new struct
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Revert changes to go.mod
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Directly use createComment method
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return 404 if pull request is not found. Move written check up
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Remove variable declaration
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return client errors on change pull request target errors
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Return error in commit.HasPreviousCommit
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds blank line
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Test patch before persisting new target branch
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update patch before testing (not working)
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes patch calls when changeing pull request target
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Removes unneeded check for base name
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Moves ChangeTargetBranch completely to pull service. Update patch status.
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Set webhook mode after errors were validated
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Update PR in one transaction
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Move logic for check if head is equal with branch to pull model
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adds missing comment and simplify return
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
* Adjust CreateComment method call
Signed-off-by: Mario Lubenka <mario.lubenka@googlemail.com >
2019-12-16 14:20:25 +08:00
Lunny Xiao
59d6401486
Use ioutil.TmpDir for new created temp directory ( #9368 )
...
* Use os.TmpDir for new created temp directory
* fix error message
2019-12-16 13:17:55 +08:00
Lunny Xiao
43ada65571
remove unused method and rename createcommentWithNoAction ( #9367 )
2019-12-16 11:54:24 +08:00
Lunny Xiao
67b316a954
Refactor comment ( #9330 )
...
* Refactor comment
* fix test
* improve code
2019-12-15 16:57:34 -05:00
Lunny Xiao
c6b3c5bcef
Fix cache problem on dashboard ( #9358 )
2019-12-15 15:44:23 -05:00
silverwind
7217b703e9
Combine Drone release steps ( #9338 )
...
* Combine Drone release steps
Fixes missing JS/CSS because drone did unwanted parallelization of the
js/css task and the generate task. Combined the tasks into one and made
'make release' work standalone.
Fixes: https://github.com/go-gitea/gitea/issues/9324
Fixes: https://github.com/go-gitea/gitea/issues/9362
* move js/css to generate dependencies
* remove unneccessary go-all target
* remove go target as well
2019-12-15 13:06:36 -05:00
zeripath
60b31c8f01
Fix the intermittent TestGPGGit failures ( #9360 )
...
* Fix the intermittent TestGPGGit failures
Reattempt to open the listener if the port is busy with a delay up to a second
Switch from generating a private key each time, just use a known good key
2019-12-15 16:21:16 +00:00
Brad Albright
f6b29012e0
Add /milestones endpoint ( #8733 )
...
Create a /milestones endpoint which basically serves as a dashboard view for milestones, very similar to the /issues or /pulls page.
Closes #8232
2019-12-15 14:20:08 +00:00
zeripath
7cc16740a5
Fix missed change to GetManager() ( #9361 )
2019-12-15 13:15:17 +00:00
zeripath
3abe17f9e0
Sign protected branches ( #8993 )
...
* Move SignMerge to PullRequest
* Add approved signing mode
* As per @guillep2k comment
2019-12-15 11:06:31 +00:00
zeripath
e3c3b33ea7
Graceful: Xorm, RepoIndexer, Cron and Others ( #9282 )
...
* Change graceful to use a singleton obtained through GetManager instead of a global.
* Graceful: Make TestPullRequests shutdownable
* Graceful: Make the cron tasks graceful
* Graceful: AddTestPullRequest run in graceful ctx
* Graceful: SyncMirrors shutdown
* Graceful: SetDefaultContext for Xorm to be HammerContext
* Avoid starting graceful for migrate commands and checkout
* Graceful: DeliverHooks now can be shutdown
* Fix multiple syncing errors in modules/sync/UniqueQueue & Make UniqueQueue closable
* Begin the process of making the repo indexer shutdown gracefully
2019-12-15 09:51:28 +00:00
Antoine GIRARD
8bea92c3dc
test: command keys ( #9357 )
2019-12-15 08:11:31 +00:00
Lunny Xiao
ce2d488c94
Move PushToBaseRepo from models to services/pull ( #9352 )
2019-12-15 04:28:51 +01:00
John Olheiser
6715677b2b
Push to create repo ( #8419 )
...
* Refactor
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Add push-create to SSH serv
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Cannot push for another user unless admin
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Get owner in case admin pushes for another user
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Set new repo ID in result
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Update to service and use new org perms
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Move pushCreateRepo to services
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix import order
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Changes for @guillep2k
* Check owner (not user) in SSH
* Add basic tests for created repos (private, not empty)
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-15 10:49:52 +08:00
GiteaBot
47c24be293
[skip ci] Updated translations via Crowdin
2019-12-14 17:32:24 +00:00
Lunny Xiao
7b2ff82d20
Move some repository methods from models to modules/repository ( #9353 )
...
* Move some repository methods from models to modules/repository
* fix test
2019-12-14 18:30:01 +01:00
zeripath
2904abdc22
DefaultBranch needs to be prefixed by BranchPrefix ( #9356 )
2019-12-14 21:29:41 +08:00
Lunny Xiao
484e3dc5a9
site admin could view org's members ( #9346 )
2019-12-14 01:36:59 -05:00
zeripath
f6ba912cd6
Default NO_REPLY_ADDRESS to DOMAIN ( #9325 )
...
* Default NO_REPLY_ADDRESS to DOMAIN
The default NO_REPLY_ADDRESS was previously noreply.example.org
This PR changes this to default to the default DOMAIN for gitea.
* Change default to noreply.%(DOMAIN)s
* Change default to "noreply" + Domain
2019-12-13 23:14:43 -05:00
Lunny Xiao
bfcce5f86c
Remove release attachments which repository has been deleted ( #9334 )
2019-12-13 22:30:39 -05:00
David Svantesson
f46176a418
Fix PR/issue redirects when having external tracker ( #9339 )
...
* Make sure only issues are redirected to external tracker
* Ensure correct redirects for pulls after dependency or watch.
* NewIssuePost is always issues so no need to redirect with type.
2019-12-14 01:53:32 +01:00
Antoine GIRARD
81a52442a1
deps: update and fix chardet import ( #9351 )
2019-12-14 02:15:48 +02:00
zeripath
74179d1b5e
Remove SavePatch and generate patches on the fly ( #9302 )
...
* Save patches to temporary files
* Remove SavePatch and generate patches on the fly
* Use ioutil.TempDir
* fixup! Use ioutil.TempDir
* fixup! fixup! Use ioutil.TempDir
* RemoveAll LocalCopyPath() in initIntergrationTest
* Default to status checking on PR creation
* Remove unnecessary set to StatusChecking
* Protect against unable to load repo
* Handle conflicts
* Restore original conflict setting
* In TestPullRequests update status to StatusChecking before running TestPatch
2019-12-13 23:21:06 +01:00
John Olheiser
8f16a2c37b
Update _headers ( #9349 )
2019-12-13 22:03:09 +02:00
John Olheiser
f09cdb239c
Fix protected branch using IssueID ( #9348 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-13 10:37:10 -05:00
Mura Li
6e6936d73d
Fix nondeterministic behavior ( #9341 )
...
The underlying implementation of os.exec uses channels and goroutines.
It is possible to have time-variant error values returned from Cmd.Wait
depending on which comes first.
Also, the git subcommand and options should be separated tokens.
Fixes a flaky test in modules/git/command_test.go
2019-12-13 17:03:38 +08:00
Matthew Bramer
39db99a595
Supports both CMD and PowerShell ( #9344 )
...
sc is aliased to Set-Content in PowerShell and these commands will not work without the `.exe` extension.
2019-12-13 00:13:38 -05:00
techknowlogick
6442e003c5
Youtrack now supports Gitea ( #9343 )
...
* Youtrack now supports Gitea
* Update third-party-tools.en-us.md
2019-12-12 23:28:54 -05:00
jaqra
27f68bc96f
Fix notification page panic ( #9337 )
2019-12-13 03:08:34 +01:00
Lunny Xiao
ba1acf5b50
fix issue indexer not triggered when migrating a repository ( #9332 )
2019-12-12 23:46:43 +02:00
zeripath
dc2fe9801f
Make repository management section handle lfs locks ( #8726 )
...
* Make repository maangement section handle lfs locks
* Add check attribute handling and handle locking paths better
* More cleanly check-attributes
* handle error
* Check if file exists in default branch before linking to it.
* fixup
* Properly cleanPath
* Use cleanPath
* Sigh
2019-12-12 21:18:07 +08:00
Lunny Xiao
751cfb805d
Fix bug that release attachment files not deleted when deleting repository ( #9322 )
...
* Fix bug that release attachment files not deleted when deleting repository
* improve code
* add quote
* improve code
2019-12-12 13:31:05 +08:00
6543
aceb1085c7
[API] extend StopWatch ( #9196 )
...
* squash api-stopwatch
* fix prepair logic! + add Tests
* fix lint
* more robust time compare
* delete responce 202 -> 204
* change http responce in test too
2019-12-11 23:23:05 -05:00
John Olheiser
382936a668
Add SyncTags to uploader interface ( #9326 )
...
* Add sync tags to interface
Signed-off-by: jolheiser <john.olheiser@gmail.com >
* Fix revive
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-12 08:20:11 +08:00
John Olheiser
3bf5a07537
Only sync tags after all batches ( #9319 )
...
Signed-off-by: jolheiser <john.olheiser@gmail.com >
2019-12-11 14:09:06 +08:00
Antoine GIRARD
c3d31e5534
refactor(models/attachement): use getAttachmentsByUUIDs ( #9317 )
2019-12-11 00:01:52 +00:00
Lunny Xiao
50da9f7dae
Move modules/indexer to modules/indexer/code ( #9301 )
2019-12-10 14:29:40 +01:00
zeripath
2c83dac5d4
FCGI: Allow FCGI over unix sockets ( #9298 )
...
* FCGI: Allow FCGI over unix sockets
* fixup! FCGI: Allow FCGI over unix sockets
2019-12-10 13:23:26 +01:00
Antoine GIRARD
4dc3993b22
tests: add attachement tests integration ( #9309 )
...
* tests: add attachements integration
* Update integrations/attachement_test.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com >
2019-12-10 19:06:48 +08:00
zeripath
d3a9c4ceec
Testing: Update postgres sequences ( #9304 )
2019-12-10 07:49:05 +00:00
2d8a89563d
Correct port range for cap_net_bind_service ( #9306 )
2019-12-09 14:20:09 -05:00
6543
7f0d7c0a17
File Edit: Author/Committer interchanged [BugFix] ( #9297 )
...
* simple fix
* fix test too
* repair more twists
use same sequence: first Author, then Commiter
2019-12-09 21:11:24 +08:00
techknowlogick
c34fdf7e33
prebuild CSS/JS before xgo release binaries ( #9293 )
...
* prebuild CSS/JS before xgo release binaries
* Update .drone.yml
* Update Makefile
* update per @lafriks feedback
2019-12-08 17:24:17 -05:00
zeripath
baae90e163
Allow incompletely specified Time Formats ( #8816 )
...
* Allow incompletely specified time formats
* Adjust error reporting slightly
* Update setting.go
2019-12-08 16:25:00 -05:00
Lunny Xiao
be06dee04c
Move code indexer related code to a new package ( #9191 )
...
* move code indexer related code to a new package
* fix lint
* fix tests
* fix fmt
* GetMaxID support interface parameter
2019-12-08 14:15:35 -05:00