6543
217d71c48a
Workaround to clean up old reviews on creating a new one ( #28554 )
...
close #28542
blocks #28544
---
*Sponsored by Kithara Software GmbH*
2024-02-19 14:42:18 +01:00
Şahin Akkaya
39a77d92d9
Deduplicate translations for contributors graph ( #29256 )
...
I have implemented three graph pages
([contributors](https://github.com/go-gitea/gitea/pull/27882 ), [code
frequency](https://github.com/go-gitea/gitea/pull/29191 ) and [recent
commits](https://github.com/go-gitea/gitea/pull/29210 )) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.
2024-02-19 12:47:38 +00:00
wxiaoguang
567a68a0bf
Remove DataRaceCheck ( #29258 )
...
Since #26254 , it started using `{{ctx.Locale.Tr ...}}`
Now the `ctx` seems stable enough, so the check could be removed.
2024-02-19 11:25:58 +00:00
Johan Van de Wauw
740c6a226c
Fix c/p error in inline documentation ( #29148 )
...
Fix small copy/paste error in inline documentation
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-02-19 10:51:58 +00:00
KN4CK3R
7e8ff70940
Show commit status for releases ( #29149 )
...
Fixes #29082
2024-02-19 10:27:05 +00:00
Markus Amshove
a11ccc9fcd
Disallow merge when required checked are missing ( #29143 )
...
fixes #21892
This PR disallows merging a PR when not all commit status contexts
configured in the branch protection are met.
Previously, the PR was happy to merge when one commit status was
successful and the other contexts weren't reported.
Any feedback is welcome, first time Go :-)
I'm also not sure if the changes in the template break something else
Given the following branch protection:
This was shown before the change:
With the change, it is now shown as this:
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-02-19 09:57:08 +00:00
Jason Song
0ea8de2d07
Do not use lower tag names to find releases/tags ( #29261 )
...
Fix #26090 , see
https://github.com/go-gitea/gitea/issues/26090#issuecomment-1952013206
Since `TagName` stores the original tag name and `LowerTagName` stores
the lower tag name, it doesn't make sense to use lowercase tags as
`TagNames` in `FindReleasesOptions`.
5e72526da4/services/repository/push.go (L396-L397)5e72526da4/routers/web/repo/repo.go (L416)
2024-02-19 09:31:36 +00:00
silverwind
5e72526da4
Downscale pasted PNG images based on metadata ( #29123 )
...
Some images like MacOS screenshots contain
[pHYs](http://www.libpng.org/pub/png/book/chapter11.html#png.ch11.div.8 )
data which we can use to downscale uploaded images so they render in the
same dppx ratio in which they were taken.
Before:
<img width="584" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/50979e3a-5d5a-40dc-a0a4-36eb6e28f14a ">
After:
<img width="329" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/0690902a-f2fe-4c6b-97b3-6fdd67c21bad ">
2024-02-19 02:23:06 +00:00
GiteaBot
f04e71f9bc
[skip ci] Updated licenses and gitignores
2024-02-19 00:24:35 +00:00
Şahin Akkaya
20f6a7c484
De-duplicate contributor graph translations ( #29247 )
2024-02-18 22:02:07 +01:00
wxiaoguang
8be198cdef
Use general token signing secret ( #29205 )
...
Use a clearly defined "signing secret" for token signing.
2024-02-18 17:39:04 +00:00
Lunny Xiao
c2a8aacae5
Fix missed edit issues event for actions ( #29237 )
...
Fix #29213
2024-02-18 15:16:34 +00:00
silverwind
39f8ab591c
Clean up diff header css and reduce global textarea min-height ( #29232 )
...
1. Tweak diff header and remove a numbe of unneeded CSS for it:
Before:
<img width="433" alt="Screenshot 2024-02-18 at 01 08 09"
src="https://github.com/go-gitea/gitea/assets/115237/d8b377c0-57bc-44d5-bb57-a582c7d4b3b4 ">
After:
<img width="463" alt="Screenshot 2024-02-18 at 01 07 56"
src="https://github.com/go-gitea/gitea/assets/115237/d08c17e7-5b86-4d07-81da-6371f4754325 ">
3. Reduce height of review textarea and also reduce fomantic's CSS from
12em to 8em. Now fits better on my screen:
<img width="1352" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/5c658d13-295e-4929-94da-13ade888020d ">
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-02-18 14:51:21 +00:00
FuXiaoHei
68e1d17a5f
Expire artifacts before deleting them physically ( #29241 )
...
https://github.com/go-gitea/gitea/pull/27172#discussion_r1493735466
When cleanup artifacts, it removes storage first. If storage is not
exist (maybe delete manually), it gets error and continue loop. It makes
a dead loop if there are a lot pending but non-existing artifacts.
Now it updates db record at first to avoid keep a lot of pending status
artifacts.
2024-02-18 22:25:14 +08:00
wxiaoguang
4345cac529
Improve TrHTML and add more tests ( #29228 )
...
Follow #29165 .
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2024-02-18 12:15:24 +00:00
Tim-Nicas Oelschläger
6093f507fe
Convert visibility to number ( #29226 )
...
Don't throw error while creating user (Fixes #29218 )
2024-02-18 11:47:50 +00:00
yp05327
1a6e1cbada
Implement some action notifier functions ( #29173 )
...
Fix #29166
Add support for the following activity types of `pull_request`
- assigned
- unassigned
- review_requested
- review_request_removed
- milestoned
- demilestoned
2024-02-18 10:58:46 +00:00
FuXiaoHei
67adc5c1dc
Artifact deletion in actions ui ( #27172 )
...
Add deletion link in runs view page.
Fix #26315
When click deletion button. It marks this artifact `need-delete`.
This artifact would be deleted when actions cleanup cron task.
2024-02-18 10:33:50 +00:00
zhangnew
7430eb9e7f
Update docs for actions variables ( #29239 )
...
the variables is supported, see
a784ed3d6c/docs/content/usage/actions/act-runner.zh-cn.md (L262-L289)
2024-02-18 18:04:58 +08:00
wxiaoguang
31bb9f3247
Refactor more code in templates ( #29236 )
...
Follow #29165 .
* Introduce JSONTemplate to help to render JSON templates
* Introduce JSEscapeSafe for templates. Now only use `{{ ... |
JSEscape}}` instead of `{{ ... | JSEscape | Safe}}`
* Simplify "UserLocationMapURL" useage
2024-02-18 10:52:02 +01:00
wxiaoguang
a784ed3d6c
Use "Safe" modifier for manually constructed safe HTML strings in templates ( #29227 )
...
Follow #29165 . These HTML strings are safe to be rendered directly, to
avoid double-escaping.
2024-02-18 01:48:59 +00:00
Yarden Shoham
d73223bfc6
Remove jQuery from the repo release form ( #29225 )
...
- Switched to plain JavaScript
- Tested the repo release form functionality and it works as before
# Demo using JavaScript without jQuery
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-02-18 09:22:09 +08:00
wxiaoguang
658cbddbfb
Make submit event code work with both jQuery event and native event ( #29223 )
...
Partially related to #29200 and fix other potential bugs.
Co-authored-by: Giteabot <teabot@gitea.io>
2024-02-17 21:48:10 +01:00
Yarden Shoham
5e1bf3efe2
Remove jQuery from repo migrate page ( #29219 )
...
- Switched to plain JavaScript
- Tested the repo migrate functionality and it works as before
# Demo using JavaScript without jQuery
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-02-17 21:07:47 +01:00
Yarden Shoham
3da2c63354
Remove unneccesary initUserAuthLinkAccountView from "link account" page ( #29217 )
...
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-02-17 18:51:35 +01:00
Yarden Shoham
1d275c1748
Fix labels referencing the wrong ID in the user profile settings ( #29199 )
...
2 instances of `for` with a wrong value and 1 `for` that had a reference
to a `name` instead of `id`.
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-17 15:01:25 +00:00
Yarden Shoham
0157db84b1
Fix label for pointing to a name instead of id in webhook settings ( #29209 )
...
Here's the spec for the `for` attribute:
https://html.spec.whatwg.org/multipage/forms.html#attr-label-for
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-17 14:32:43 +00:00
Jimmy Praet
22b9c2c95c
Load outdated comments when (un)resolving conversation on PR timeline ( #29203 )
...
Relates to #28654 , #29039 and #29050 .
The "show outdated comments" flag should only apply to the file diff
view.
On the PR timeline, outdated comments are always shown.
So they should also be loaded when (un)resolving a conversation on the
timeline page.
2024-02-17 14:07:56 +00:00
Yarden Shoham
aa6f88638f
Fix missing template for follow button in organization ( #29215 )
...
Leftover from https://github.com/go-gitea/gitea/pull/29005
# Before
# After
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-17 13:42:52 +00:00
silverwind
b96fbb567c
Enable markdownlint no-trailing-punctuation and no-blanks-blockquote ( #29214 )
...
Enable these two and fix issues.
2024-02-17 13:18:05 +00:00
Yarden Shoham
27192bc321
Remove jQuery from the webhook editor ( #29211 )
...
- Switched to plain JavaScript
- Tested the webhook editing functionality and it works as before
# Demo using JavaScript without jQuery
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-02-17 13:17:04 +00:00
Yarden Shoham
c282d378bd
Remove jQuery from issue reference context popup attach ( #29216 )
...
- Switched to plain JavaScript
- Tested the context popup functionality and it works as before
# Demo using JavaScript without jQuery
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-17 21:11:56 +08:00
xkcdstickfigure
cb85ebc3ef
fix typo ( #29212 )
2024-02-17 12:01:54 +01:00
Robin Schoonover
33400a02d4
Fix debian InRelease Acquire-By-Hash newline ( #29204 )
...
There is a missing newline when generating the debian apt repo InRelease
file, which results in output like:
```
[...]
Date: Wed, 14 Feb 2024 05:03:01 UTC
Acquire-By-Hash: yesMD5Sum:
51a518dbddcd569ac3e0cebf330c800a 3018 main-dev/binary-amd64/Packages
[...]
```
It appears this would probably result in apt ignoring the
Acquire-By-Hash setting and not using the by-hash functionality,
although I'm not sure how to confirm it.
2024-02-17 05:40:13 +00:00
yp05327
68227996a7
Fix broken following organization ( #29005 )
...
- following organization is broken from #28908
- add login check for the follow button in organization profile page
2024-02-17 13:13:37 +08:00
GiteaBot
e936d2b338
[skip ci] Updated translations via Crowdin
2024-02-17 00:23:24 +00:00
silverwind
26b17537e6
Add eslint-plugin-github and fix issues ( #29201 )
...
This plugin has a few useful rules. The only thing I dislike about it is
that it pulls in a rather big number of dependencies for react-related
rules we don't use, but it can't really be avoided.
Rule docs:
https://github.com/github/eslint-plugin-github?tab=readme-ov-file#rules
2024-02-16 21:41:23 +00:00
Yarden Shoham
d8d4b33b31
Remove jQuery from the "quick submit" handler ( #29200 )
...
- Switched to plain JavaScript
- Tested the quick submit functionality and it works as before
# Demo using JavaScript without jQuery
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-16 21:03:50 +01:00
Yarden Shoham
2d8756a960
Fix initCompLabelEdit not being called ( #29198 )
...
Fix broken `if` from https://github.com/go-gitea/gitea/pull/29195
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-16 17:03:52 +01:00
Yarden Shoham
0768842ef5
Remove jQuery from username change prompt and fix its detection ( #29197 )
...
- Switched to plain JavaScript
- Tested the user rename prompt toggling functionality and it works as
before
- Fixed bug that allowed pasting with the mouse to avoid the prompt
# Before
# After
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-02-16 15:52:50 +00:00
Yarden Shoham
5902372e63
Remove jQuery from organization rename prompt toggle ( #29195 )
...
- Switched to plain JavaScript
- Tested the organization rename prompt toggling functionality and it
works as before
# Demo using JavaScript without jQuery
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-02-16 16:48:01 +01:00
wxiaoguang
45c15387b2
Refactor JWT secret generating & decoding code ( #29172 )
...
Old code is not consistent for generating & decoding the JWT secrets.
Now, the callers only need to use 2 consistent functions:
NewJwtSecretWithBase64 and DecodeJwtSecretBase64
And remove a non-common function Base64FixedDecode from util.go
2024-02-16 15:18:30 +00:00
Yarden Shoham
7132a0ba75
Reference labels by IDs instead of names in keys settings ( #29194 )
...
Here's the spec for the `for` attribute:
https://html.spec.whatwg.org/multipage/forms.html#attr-label-for
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
2024-02-16 13:59:48 +00:00
Yarden Shoham
236e121844
Remove jQuery from SSH key form parser ( #29193 )
...
- Switched to plain JavaScript
- Tested the SSH key title functionality and it works as before
# Demo using JavaScript without jQuery
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-02-16 13:34:29 +00:00
silverwind
c40ee6fb73
Refactor request function ( #29187 )
...
- Remove and prevent use of `body` argument, it is not used anywhere
- Remove uppercasing of method, we can require it to be uppercase
2024-02-16 13:27:00 +00:00
wienans
f2d5c6edde
Docker Tag Information in Docs ( #29047 )
...
Add more details for the docker tag when using container registry.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
2024-02-16 21:22:00 +08:00
yp05327
8e2831611c
Fix gitea-action user avatar broken on edited menu ( #29190 )
...
Fix #29178
2024-02-16 09:50:20 +00:00
silverwind
69ed1a4afb
Disable parallel Make execution ( #29186 )
...
Ref:
https://www.gnu.org/software/make/manual/html_node/Parallel-Disable.html
> If the .NOTPARALLEL special target with no prerequisites is specified
anywhere then the entire instance of make will be run serially,
regardless of the parallel setting
2024-02-16 03:17:34 +00:00
Yarden Shoham
c70f65e83b
Auto-update the system status in admin dashboard ( #29163 )
...
- Refactor the system status list into its own template
- Change the backend to return only the system status if htmx initiated
the request
- `hx-get="{{$.Link}}/system_status`: reuse the backend handler
- `hx-swap="innerHTML"`: replace the `<div>`'s innerHTML (essentially
the new template)
- `hx-trigger="every 5s"`: call every 5 seconds
- `hx-indicator=".divider"`: the `is-loading` class shouldn't be added
to the div during the request, so set it on an element it has no effect
on
- Render "Since Last GC Time" with `<relative-time>`, so we send a
timestamp
# Auto-update in action GIF
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: silverwind <me@silverwind.io>
2024-02-16 02:52:25 +00:00
silverwind
e9a1ffba2c
Avoid vue warning in dev mode ( #29188 )
...
`vue` currently outputs a warning for this undefined variable during
development, which is apparently caused by a bug in `vue-cli`.
Workaround by setting this variable.
Ref: https://github.com/vuejs/vue-cli/pull/7443
Ref: https://stackoverflow.com/a/77765007/808699
2024-02-16 02:27:45 +00:00
