Lunny Xiao
344c89ea34
Fix bug automerge cannot be chosed when there is only 1 merge style ( #33040 )
...
This is a quick bug fix. Even if there is only 1 merge style, the
dropdown menu will still be displayed to allow users to choose
auto-merge.
Fix #32448
2024-12-30 03:04:22 +00:00
techknowlogick
232867cff6
use -s -w
ldflags for release artifacts ( #33041 )
...
fix #33030
2024-12-30 02:37:59 +00:00
wxiaoguang
cd1b5488a3
Refactor pagination ( #33037 )
...
I am sure the simple approach should work, let's try it in 1.24
Follow #29834 and #29841
2024-12-30 01:57:38 +00:00
wxiaoguang
1dbf0d7f08
Test webhook email ( #33033 )
...
Close #27918
2024-12-30 01:25:49 +08:00
Henry Goodman
a96776b3cb
Fix review code comment avatar alignment ( #33031 )
...
Fixes #33017
Avatar should only have offset if the `Comment` has `Content` or
`Attachment` to align with the speech bubble.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-29 11:04:13 +00:00
TheFox0x7
ff96873e3e
Fix templating in pull request comparison ( #33025 )
...
Adds test for expected behavior
Closes: https://github.com/go-gitea/gitea/issues/33013
2024-12-29 01:32:19 +00:00
wxiaoguang
0ed160ffea
Refactor tests ( #33021 )
...
1. fix incorrect tests, for example: BeanExists doesn't do assert and
shouldn't be used
2. remove unnecessary test functions
3. introduce DumpQueryResult to help to see the database rows during
test (at least I need it)
```
====== DumpQueryResult: SELECT * FROM action_runner_token ======
- # row[0]
id: 1
token: xeiWBL5kuTYxGPynHCqQdoeYmJAeG3IzGXCYTrDX
owner_id: 0
...
```
2024-12-29 01:05:56 +00:00
GiteaBot
e95b946f6d
[skip ci] Updated translations via Crowdin
2024-12-29 00:36:47 +00:00
metiftikci
64bebc9402
always show assignees on right ( #33006 )
...
### Before
![old_issue_list](https://github.com/user-attachments/assets/c7a6631d-9330-4e29-9e01-c1bcb2a0387f )
### After
![new_issue_list](https://github.com/user-attachments/assets/5a13c413-b58e-40bb-888b-9edfe3c94e0c )
2024-12-29 00:30:06 +00:00
metiftikci
94048f3035
fix toggle commit body button ui when latest commit message is long ( #32997 )
...
#### Before
![before](https://github.com/user-attachments/assets/fe36bdb3-10e8-4fe7-9106-0897f49bedb3 )
#### After
![after](https://github.com/user-attachments/assets/745bd164-5f25-41ca-b340-36cb695551db )
## Edit:
I found an issue on mobile view and changed the code as using flex gap
![small](https://github.com/user-attachments/assets/dd7c2093-6860-4800-a2bc-676a03e764c8 )
![large](https://github.com/user-attachments/assets/5c933779-8281-4d48-9fd0-4d7b245bf4ac )
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-29 08:04:56 +08:00
wxiaoguang
a92f5057ae
Fix and/or comment some legacy CSS problems ( #33015 )
2024-12-28 11:51:38 +00:00
wxiaoguang
3d3ece36d2
Refactor comment history and fix content edit ( #33018 )
...
And fix a regression bug for comment content editing.
Now 11 "import jquery" files left
2024-12-28 19:26:16 +08:00
Lunny Xiao
e69da2cd07
Fix bug on activities ( #33008 )
...
A repository with no issue will display a random number on activities
page. This is caused by wrong usage of `And` and `Or`.
![9cdbbf81d50aa5d9bd16604e0dab5eb0](https://github.com/user-attachments/assets/828cebdc-bd35-4716-a58c-c1b43ddf8bf0 )
2024-12-28 04:04:07 +00:00
wxiaoguang
e435b1900a
Refactor arch route handlers ( #32993 )
2024-12-28 03:31:46 +00:00
metiftikci
254314be5f
fix scoped label ui when contains emoji ( #33007 )
...
### Before
![old_label](https://github.com/user-attachments/assets/2211f711-613a-4ed4-90fd-8ff6ab0700f5 )
### After
![new_label](https://github.com/user-attachments/assets/ecbc89da-7f77-44d0-8ce9-ba51b67421e5 )
2024-12-28 00:58:19 +00:00
GiteaBot
14ed553fae
[skip ci] Updated translations via Crowdin
2024-12-28 00:30:57 +00:00
Blender Defender
079a1ffe8f
De-emphasize signed commits ( #31160 )
...
The new code structure is easier to make more improvements or
refactor, for example: change the colors to de-emphasize more, or design
some new layouts.
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-28 04:18:30 +08:00
wxiaoguang
ea198f9ea8
Fix eslint ( #33002 )
...
Fix #32982
Related #32869
* eslint-plugin-github 5.1.x doesn't work well with eslint8
* no-undef is still needed
2024-12-27 19:34:39 +00:00
a1012112796
a7b2707be9
Fix Agit pull request permission check ( #32999 )
...
user with read permission should also can create agit flow pull request.
looks this logic was broken in
https://github.com/go-gitea/gitea/pull/31033 this pull request try fix
it and add test code.
---------
Signed-off-by: a1012112796 <1012112796@qq.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-27 18:17:01 +00:00
Zettat123
2d1a171dc7
Support for email addresses containing uppercase characters when activating user account ( #32998 )
...
Fix #32807
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-27 19:16:23 +08:00
GiteaBot
3c00e89129
[skip ci] Updated translations via Crowdin
2024-12-27 00:32:06 +00:00
Zettat123
df98452c0d
Improve Actions test ( #32883 )
...
This PR adds a mock runner to test more actions features.
2024-12-26 22:10:30 +00:00
Zettat123
44b4fb21a4
Support org labels when adding labels by label names ( #32988 )
...
Fix #32891
2024-12-26 19:14:49 +00:00
yp05327
7bb7ba1b5b
Add show more
organizations icon in user's profile ( #32986 )
...
Close #32952
# ⚠️ Doc update is required
![image](https://github.com/user-attachments/assets/296c5109-8fc1-43ea-b7dc-e79919cc1f9a )
![image](https://github.com/user-attachments/assets/d30980f6-22e4-4b97-9143-c750dc399da6 )
------
⚠️ This PR refuses to be cherry-picked by any forked projects without any
mentions.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-27 02:49:50 +08:00
wxiaoguang
550abdbc24
Improve "ellipsis string" ( #32989 )
2024-12-26 14:19:35 +08:00
wxiaoguang
9bfa9f450d
Refactor "string truncate" ( #32984 )
2024-12-26 11:56:03 +08:00
wxiaoguang
594edad213
Do not render truncated links in markdown ( #32980 )
...
Fixes #31780
2024-12-26 00:33:55 +08:00
Lunny Xiao
5feb1a6bff
Use CloseIssue
and ReopenIssue
instead of ChangeStatus
( #32467 )
...
The behaviors of closing issues and reopening issues are very different.
So splitting it into two different functions makes it easier to
maintain.
- [x] Split ChangeIssueStatus into CloseIssue and ReopenIssue both at
the service layer and model layer
- [x] Rename `isClosed` to `CloseOrReopen` to make it more readable.
- [x] Add transactions for ReopenIssue and CloseIssue
---------
Co-authored-by: Zettat123 <zettat123@gmail.com>
2024-12-25 07:38:30 +00:00
Lunny Xiao
f44712f22b
demilestone should not include milestone ( #32923 )
...
Fix #32887
2024-12-25 05:52:46 +00:00
metiftikci
1a7591d7f9
fix textarea newline handle ( #32966 )
...
- Fix cursor position if input newline on middle of lines
- ~Increment number if numbered list~
![image](https://github.com/user-attachments/assets/bcfe2625-11a8-4ea4-9a71-b7ecfe81b2e0 )
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-25 13:03:43 +08:00
Zettat123
abaeae0b9c
Fix Azure blob object Seek
( #32974 )
...
This bug was found in a
[test](https://github.com/go-gitea/gitea/actions/runs/12464294025/job/34788152194?pr=32883#step:9:105 )
of #32883
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-25 04:54:52 +00:00
wxiaoguang
973363fec3
Fix maven pom inheritance ( #32943 )
...
Fix #30568
2024-12-25 04:28:37 +00:00
wxiaoguang
ca31d478ee
Refactor arch route handlers ( #32972 )
2024-12-25 04:03:14 +00:00
GiteaBot
65e45fdcfd
[skip ci] Updated translations via Crowdin
2024-12-25 00:31:17 +00:00
wxiaoguang
b7260400f8
Refactor tmpl and blob_excerpt ( #32967 )
...
1. do not use `{{/* */}}` to remove spaces, use `{{- -}}`
2. fix "blob_excerpt" endpoint, remove the legacy fragile code: have
tested commit diff and wiki diff
2024-12-25 00:51:13 +08:00
wxiaoguang
2a828e2798
Clarify path param naming ( #32969 )
...
In history (from some legacy frameworks), both `:name` and `name` are
supported as path path name, `:name` is an alias to `name`.
To make code consistent, now we should only use `name` but not `:name`.
Also added panic check in related functions to make sure the name won't
be abused in case some downstreams still use them.
2024-12-24 13:47:45 +00:00
Lunny Xiao
b8b690feb9
Refactor getpatch/getdiff functions and remove unnecessary fallback ( #32817 )
...
Extract from #32786
`git diff a..b` is equal to `git diff a b` which is different from `git
diff a...b`. For pull request, we should always
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-24 14:29:34 +08:00
wxiaoguang
6d5aa9218e
Refactor request context ( #32956 )
...
Introduce RequestContext: is a short-lived context that is used to store
request-specific data.
RequestContext could be used to clean form tmp files, close context git
repo, and do some tracing in the future.
Then a lot of legacy code could be removed or improved. For example:
most `ctx.Repo.GitRepo.Close()` could be removed because the git repo
could be closed when the request is done.
2024-12-24 11:43:57 +08:00
wxiaoguang
781c6df40f
Add sub issue list support ( #32940 )
...
Just like GitHub, show issue icon/title when the issue number is in a list
2024-12-24 01:54:19 +00:00
GiteaBot
02c64e48b7
[skip ci] Updated translations via Crowdin
2024-12-24 00:31:53 +00:00
wxiaoguang
7553ae1a57
Use env GITEA_RUNNER_REGISTRATION_TOKEN as global runner token ( #32946 )
...
Fix #23703
When Gitea starts, it reads GITEA_RUNNER_REGISTRATION_TOKEN
or GITEA_RUNNER_REGISTRATION_TOKEN_FILE to add registration token.
2024-12-23 09:59:16 +00:00
wxiaoguang
bd5d1341d4
Fix commit range paging ( #32944 )
2024-12-23 07:07:12 +00:00
wxiaoguang
89f31f79fd
Fix outdated tmpl code ( #32953 )
...
Some PRs were before tmpl ctx refactoring and used outdated code
2024-12-23 11:21:11 +08:00
wxiaoguang
462ce31530
Fix repo avatar conflict ( #32958 )
...
Continue even if the avatar deleting fails
2024-12-23 02:52:25 +00:00
GiteaBot
b5f9a2d7c0
[skip ci] Updated licenses and gitignores
2024-12-23 00:32:58 +00:00
katsu
fb75151fb1
fix trailing comma not matched in the case of alphanumeric issue ( #32945 )
...
Fix #32428 .
Patch the regex to match `,`besides `.` `"` `'` `:` and space.
2024-12-22 21:32:28 +00:00
bytedream
6279646ee4
Add auto-expanding running actions step ( #30058 )
...
Auto-expands the currently running action step.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-12-22 18:57:17 +00:00
Illya Marchenko
daf2776db7
Fix #32954 ( #32955 )
...
`/bin/s6-svscan` is actuall located at `/usr/bin/s6-svscan`
2024-12-23 02:31:53 +08:00
techknowlogick
a09ea2f483
Use Alpine 3.21 for the docker images ( #32924 )
2024-12-22 15:44:50 +00:00
wxiaoguang
a163c53a60
Refactor template & test related code ( #32938 )
...
Move some legacy code from "base" package to proper packages.
2024-12-22 15:33:19 +00:00