1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 00:54:28 +00:00
gitea/routers/web
Zettat123 0690cb076b
Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365)
Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

348d1d0f32/routers/api/packages/container/container.go (L712-L717)
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

b7fb20e73e/modules/storage/minio.go (L214-L221)
2024-10-31 15:28:25 +00:00
..
admin Move admin routers from /admin to /-/admin (#32189) 2024-10-10 04:56:49 +00:00
auth Refactor CSRF token (#32216) 2024-10-10 03:48:21 +00:00
devtest Refactor names (#31405) 2024-06-19 06:32:45 +08:00
events Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
explore Respect UI.ExploreDefaultSort setting again (#32357) 2024-10-30 12:33:25 +00:00
feed Use GetDisplayName() instead of DisplayName() to generate rss feeds (#31687) 2024-07-25 17:33:02 +08:00
healthcheck Always enable caches (#28527) 2023-12-19 09:29:05 +00:00
misc Make sure git version&feature are always prepared (#30877) 2024-05-06 18:34:16 +02:00
org Add option to filter board cards by labels and assignees (#31999) 2024-09-12 03:53:40 +00:00
repo Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-10-31 15:28:25 +00:00
shared Add option to filter board cards by labels and assignees (#31999) 2024-09-12 03:53:40 +00:00
user Fix disable 2fa bug (#32320) 2024-10-23 06:41:00 +00:00
base.go Fix missing signature key error when pulling Docker images with SERVE_DIRECT enabled (#32365) 2024-10-31 15:28:25 +00:00
githttp.go Refactor names (#31405) 2024-06-19 06:32:45 +08:00
goget.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
home.go migrate some more "OptionalBool" to "Option[bool]" (#29479) 2024-02-29 18:52:49 +00:00
metrics.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
nodeinfo.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
passkey.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
swagger_json.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00
web.go Suggestions for issues (#32327) 2024-10-29 17:20:49 +08:00
webfinger.go Move context from modules to services (#29440) 2024-02-27 08:12:22 +01:00