mirror of
https://github.com/go-gitea/gitea
synced 2025-10-31 11:28:24 +00:00
b18c047d62
Upgrade to [v0.19.0](https://github.com/golang/tools/releases/tag/gopls%2Fv0.19.0) and fix issues. Runs with new `warning` serverity setting. This likely does less checks than before. Additionally, add `make fix` which runs modernize. This is also verified on CI. For the record, here are the issues discoverd when running with `info` severity, in case we want to fix these: ``` tests/integration/repo_test.go:95:5-14: could use tagged switch on i tests/integration/api_packages_generic_test.go:149:4-64: could use tagged switch on setting.Packages.Storage.Type services/webhook/msteams_test.go:33:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:59:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:85:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:111:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:138:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:161:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:187:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:213:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:239:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:266:4-33: could use tagged switch on fact.Name services/webhook/msteams_test.go:407:4-33: could use tagged switch on fact.Name tests/integration/api_packages_conan_test.go:350:6-33: could use tagged switch on pf.Name models/issues/tracked_time_test.go:98:3-18: could use tagged switch on user.ID tests/integration/api_token_test.go:505:5-43: could use tagged switch on minRequiredLevel services/gitdiff/gitdiff.go:220:33-46: method "getLineLegacy" is unused ``` --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
24 lines
742 B
Bash
Executable File
24 lines
742 B
Bash
Executable File
#!/bin/bash
|
|
set -uo pipefail
|
|
|
|
cd "$(dirname -- "${BASH_SOURCE[0]}")" && cd ..
|
|
|
|
IGNORE_PATTERNS=(
|
|
"is deprecated" # TODO: fix these
|
|
)
|
|
|
|
# lint all go files with 'gopls check' and look for lines starting with the
|
|
# current absolute path, indicating a error was found. This is necessary
|
|
# because the tool does not set non-zero exit code when errors are found.
|
|
# ref: https://github.com/golang/go/issues/67078
|
|
ERROR_LINES=$("$GO" run "$GOPLS_PACKAGE" check -severity=warning "$@" 2>/dev/null | grep -E "^$PWD" | grep -vFf <(printf '%s\n' "${IGNORE_PATTERNS[@]}"));
|
|
NUM_ERRORS=$(echo -n "$ERROR_LINES" | wc -l)
|
|
|
|
if [ "$NUM_ERRORS" -eq "0" ]; then
|
|
exit 0;
|
|
else
|
|
echo "$ERROR_LINES"
|
|
echo "Found $NUM_ERRORS 'gopls check' errors"
|
|
exit 1;
|
|
fi
|