mirror of
https://github.com/go-gitea/gitea
synced 2024-06-17 08:45:48 +00:00
c1f76aea45
In Wiki pages, short-links created to local Wiki files were always expanded as regular Wiki Links. In particular, if a link wanted to point to a file that Gitea doesn't know how to render (e.g, a .zip file), a user following the link would be silently redirected to the Wiki's home page. This change makes short-links* in Wiki pages be expanded to raw wiki links, so these local wiki files may be accessed without manually accessing their URL. * only short-links ending in a file extension that isn't renderable are affected. Closes #27121. Signed-off-by: Rafael Girão <rafael.s.girao@tecnico.ulisboa.pt> Co-authored-by: silverwind <me@silverwind.io>
43 lines
1.2 KiB
Go
43 lines
1.2 KiB
Go
// Copyright 2024 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package markdown
|
|
|
|
import (
|
|
"path/filepath"
|
|
|
|
"code.gitea.io/gitea/modules/markup"
|
|
giteautil "code.gitea.io/gitea/modules/util"
|
|
|
|
"github.com/yuin/goldmark/ast"
|
|
"github.com/yuin/goldmark/text"
|
|
)
|
|
|
|
func (g *ASTTransformer) transformLink(ctx *markup.RenderContext, v *ast.Link, reader text.Reader) {
|
|
// Links need their href to munged to be a real value
|
|
link := v.Destination
|
|
isAnchorFragment := len(link) > 0 && link[0] == '#'
|
|
if !isAnchorFragment && !markup.IsFullURLBytes(link) {
|
|
base := ctx.Links.Base
|
|
if ctx.IsWiki {
|
|
if filepath.Ext(string(link)) == "" {
|
|
// This link doesn't have a file extension - assume a regular wiki link
|
|
base = ctx.Links.WikiLink()
|
|
} else if markup.Type(string(link)) != "" {
|
|
// If it's a file type we can render, use a regular wiki link
|
|
base = ctx.Links.WikiLink()
|
|
} else {
|
|
// Otherwise, use a raw link instead
|
|
base = ctx.Links.WikiRawLink()
|
|
}
|
|
} else if ctx.Links.HasBranchInfo() {
|
|
base = ctx.Links.SrcLink()
|
|
}
|
|
link = []byte(giteautil.URLJoin(base, string(link)))
|
|
}
|
|
if isAnchorFragment {
|
|
link = []byte("#user-content-" + string(link)[1:])
|
|
}
|
|
v.Destination = link
|
|
}
|