mirror of
https://github.com/go-gitea/gitea
synced 2025-07-03 17:17:19 +00:00
0e629c545a
This PR fixes a state de-synchronization bug with the issue stopwatch, it resolves the issue by replacing the ambiguous `/toggle` endpoint with two explicit endpoints: `/start` and `/stop`. - The "Start timer" button now exclusively calls the `/start` endpoint. - The "Stop timer" button now exclusively calls the `/stop` endpoint. This ensures the user's intent is clearly communicated to the server, eliminating the state inconsistency and fixing the bug. --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
88 lines
3.4 KiB
Go
88 lines
3.4 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issues_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCancelStopwatch(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
issue1 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
|
|
ok, err := issues_model.CancelStopwatch(db.DefaultContext, user1, issue1)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ok)
|
|
unittest.AssertNotExistsBean(t, &issues_model.Stopwatch{UserID: user1.ID, IssueID: issue1.ID})
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{Type: issues_model.CommentTypeCancelTracking, PosterID: user1.ID, IssueID: issue1.ID})
|
|
|
|
ok, err = issues_model.CancelStopwatch(db.DefaultContext, user1, issue1)
|
|
assert.NoError(t, err)
|
|
assert.False(t, ok)
|
|
}
|
|
|
|
func TestStopwatchExists(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
assert.True(t, issues_model.StopwatchExists(db.DefaultContext, 1, 1))
|
|
assert.False(t, issues_model.StopwatchExists(db.DefaultContext, 1, 2))
|
|
}
|
|
|
|
func TestHasUserStopwatch(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
exists, sw, _, err := issues_model.HasUserStopwatch(db.DefaultContext, 1)
|
|
assert.NoError(t, err)
|
|
assert.True(t, exists)
|
|
assert.Equal(t, int64(1), sw.ID)
|
|
|
|
exists, _, _, err = issues_model.HasUserStopwatch(db.DefaultContext, 3)
|
|
assert.NoError(t, err)
|
|
assert.False(t, exists)
|
|
}
|
|
|
|
func TestCreateOrStopIssueStopwatch(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
user4 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 4})
|
|
issue1 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
|
|
issue3 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 3})
|
|
|
|
// create a new stopwatch
|
|
ok, err := issues_model.CreateIssueStopwatch(db.DefaultContext, user4, issue1)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ok)
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Stopwatch{UserID: user4.ID, IssueID: issue1.ID})
|
|
// should not create a second stopwatch for the same issue
|
|
ok, err = issues_model.CreateIssueStopwatch(db.DefaultContext, user4, issue1)
|
|
assert.NoError(t, err)
|
|
assert.False(t, ok)
|
|
// on a different issue, it will finish the existing stopwatch and create a new one
|
|
ok, err = issues_model.CreateIssueStopwatch(db.DefaultContext, user4, issue3)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ok)
|
|
unittest.AssertNotExistsBean(t, &issues_model.Stopwatch{UserID: user4.ID, IssueID: issue1.ID})
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.Stopwatch{UserID: user4.ID, IssueID: issue3.ID})
|
|
|
|
// user2 already has a stopwatch in test fixture
|
|
user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
|
|
issue2 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
|
|
ok, err = issues_model.FinishIssueStopwatch(db.DefaultContext, user2, issue2)
|
|
assert.NoError(t, err)
|
|
assert.True(t, ok)
|
|
unittest.AssertNotExistsBean(t, &issues_model.Stopwatch{UserID: user2.ID, IssueID: issue2.ID})
|
|
unittest.AssertExistsAndLoadBean(t, &issues_model.TrackedTime{UserID: user2.ID, IssueID: issue2.ID})
|
|
ok, err = issues_model.FinishIssueStopwatch(db.DefaultContext, user2, issue2)
|
|
assert.NoError(t, err)
|
|
assert.False(t, ok)
|
|
}
|