mirror of
https://github.com/go-gitea/gitea
synced 2025-07-03 17:17:19 +00:00
0e629c545a
This PR fixes a state de-synchronization bug with the issue stopwatch, it resolves the issue by replacing the ambiguous `/toggle` endpoint with two explicit endpoints: `/start` and `/stop`. - The "Start timer" button now exclusively calls the `/start` endpoint. - The "Stop timer" button now exclusively calls the `/stop` endpoint. This ensures the user's intent is clearly communicated to the server, eliminating the state inconsistency and fixing the bug. --------- Signed-off-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
83 lines
2.5 KiB
Go
83 lines
2.5 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"path"
|
|
"testing"
|
|
"time"
|
|
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestViewTimetrackingControls(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
t.Run("Exist", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
session := loginUser(t, "user2")
|
|
testViewTimetrackingControls(t, session, "user2", "repo1", "1", true)
|
|
})
|
|
|
|
t.Run("Non-exist", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
session := loginUser(t, "user5")
|
|
testViewTimetrackingControls(t, session, "user2", "repo1", "1", false)
|
|
})
|
|
|
|
t.Run("Disabled", func(t *testing.T) {
|
|
defer tests.PrintCurrentTest(t)()
|
|
session := loginUser(t, "user2")
|
|
testViewTimetrackingControls(t, session, "org3", "repo3", "1", false)
|
|
})
|
|
}
|
|
|
|
func testViewTimetrackingControls(t *testing.T, session *TestSession, user, repo, issue string, canTrackTime bool) {
|
|
req := NewRequest(t, "GET", path.Join(user, repo, "issues", issue))
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
|
|
AssertHTMLElement(t, htmlDoc, ".issue-start-time", canTrackTime)
|
|
AssertHTMLElement(t, htmlDoc, ".issue-add-time", canTrackTime)
|
|
|
|
issueLink := path.Join(user, repo, "issues", issue)
|
|
reqStart := NewRequestWithValues(t, "POST", path.Join(issueLink, "times", "stopwatch", "start"), map[string]string{
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
})
|
|
if canTrackTime {
|
|
session.MakeRequest(t, reqStart, http.StatusOK)
|
|
|
|
req = NewRequest(t, "GET", issueLink)
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
htmlDoc = NewHTMLParser(t, resp.Body)
|
|
|
|
events := htmlDoc.doc.Find(".event > span.text")
|
|
assert.Contains(t, events.Last().Text(), "started working")
|
|
|
|
AssertHTMLElement(t, htmlDoc, ".issue-stop-time", true)
|
|
AssertHTMLElement(t, htmlDoc, ".issue-cancel-time", true)
|
|
|
|
// Sleep for 1 second to not get wrong order for stopping timer
|
|
time.Sleep(time.Second)
|
|
|
|
reqStop := NewRequestWithValues(t, "POST", path.Join(issueLink, "times", "stopwatch", "stop"), map[string]string{
|
|
"_csrf": htmlDoc.GetCSRF(),
|
|
})
|
|
session.MakeRequest(t, reqStop, http.StatusOK)
|
|
|
|
req = NewRequest(t, "GET", issueLink)
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
htmlDoc = NewHTMLParser(t, resp.Body)
|
|
|
|
events = htmlDoc.doc.Find(".event > span.text")
|
|
assert.Contains(t, events.Last().Text(), "worked for ")
|
|
} else {
|
|
session.MakeRequest(t, reqStart, http.StatusNotFound)
|
|
}
|
|
}
|