gitea

mirror of https://github.com/go-gitea/gitea synced 2024-12-25 01:54:26 +00:00

History

KN4CK3R 1fbdf96c34 Fix CSV render error (#17406 ) (#17431 ) Backport #17406. Closes #17378 Both errors from #17378 were caused by #15175. Problem 1 (error with added file): `ToUTF8WithFallbackReader` creates a `MultiReader` from a `byte[2048]` and the remaining reader. `CreateReaderAndGuessDelimiter` tries to read 10000 bytes from this reader but only gets 2048 because that's the first reader in the `MultiReader`. Then the `if size < 1e4` thinks the input is at EOF and just returns that. Problem 2 (error with changed file): The blob reader gets defer closed. That was fine because the old version reads the whole file into memory. Now with the streaming version the close needs to defer after the method. Co-authored-by: zeripath <art27@cantab.net>	2021-10-25 18:31:15 +01:00
..
csv_test.go	Refactor renders (#15175 )	2021-04-19 18:25:08 -04:00
csv.go	Fix CSV render error (#17406 ) (#17431 )	2021-10-25 18:31:15 +01:00

Fix CSV render error (#17406 ) (#17431 )

Backport #17406.

Closes #17378 

Both errors from #17378 were caused by  #15175.

Problem 1 (error with added file):
`ToUTF8WithFallbackReader` creates a `MultiReader` from a `byte[2048]` and the remaining reader. `CreateReaderAndGuessDelimiter` tries to read 10000 bytes from this reader but only gets 2048 because that's the first reader in the `MultiReader`. Then the `if size < 1e4` thinks the input is at EOF and just returns that.

Problem 2 (error with changed file):
The blob reader gets defer closed. That was fine because the old version reads the whole file into memory. Now with the streaming version the close needs to defer after the method.

Co-authored-by: zeripath <art27@cantab.net>

2021-10-25 18:31:15 +01:00

csv_test.go

Refactor renders (#15175 )

2021-04-19 18:25:08 -04:00

csv.go

Fix CSV render error (#17406 ) (#17431 )

2021-10-25 18:31:15 +01:00