1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 00:54:28 +00:00
gitea/models/issues
william-allspice e9c64f41a6
Distinguish official vs non-official reviews, add tool tips, and upgr… (#31924)
This Pull Request is a follow up to
https://github.com/go-gitea/gitea/pull/31886:

1. Adds a UI indicator between official (green) and unofficial (grey)
approved pull requests on the Pull Request page (as suggested by
@kdumontnu )
2. Adds tooltips adding clarity to the type and status of a review on
the Pull Request page (as suggested by @kdumontnu)
3. Updates text adding more clarity to required approvals (as suggested
by @kdumontnu)
4. Updates text on the branch settings page explaining what branch
approval limitations (as suggested by @yp05327)

Official approval:
<img width="376" alt="Screenshot 2024-08-26 at 1 03 52 PM"
src="https://github.com/user-attachments/assets/500f083d-bfc0-45c5-82b7-b98e20495696">

Unofficial approval:
<img width="442" alt="Screenshot 2024-08-26 at 12 53 15 PM"
src="https://github.com/user-attachments/assets/e8c565ff-5886-4ce1-8b79-a0fa26c282f7">

Rejected approval:
<img width="452" alt="Screenshot 2024-08-26 at 12 53 06 PM"
src="https://github.com/user-attachments/assets/aebc0e2f-7052-4dea-8098-7caa0db86617">

Stale approval:
<img width="546" alt="Screenshot 2024-08-26 at 1 07 59 PM"
src="https://github.com/user-attachments/assets/da599ff3-e35c-4fa3-8141-ed80b738dd77">

Requested review tooltip:
<img width="434" alt="Screenshot 2024-08-26 at 12 53 22 PM"
src="https://github.com/user-attachments/assets/460d163e-8724-43b6-8760-34b285da8fe2">

Updated text for approvals:
<img width="991" alt="Screenshot 2024-08-26 at 12 54 00 PM"
src="https://github.com/user-attachments/assets/ab3ff012-9742-4c1b-933d-21addcb89f2c">

Updated text for allowlisted/whitelisted approvals:
<img width="990" alt="Screenshot 2024-08-26 at 1 01 40 PM"
src="https://github.com/user-attachments/assets/1a5bae61-d9e0-4d96-b86f-92610b0940d1">

Protected branch settings text:
<img width="1022" alt="Screenshot 2024-08-26 at 1 01 14 PM"
src="https://github.com/user-attachments/assets/892ce208-e1c2-41f7-8fec-46d5a0e7e776">

Comments list:
<img width="1048" alt="Screenshot 2024-08-28 at 9 25 31 AM"
src="https://github.com/user-attachments/assets/9c5c00c5-06cf-43b3-b413-4f7f673609b2">

---------

Co-authored-by: Kyle D. <kdumontnu@gmail.com>
2024-09-06 06:40:02 +00:00
..
assignees_test.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
assignees.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
comment_code.go Use repo as of renderctx's member rather than a repoPath on metas (#29222) 2024-05-30 07:04:01 +00:00
comment_list.go Only update poster in issue/comment list if it has been loaded (#31216) 2024-06-02 10:32:20 +08:00
comment_test.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
comment.go Add issue comment when moving issues from one column to another of the project (#29311) 2024-08-09 01:29:02 +00:00
content_history_test.go Fix issue & comment history bugs (#29525) 2024-03-01 16:46:02 +00:00
content_history.go Fix issue & comment history bugs (#29525) 2024-03-01 16:46:02 +00:00
dependency_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
dependency.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_index.go Another round of db.DefaultContext refactor (#27103) 2023-09-25 13:17:37 +00:00
issue_label_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_label.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
issue_list_test.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_list.go Add issue comment when moving issues from one column to another of the project (#29311) 2024-08-09 01:29:02 +00:00
issue_lock.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
issue_project.go Rename project board -> column to make the UI less confusing (#30170) 2024-05-27 08:59:54 +00:00
issue_search.go Refactor issue label selection (#31497) 2024-06-26 23:41:59 +00:00
issue_stats.go Use db.ListOptions directly instead of Paginator interface to make it easier to use and fix performance of /pulls and /issues (#29990) 2024-03-24 18:51:08 +00:00
issue_test.go Allow non-admin users to delete review requests (#29057) 2024-02-24 12:38:43 +00:00
issue_update.go Prevent simultaneous editing of comments and issues (#31053) 2024-05-27 15:34:18 +00:00
issue_user_test.go Fix bug with sqlite load read (#26305) 2023-08-05 10:40:27 +08:00
issue_user.go Add combined index for issue_user.uid and issue_id (#28080) 2023-12-14 09:26:59 +00:00
issue_watch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_watch.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_xref_test.go Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-04-29 08:47:56 +00:00
issue_xref.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
issue.go Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
label_test.go Optimization of labels handling in issue_search (#26460) 2024-06-25 13:09:13 -04:00
label.go Refactor issue label selection (#31497) 2024-06-26 23:41:59 +00:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
milestone_list.go Added default sorting milestones by name (#27084) 2024-07-16 10:08:54 +02:00
milestone_test.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
milestone.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull_list.go Fix PullRequestList.GetIssueIDs's logic (#31352) 2024-06-13 09:42:07 +00:00
pull_test.go Refactor StringsToInt64s (#29967) 2024-03-21 15:07:35 +00:00
pull.go Fix null requested_reviewer from API (#31773) 2024-08-05 10:59:53 +00:00
reaction.go Add container.FilterSlice function (#30339) 2024-04-09 20:27:30 +08:00
review_list.go Fix null requested_reviewer from API (#31773) 2024-08-05 10:59:53 +00:00
review_test.go Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-28 15:19:24 +00:00
review.go Distinguish official vs non-official reviews, add tool tips, and upgr… (#31924) 2024-09-06 06:40:02 +00:00
stopwatch_test.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
stopwatch.go Remove deadcode under models/issues (#28536) 2023-12-19 20:12:02 +01:00
tracked_time_test.go remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
tracked_time.go Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00