mirror of
https://github.com/go-gitea/gitea
synced 2024-11-14 06:04:25 +00:00
55532061c8
This PR adds a new dropdown to select a commit or a commit range (shift-click like github) of a Pull Request. After selection of a commit only the changes of this commit will be shown. When selecting a range of commits the diff of this range is shown. This allows to review a PR commit by commit or by viewing only commit ranges. The "Show changes since your last review" mechanism github uses is implemented, too. When reviewing a single commit or a commit range the "Viewed" functionality is disabled. ## Screenshots ### The commit dropdown  ### Selecting a commit range  ### Show changes of a single commit only  ### Show changes of a commit range  Fixes https://github.com/go-gitea/gitea/issues/20989 Fixes https://github.com/go-gitea/gitea/issues/19263 --------- Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: KN4CK3R <admin@oldschoolhack.me> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: delvh <dev.lh@web.de>
59 lines
2.0 KiB
Go
59 lines
2.0 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/tests"
|
|
|
|
"github.com/PuerkitoBio/goquery"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestPullDiff_CompletePRDiff(t *testing.T) {
|
|
doTestPRDiff(t, "/user2/commitsonpr/pulls/1/files", false, []string{"test1.txt", "test10.txt", "test2.txt", "test3.txt", "test4.txt", "test5.txt", "test6.txt", "test7.txt", "test8.txt", "test9.txt"})
|
|
}
|
|
|
|
func TestPullDiff_SingleCommitPRDiff(t *testing.T) {
|
|
doTestPRDiff(t, "/user2/commitsonpr/pulls/1/commits/c5626fc9eff57eb1bb7b796b01d4d0f2f3f792a2", true, []string{"test3.txt"})
|
|
}
|
|
|
|
func TestPullDiff_CommitRangePRDiff(t *testing.T) {
|
|
doTestPRDiff(t, "/user2/commitsonpr/pulls/1/files/4ca8bcaf27e28504df7bf996819665986b01c847..23576dd018294e476c06e569b6b0f170d0558705", true, []string{"test2.txt", "test3.txt", "test4.txt"})
|
|
}
|
|
|
|
func TestPullDiff_StartingFromBaseToCommitPRDiff(t *testing.T) {
|
|
doTestPRDiff(t, "/user2/commitsonpr/pulls/1/files/c5626fc9eff57eb1bb7b796b01d4d0f2f3f792a2", true, []string{"test1.txt", "test2.txt", "test3.txt"})
|
|
}
|
|
|
|
func doTestPRDiff(t *testing.T, prDiffURL string, reviewBtnDisabled bool, expectedFilenames []string) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
session := loginUser(t, "user2")
|
|
|
|
req := NewRequest(t, "GET", "/user2/commitsonpr/pulls")
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
// Get the given PR diff url
|
|
req = NewRequest(t, "GET", prDiffURL)
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
doc := NewHTMLParser(t, resp.Body)
|
|
|
|
// Assert all files are visible.
|
|
fileContents := doc.doc.Find(".file-content")
|
|
numberOfFiles := fileContents.Length()
|
|
|
|
assert.Equal(t, len(expectedFilenames), numberOfFiles)
|
|
|
|
fileContents.Each(func(i int, s *goquery.Selection) {
|
|
filename, _ := s.Attr("data-old-filename")
|
|
assert.Equal(t, expectedFilenames[i], filename)
|
|
})
|
|
|
|
// Ensure the review button is enabled for full PR reviews
|
|
assert.Equal(t, reviewBtnDisabled, doc.doc.Find(".js-btn-review").HasClass("disabled"))
|
|
}
|