mirror of
				https://github.com/go-gitea/gitea
				synced 2025-10-27 17:38:25 +00:00 
			
		
		
		
	Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			267 lines
		
	
	
		
			5.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			267 lines
		
	
	
		
			5.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2017 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package validation
 | |
| 
 | |
| import (
 | |
| 	"testing"
 | |
| 
 | |
| 	"gitea.com/go-chi/binding"
 | |
| )
 | |
| 
 | |
| var gitRefNameValidationTestCases = []validationTestCase{
 | |
| 	{
 | |
| 		description: "Referece contains only characters",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "test",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name contains single slash",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "feature/test",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has allowed special characters",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "debian/1%1.6.0-2",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name contains backslash",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "feature\\test",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name starts with dot",
 | |
| 		data: TestForm{
 | |
| 			BranchName: ".test",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name ends with dot",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "test.",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name starts with slash",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "/test",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name ends with slash",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "test/",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name ends with .lock",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "test.lock",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name contains multiple consecutive dots",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "te..st",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name contains multiple consecutive slashes",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "te//st",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name is single @",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "@",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has @{",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "branch@{",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character ~",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "~debian/1%1.6.0-2",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character *",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "*debian/1%1.6.0-2",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character ?",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "?debian/1%1.6.0-2",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character ^",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "^debian/1%1.6.0-2",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character :",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "debian:jessie",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character (whitespace)",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "debian jessie",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| 	{
 | |
| 		description: "Reference name has unallowed special character [",
 | |
| 		data: TestForm{
 | |
| 			BranchName: "debian[jessie",
 | |
| 		},
 | |
| 		expectedErrors: binding.Errors{
 | |
| 			binding.Error{
 | |
| 				FieldNames:     []string{"BranchName"},
 | |
| 				Classification: ErrGitRefName,
 | |
| 				Message:        "GitRefName",
 | |
| 			},
 | |
| 		},
 | |
| 	},
 | |
| }
 | |
| 
 | |
| func Test_GitRefNameValidation(t *testing.T) {
 | |
| 	AddBindingRules()
 | |
| 
 | |
| 	for _, testCase := range gitRefNameValidationTestCases {
 | |
| 		t.Run(testCase.description, func(t *testing.T) {
 | |
| 			performValidationTest(t, testCase)
 | |
| 		})
 | |
| 	}
 | |
| }
 |