Infinoid 86ee5b4b1b PATCH branch-protection updates check list even when checks are disabled (#26351) ...

Fixes: #26333.

Previously, this endpoint only updates the `StatusCheckContexts` field
when `EnableStatusCheck==true`, which makes it impossible to clear the
array otherwise.

This patch uses slice `nil`-ness to decide whether to update the list of
checks. The field is ignored when either the client explicitly passes in
a null, or just omits the field from the json ([which causes
`json.Unmarshal` to leave the struct field
unchanged](https://go.dev/play/p/Z2XHOILuB1Q)). I think this is a better
measure of intent than whether the `EnableStatusCheck` flag was set,
because it matches the semantics of other field types.

Also adds a test case. I noticed that [`testAPIEditBranchProtection`
only checks the branch
name](https://github.com/go-gitea/gitea/blob/c1c83dbaec840871c1247f4bc3f875309b0de6bb/tests/integration/api_branch_test.go#L68)
and no other fields, so I added some extra `GET` calls and specific
checks to make sure the fields are changing properly.

I added those checks the existing integration test; is that the right
place for it?

2023-08-24 05:36:04 +00:00

..

actions

fix artifact merging chunks path with correct slash on Windows (#26400)

2023-08-08 17:21:48 +00:00

packages

Fix NuGet search endpoints (#25613)

2023-08-14 02:50:55 +00:00

v1

PATCH branch-protection updates check list even when checks are disabled (#26351)

2023-08-24 05:36:04 +00:00