1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-22 16:44:26 +00:00
gitea/models
Kemal Zebari 242b331260
Prevent re-review and dismiss review actions on closed and merged PRs (#30065)
Resolves #29965.

---
Manually tested this by:
- Following the
[installation](https://docs.gitea.com/next/installation/install-with-docker#basics)
guide (but built a local Docker image instead)
- Creating 2 users, one who is the `Owner` of a newly-created repository
and the other a `Collaborator`
- Had the `Collaborator` create a PR that the `Owner` reviews
- `Collaborator` resolves conversation and `Owner` merges PR

And with this change we see that we can no longer see re-request review
button for the `Owner`:

<img width="1351" alt="Screenshot 2024-03-25 at 12 39 18 AM"
src="https://github.com/go-gitea/gitea/assets/60799661/bcd9c579-3cf7-474f-a51e-b436fe1a39a4">
2024-03-28 15:19:24 +00:00
..
actions Cancel previous runs of the same PR automatically (#29961) 2024-03-21 15:01:35 +08:00
activities Performance improvements for pull request list page (#29900) 2024-03-21 14:13:08 +01:00
admin Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
asymkey Fix some pending problems (#29985) 2024-03-22 19:17:30 +08:00
auth remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
avatars Replace 10 more gt- classes with tw- (#29945) 2024-03-22 13:45:10 +00:00
db Fix misuse of TxContext (#30061) 2024-03-25 15:00:16 +08:00
dbfs make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
fixtures Add default board to new projects, remove uncategorized pseudo-board (#29874) 2024-03-27 20:54:32 +00:00
git Move from max( id ) to max( index ) for latest commit statuses (#30076) 2024-03-28 16:01:15 +08:00
issues Prevent re-review and dismiss review actions on closed and merged PRs (#30065) 2024-03-28 15:19:24 +00:00
migrations Add default board to new projects, remove uncategorized pseudo-board (#29874) 2024-03-27 20:54:32 +00:00
organization Respect DEFAULT_ORG_MEMBER_VISIBLE setting when adding creator to org (#30013) 2024-03-23 21:59:58 +00:00
packages Fix incorrect relative/absolute URL usages (#29531) 2024-03-02 17:38:38 +00:00
perm Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
project Add default board to new projects, remove uncategorized pseudo-board (#29874) 2024-03-27 20:54:32 +00:00
pull Add support for sha256 repositories (#23894) 2024-01-19 17:05:02 +01:00
repo Do some performance optimize for issues list and view issue/pull (#29515) 2024-03-12 07:23:44 +00:00
secret Make runs-on support variable expression (#29468) 2024-03-08 06:14:35 +00:00
shared/types Refactor locale&string&template related code (#29165) 2024-02-14 21:48:45 +00:00
system Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
unit Make actions default enabled for newly created repository if global configuraion enabled (#27482) 2023-10-10 14:45:31 +00:00
unittest Workaround to clean up old reviews on creating a new one (#28554) 2024-02-19 14:42:18 +01:00
user Fix user id column case (#29863) 2024-03-17 13:24:45 +00:00
webhook Store webhook event in database (#29145) 2024-03-07 23:18:38 +01:00
error.go Add merge style fast-forward-only (#28954) 2024-02-12 23:37:23 +01:00
fixture_generation.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
fixture_test.go Replace more db.DefaultContext (#27628) 2023-10-15 17:46:06 +02:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
org_team_test.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
org_team.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
org_test.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
org.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
repo_test.go Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
repo_transfer.go Add user blocking (#29028) 2024-03-04 08:16:03 +00:00
repo.go Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00