1
1
mirror of https://github.com/go-gitea/gitea synced 2025-01-18 13:44:27 +00:00
zeripath 0dcc74a8a7
Prevent dangling cat-file calls (goroutine alternative) (#19454)
If an `os/exec.Command` is passed non `*os.File` as an input/output, go
will create `os.Pipe`s and wait for their closure in `cmd.Wait()`.  If
the code following this is responsible for closing `io.Pipe`s or other
handlers then on process death from context cancellation the `Wait` can
hang.

There are two possible solutions:

1. use `os.Pipe` as the input/output as `cmd.Wait` does not wait for these.
2. create a goroutine waiting on the context cancellation that will close the inputs.

This PR provides the second option - which is a simpler change that can
be more easily backported.

Closes #19448

Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-04-22 17:20:04 +02:00
..
2021-10-24 22:12:43 +01:00
2022-01-20 18:46:10 +01:00
2022-01-25 18:15:58 +00:00
2021-12-02 15:28:08 +08:00
2022-01-20 18:46:10 +01:00
2021-10-17 20:47:12 +01:00
2022-01-20 18:46:10 +01:00
2021-12-20 04:41:31 +00:00

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.