mirror of
https://github.com/go-gitea/gitea
synced 2024-11-05 01:34:25 +00:00
de6ef14d04
* Validate External Tracker URL Format Add some validation checks for external tracker URL format. Fixes #7068 * Don't make {index} a hard requirement * Fix Description * make fmt * move regex to package level * fix copyright date
158 lines
3.8 KiB
Go
158 lines
3.8 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package validation
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
"code.gitea.io/gitea/modules/setting"
|
|
)
|
|
|
|
func Test_IsValidURL(t *testing.T) {
|
|
cases := []struct {
|
|
description string
|
|
url string
|
|
valid bool
|
|
}{
|
|
{
|
|
description: "Empty URL",
|
|
url: "",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "Loobpack IPv4 URL",
|
|
url: "http://127.0.1.1:5678/",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "Loobpack IPv6 URL",
|
|
url: "https://[::1]/",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "Missing semicolon after schema",
|
|
url: "http//meh/",
|
|
valid: false,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range cases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
assert.Equal(t, testCase.valid, IsValidURL(testCase.url))
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_IsValidExternalURL(t *testing.T) {
|
|
setting.AppURL = "https://try.gitea.io/"
|
|
|
|
cases := []struct {
|
|
description string
|
|
url string
|
|
valid bool
|
|
}{
|
|
{
|
|
description: "Current instance URL",
|
|
url: "https://try.gitea.io/test",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "Loobpack IPv4 URL",
|
|
url: "http://127.0.1.1:5678/",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "Current instance API URL",
|
|
url: "https://try.gitea.io/api/v1/user/follow",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "Local network URL",
|
|
url: "http://192.168.1.2/api/v1/user/follow",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "Local URL",
|
|
url: "http://LOCALHOST:1234/whatever",
|
|
valid: false,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range cases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
assert.Equal(t, testCase.valid, IsValidExternalURL(testCase.url))
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_IsValidExternalTrackerURLFormat(t *testing.T) {
|
|
setting.AppURL = "https://try.gitea.io/"
|
|
|
|
cases := []struct {
|
|
description string
|
|
url string
|
|
valid bool
|
|
}{
|
|
{
|
|
description: "Correct external tracker URL with all placeholders",
|
|
url: "https://github.com/{user}/{repo}/issues/{index}",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "Local external tracker URL with all placeholders",
|
|
url: "https://127.0.0.1/{user}/{repo}/issues/{index}",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "External tracker URL with typo placeholder",
|
|
url: "https://github.com/{user}/{repo/issues/{index}",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "External tracker URL with typo placeholder",
|
|
url: "https://github.com/[user}/{repo/issues/{index}",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "External tracker URL with typo placeholder",
|
|
url: "https://github.com/{user}/repo}/issues/{index}",
|
|
valid: false,
|
|
},
|
|
{
|
|
description: "External tracker URL missing optional placeholder",
|
|
url: "https://github.com/{user}/issues/{index}",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "External tracker URL missing optional placeholder",
|
|
url: "https://github.com/{repo}/issues/{index}",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "External tracker URL missing optional placeholder",
|
|
url: "https://github.com/issues/{index}",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "External tracker URL missing optional placeholder",
|
|
url: "https://github.com/issues/{user}",
|
|
valid: true,
|
|
},
|
|
{
|
|
description: "External tracker URL with similar placeholder names test",
|
|
url: "https://github.com/user/repo/issues/{index}",
|
|
valid: true,
|
|
},
|
|
}
|
|
|
|
for _, testCase := range cases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
assert.Equal(t, testCase.valid, IsValidExternalTrackerURLFormat(testCase.url))
|
|
})
|
|
}
|
|
}
|