1
1
mirror of https://github.com/go-gitea/gitea synced 2024-11-09 11:44:27 +00:00
gitea/routers/admin
6543 33431fcbd3
Validate email before inserting/updating (#13475) (#13666)
* Add email validity check (#13475)

* Improve error feedback for duplicate deploy keys

Instead of a generic HTTP 500 error page, a flash message is rendered
with the deploy key page template so inform the user that a key with the
intended title already exists.

* API returns 422 error when key with name exists

* Add email validity checking

Add email validity checking for the following routes:
[Web interface]
1. User registration
2. User creation by admin
3. Adding an email through user settings
[API]
1. POST /admin/users
2. PATCH /admin/users/:username
3. POST /user/emails

* Add further tests

* Add signup email tests

* Add email validity check for linking existing account

* Address PR comments

* Remove unneeded DB session

* Move email check to updateUser

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>

* skip email validation on empty string (#13627)

- move validation into its own function
- use a session for UpdateUserSetting

* rm TODO for backport

Co-authored-by: Chris Shyi <chrisshyi13@gmail.com>
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-11-22 12:31:35 -05:00
..
admin_test.go Shadow the password on cache and session config on admin panel (#7300) 2019-06-27 00:12:38 +08:00
admin.go Hide sync ssh keys button on admin dashboard if ssh disabled or builtin-ssh enabled (#13072) 2020-10-08 12:43:15 -04:00
auths.go Remove PAM from auth dropdown when unavailable (#13276) (#13281) 2020-10-23 12:00:20 -04:00
emails.go Admin page for managing user e-mail activation (#10557) 2020-03-02 15:25:36 -03:00
hooks.go System-wide webhooks (#10546) 2020-03-09 00:08:05 +02:00
main_test.go Force user to change password (#4489) 2018-09-13 15:04:25 +03:00
notice.go Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
orgs.go API add/generalize pagination (#9452) 2020-01-24 14:00:29 -05:00
repos.go Adopt repositories (#12920) 2020-09-25 07:09:23 +03:00
users_test.go Validate email before inserting/updating (#13475) (#13666) 2020-11-22 12:31:35 -05:00
users.go Validate email before inserting/updating (#13475) (#13666) 2020-11-22 12:31:35 -05:00