1
1
mirror of https://github.com/go-gitea/gitea synced 2024-06-27 13:45:51 +00:00
gitea/templates/base
wxiaoguang 345aa09756
Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450)
This PR is extracted from #23346 to address some unclear (I don't
understand) code-belonging concerns.

This PR needs to be backported, otherwise the `aria.js` is too buggy in
some cases. Since there would be two minor conflicts, I will do the
backport manually.

Before: the `aria.js` is still buggy in some cases.

After: tested with AppleVoice, Android TalkBack

* Fix incorrect dropdown init code
* Fix incorrect role element (the menu role should be on the `$menu`
element, but not on the `$focusable`)
* Fix the focus-show-click-hide problem on mobile. Now the language menu
works as expected
* Fix incorrect dropdown template function setting
* Clarify the logic in aria.js
* Hide item's tippy after menu gets hidden
* Fix incorrect tippy `setProps` after `destroy`
* Fix UI lag problem when page gets redirected during menu hiding
animation with screen reader
* Improve comments
* Implement the layout proposed by #19861

<details>


d74a7efb60/web_src/js/features/aria.md (L38-L47)

</details>
2023-03-17 11:08:05 +08:00
..
alert_details.tmpl Enforce tab indentation in templates (#15289) 2021-04-10 23:46:37 -04:00
alert.tmpl Support Issue forms and PR forms (#20987) 2022-09-02 15:58:49 +08:00
delete_modal_actions.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
disable_form_autofill.tmpl Disable form autofill (#17291) 2021-10-19 01:08:41 +03:00
footer_content.tmpl Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 2023-03-17 11:08:05 +08:00
footer.tmpl Add new captcha: cloudflare turnstile (#22369) 2023-02-05 15:29:03 +08:00
head_navbar.tmpl Add accessibility to the menu on the navbar (#23059) 2023-02-22 15:58:07 -06:00
head_script.tmpl Introduce customized HTML elements, fix incorrect AppUrl usages in templates (#22861) 2023-02-17 22:02:20 +08:00
head.tmpl Fix various bugs for "install" page (#23194) 2023-03-04 10:12:02 +08:00
paginate.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00