mirror of
https://github.com/go-gitea/gitea
synced 2024-12-27 02:54:27 +00:00
695e8ae81d
Backport #16813 Make the group_id a primary key in issue_index. This already has an unique index and therefore is a good candidate for becoming a primary key. This PR also changes all other uses of this table to add the group_id as the primary key. The migration v192 from #16813 has not been backported but Xorm will work fine with non-primary keyed tables. If a user on 1.15 wishes to have the correct schema sooner than 1.16 - they can use gitea doctor recreate-table issue_index and gitea will recreate the table with the primary key. Fix #16802 Signed-off-by: Andrew Thornton art27@cantab.net
60 lines
1.3 KiB
Go
60 lines
1.3 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package migrations
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func Test_addIssueResourceIndexTable(t *testing.T) {
|
|
// Create the models used in the migration
|
|
type Issue struct {
|
|
ID int64 `xorm:"pk autoincr"`
|
|
RepoID int64 `xorm:"UNIQUE(s)"`
|
|
Index int64 `xorm:"UNIQUE(s)"`
|
|
}
|
|
|
|
// Prepare and load the testing database
|
|
x, deferable := prepareTestEnv(t, 0, new(Issue))
|
|
if x == nil || t.Failed() {
|
|
defer deferable()
|
|
return
|
|
}
|
|
defer deferable()
|
|
|
|
// Run the migration
|
|
if err := addIssueResourceIndexTable(x); err != nil {
|
|
assert.NoError(t, err)
|
|
return
|
|
}
|
|
|
|
type ResourceIndex struct {
|
|
GroupID int64 `xorm:"pk"`
|
|
MaxIndex int64 `xorm:"index"`
|
|
}
|
|
|
|
var start = 0
|
|
const batchSize = 1000
|
|
for {
|
|
var indexes = make([]ResourceIndex, 0, batchSize)
|
|
err := x.Table("issue_index").Limit(batchSize, start).Find(&indexes)
|
|
assert.NoError(t, err)
|
|
|
|
for _, idx := range indexes {
|
|
var maxIndex int
|
|
has, err := x.SQL("SELECT max(`index`) FROM issue WHERE repo_id = ?", idx.GroupID).Get(&maxIndex)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
assert.EqualValues(t, maxIndex, idx.MaxIndex)
|
|
}
|
|
if len(indexes) < batchSize {
|
|
break
|
|
}
|
|
start += len(indexes)
|
|
}
|
|
}
|