Jason Song 82728a7cec Do not overwrite empty DefaultBranch (#22708) ... Fix #21994. And fix #19470. While generating new repo from a template, it does something like "commit to git repo, re-fetch repo model from DB, and update default branch if it's empty". 19d5b2f922/modules/repository/generate.go (L241-L253) Unfortunately, when load repo from DB, the default branch will be set to `setting.Repository.DefaultBranch` if it's empty: 19d5b2f922/models/repo/repo.go (L228-L233) I believe it's a very old temporary patch but has been kept for many years, see: [2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8) I know it's a risk to delete it, may lead to potential behavioral changes, but we cannot keep the outdated `FIXME` forever. On the other hand, an empty `DefaultBranch` does make sense: an empty repo doesn't have one conceptually (actually, Gitea will still set it to `setting.Repository.DefaultBranch` to make it safer).		2023-02-02 14:48:48 -06:00
..
access_token.yml	Hash App token (#6724)	2019-05-04 11:45:34 -04:00
access.yml	Fix user visible check (#21210)	2022-09-20 15:59:20 +08:00
action.yml	GetFeeds must always discard actions with dangling repo_id (#19598)	2022-05-05 11:39:26 -04:00
attachment.yml	Add some api integration tests (#18872)	2022-10-18 00:23:27 +08:00
collaboration.yml	Fix "access" fixtures and tests (#10247)	2020-02-15 12:29:06 +08:00
comment.yml	[API] Add "before" query to ListIssueComments and ListRepoIssue… (#9685)	2020-01-13 17:02:24 +01:00
commit_status_index.yml	Fix commit status index problem (#17061)	2021-09-23 18:50:06 +08:00
commit_status.yml
deleted_branch.yml	Add deleted_branch table fixture (#2832)	2017-11-04 15:31:59 +02:00
deploy_key.yml
email_address.yml	Always store primary email address into email_address table and also the state (#15956)	2021-06-08 11:52:51 +08:00
external_login_user.yml	add test coverage for original author conversion during migrations (#18506)	2022-02-01 13:20:28 -05:00
follow.yml	Fix user visible check (#21210)	2022-09-20 15:59:20 +08:00
gpg_key_import.yml
gpg_key.yml
hook_task.yml	Decouple HookTask from Repository (#17940)	2022-10-21 18:21:56 +02:00
issue_assignees.yml	Fix issue overview for teams (#19652)	2022-05-16 17:49:17 +08:00
issue_index.yml	Fix issue overview for teams (#19652)	2022-05-16 17:49:17 +08:00
issue_label.yml	Add Organization Wide Labels (#10814)	2020-04-01 01:14:46 -03:00
issue_user.yml	[API] ListIssues add more filters (#16174)	2021-06-16 18:33:37 -04:00
issue_watch.yml	Refactor Issues Subscription (#8738)	2019-11-20 22:50:54 +08:00
issue.yml	Add some api integration tests (#18872)	2022-10-18 00:23:27 +08:00
label.yml	Add some api integration tests (#18872)	2022-10-18 00:23:27 +08:00
lfs_meta_object.yml	Test views of LFS files (#22196)	2022-12-23 07:41:56 +08:00
login_source.yml
milestone.yml	Add some api integration tests (#18872)	2022-10-18 00:23:27 +08:00
notice.yml
notification.yml	[API] Add notification endpoint (#9488)	2020-01-09 11:56:32 +00:00
oauth2_application.yml	Record OAuth client type at registration (#21316)	2022-10-24 15:59:24 +08:00
oauth2_authorization_code.yml	Record OAuth client type at registration (#21316)	2022-10-24 15:59:24 +08:00
oauth2_grant.yml	Record OAuth client type at registration (#21316)	2022-10-24 15:59:24 +08:00
org_user.yml	Fix user visible check (#21210)	2022-09-20 15:59:20 +08:00
project_board.yml	Support org/user level projects (#22235)	2023-01-20 19:42:33 +08:00
project_issue.yml	Kanban board (#8346)	2020-08-16 23:07:38 -04:00
project.yml	Support org/user level projects (#22235)	2023-01-20 19:42:33 +08:00
protected_branch.yml
public_key.yml	test: command keys (#9357)	2019-12-15 08:11:31 +00:00
pull_request.yml	Add API endpoint to get changed files of a PR (#21177)	2022-09-29 04:27:20 +02:00
reaction.yml	[API] Add Reactions (#9220)	2019-12-07 17:04:19 -05:00
release.yml	[API] ListReleases add filter for draft and pre-releases (#16175)	2021-06-17 10:58:10 +02:00
renamed_branch.yml	Add a simple way to rename branch like gh (#15870)	2021-10-08 19:03:04 +02:00
repo_archiver.yml	Rework repository archive (#14723)	2021-06-23 17:12:38 -04:00
repo_indexer_status.yml
repo_redirect.yml
repo_topic.yml	Add API endpoint for accessing repo topics (#7963)	2019-09-03 23:46:24 +08:00
repo_transfer.yml	Repository transfer has to be confirmed, if user can not create repo for new owner (#14792)	2021-03-01 01:47:30 +01:00
repo_unit.yml	Test views of LFS files (#22196)	2022-12-23 07:41:56 +08:00
repository.yml	Do not overwrite empty DefaultBranch (#22708)	2023-02-02 14:48:48 -06:00
review.yml	Add dismiss review feature (#12674)	2021-02-11 18:32:25 +01:00
star.yml
stopwatch.yml	[API] extend StopWatch (#9196)	2019-12-11 23:23:05 -05:00
system_setting.yml	Add system setting table with cache and also add cache supports for user setting (#18058)	2022-10-17 07:29:26 +08:00
team_repo.yml
team_unit.yml	Fix issue overview for teams (#19652)	2022-05-16 17:49:17 +08:00
team_user.yml	Don't return duplicated users who can create org repo (#22560)	2023-01-30 18:12:45 +08:00
team.yml	Don't return duplicated users who can create org repo (#22560)	2023-01-30 18:12:45 +08:00
topic.yml	Add some api integration tests (#18872)	2022-10-18 00:23:27 +08:00
tracked_time.yml	[API] Extend times API (#9200)	2019-12-27 20:30:58 +00:00
two_factor.yml	org/members: display 2FA members states + optimize sql requests (#7621)	2019-08-02 12:06:27 -04:00
user_open_id.yml
user_redirect.yml	Redirect on changed user and org name (#11649)	2021-01-24 16:23:05 +01:00
user.yml	Don't return duplicated users who can create org repo (#22560)	2023-01-30 18:12:45 +08:00
watch.yml	Auto-subscribe user to repository when they commit/tag to it (#7657)	2019-11-10 09:22:19 +00:00
webauthn_credential.yml	Add some api integration tests (#18872)	2022-10-18 00:23:27 +08:00
webhook.yml	Implement webhook branch filter (#7791)	2019-09-09 08:48:21 +03:00