zeripath bbffcc3aec Multiple Escaping Improvements (#17551) ... There are multiple places where Gitea does not properly escape URLs that it is building and there are multiple places where it builds urls when there is already a simpler function available to use this. This is an extensive PR attempting to fix these issues. 1. The first commit in this PR looks through all href, src and links in the Gitea codebase and has attempted to catch all the places where there is potentially incomplete escaping. 2. Whilst doing this we will prefer to use functions that create URLs over recreating them by hand. 3. All uses of strings should be directly escaped - even if they are not currently expected to contain escaping characters. The main benefit to doing this will be that we can consider relaxing the constraints on user names and reponames in future. 4. The next commit looks at escaping in the wiki and re-considers the urls that are used there. Using the improved escaping here wiki files containing '/'. (This implementation will currently still place all of the wiki files the root directory of the repo but this would not be difficult to change.) 5. The title generation in feeds is now properly escaped. 6. EscapePound is no longer needed - urls should be PathEscaped / QueryEscaped as necessary but then re-escaped with Escape when creating html with locales Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net>		2021-11-16 18:18:25 +00:00
..
appstate	Sync gitea app path for git hooks and authorized keys when starting (#17335)	2021-10-21 17:22:43 +08:00
avatars	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
db	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
fixtures	Allow U2F 2FA without TOTP (#11573)	2021-11-08 23:47:19 +01:00
issues	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
login	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
migrations	Fix offBy1 errors (#17606)	2021-11-14 10:11:49 +02:00
unit	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
unittest	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
user	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
webhook	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
access_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
access.go	Nicely handle missing user in collaborations (#17049)	2021-09-27 19:07:19 +01:00
action_list.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
action_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
action.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
admin_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
admin.go	Fix problem when database ID is not incremented as expected (#17229)	2021-10-06 15:36:24 -05:00
attachment_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
attachment.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
branches_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
branches.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
commit_status_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
commit_status.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
commit.go	Replace list.List with slices (#16311)	2021-08-09 14:08:51 -04:00
consistency_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
consistency.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
engine_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
error.go	Move EmailAddress & UserRedirect into models/user/ (#17607)	2021-11-11 15:03:30 +08:00
external_login_user.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
fixture_generation.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
fixture_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
gpg_key_add.go	Handle duplicate keys on GPG key ring (#17242)	2021-10-07 23:10:14 +03:00
gpg_key_commit_verification.go	Move EmailAddress & UserRedirect into models/user/ (#17607)	2021-11-11 15:03:30 +08:00
gpg_key_common.go	Add option to provide signature for a token to verify key ownership (#14054)	2021-07-13 15:28:07 +02:00
gpg_key_import.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
gpg_key_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
gpg_key_verify.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
gpg_key.go	Move EmailAddress & UserRedirect into models/user/ (#17607)	2021-11-11 15:03:30 +08:00
helper_directory.go	refactor: move from io/ioutil to io and os package (#17109)	2021-09-22 13:38:34 +08:00
helper_environment.go	chore(models): rewrite code format. (#14754)	2021-03-14 19:52:12 +01:00
helper.go	Create doctor command to fix repo_units broken by dumps from 1.14.3-1.14.6 (#17136)	2021-09-27 16:55:12 +01:00
issue_assignees_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_assignees.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
issue_comment_list.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
issue_comment_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_comment.go	Refactor commentTags functionality (#17558)	2021-11-11 14:29:30 +08:00
issue_dependency_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_dependency.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
issue_label_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_label.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
issue_list_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_list.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
issue_lock.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
issue_milestone_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_milestone.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
issue_reaction_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_reaction.go	Added GetUserByIDCtx. (#17602)	2021-11-09 22:21:01 -05:00
issue_stopwatch_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_stopwatch.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
issue_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_tracked_time_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_tracked_time.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
issue_user_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_user.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
issue_watch_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_watch.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
issue_xref_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
issue_xref.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
issue.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
lfs_lock.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
lfs.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
main_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
migrate.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
notification_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
notification.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
org_team_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
org_team.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
org_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
org.go	Move EmailAddress & UserRedirect into models/user/ (#17607)	2021-11-11 15:03:30 +08:00
project_board.go	Kanban colored boards (#16647)	2021-09-29 22:53:12 +02:00
project_issue.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
project_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
project.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
protected_tag_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
protected_tag.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
pull_list.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
pull_sign.go	Move twofactor to models/login (#17143)	2021-09-25 15:00:12 +02:00
pull_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
pull.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
release.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
repo_activity.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_archiver.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_avatar.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
repo_branch.go	Move newbranch to standalone package (#9627)	2020-01-14 11:38:04 +08:00
repo_collaboration_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_collaboration.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
repo_generate_test.go	Fixed assert statements. (#16089)	2021-06-07 07:27:09 +02:00
repo_generate.go	Move webhook into models/webhook/ (#17579)	2021-11-10 13:13:16 +08:00
repo_indexer.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_issue.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
repo_language_stats.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_list_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_list.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
repo_mirror.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_permission_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_permission.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
repo_pushmirror_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
repo_pushmirror.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_redirect_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_redirect.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
repo_sign.go	Move twofactor to models/login (#17143)	2021-09-25 15:00:12 +02:00
repo_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_transfer_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_transfer.go	Nicely handle missing user in collaborations (#17049)	2021-09-27 19:07:19 +01:00
repo_unit.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
repo_watch_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
repo_watch.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
repo.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
review_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
review.go	Move unit into models/unit/ (#17576)	2021-11-09 20:57:58 +01:00
ssh_key_authorized_keys.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
ssh_key_authorized_principals.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
ssh_key_deploy.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
ssh_key_fingerprint.go	Move db related basic functions to models/db (#17075)	2021-09-19 19:49:59 +08:00
ssh_key_parse.go	refactor: move from io/ioutil to io and os package (#17109)	2021-09-22 13:38:34 +08:00
ssh_key_principals.go	Move EmailAddress & UserRedirect into models/user/ (#17607)	2021-11-11 15:03:30 +08:00
ssh_key_test.go	Add support for ed25519_sk and ecdsa_sk SSH keys (#13462)	2021-01-20 20:36:55 +00:00
ssh_key.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
star_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
star.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
statistic.go	Move webhook into models/webhook/ (#17579)	2021-11-10 13:13:16 +08:00
task.go	Move migrations into services and base into modules/migration (#17663)	2021-11-16 23:25:33 +08:00
token_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
token.go	Fix problem when database ID is not incremented as expected (#17229)	2021-10-06 15:36:24 -05:00
topic_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
topic.go	Move login related structs and functions to models/login (#17093)	2021-09-24 19:32:56 +08:00
update.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
upload.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
user_avatar.go	In many cases user avatar link should be an absolute URL with http host (#17420)	2021-10-25 13:01:16 +08:00
user_email_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
user_email.go	Move EmailAddress & UserRedirect into models/user/ (#17607)	2021-11-11 15:03:30 +08:00
user_follow_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
user_follow.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
user_heatmap_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
user_heatmap.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
user_openid_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
user_openid.go	DBContext is just a Context (#17100)	2021-09-23 23:45:36 +08:00
user_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
user.go	Multiple Escaping Improvements (#17551)	2021-11-16 18:18:25 +00:00
userlist_test.go	Decouple unit test code from business code (#17623)	2021-11-12 22:36:47 +08:00
userlist.go	Move twofactor to models/login (#17143)	2021-09-25 15:00:12 +02:00
wiki_test.go	Decouple unit test, remove intermediate unittestbridge package (#17662)	2021-11-16 16:53:21 +08:00
wiki.go	Handle and propagate errors when checking if paths are Dirs, Files or Exist (#13186)	2020-11-27 21:42:08 -05:00