mirror of
				https://github.com/go-gitea/gitea
				synced 2025-11-03 21:08:25 +00:00 
			
		
		
		
	# ⚠️ Breaking Many deprecated queue config options are removed (actually, they should have been removed in 1.18/1.19). If you see the fatal message when starting Gitea: "Please update your app.ini to remove deprecated config options", please follow the error messages to remove these options from your app.ini. Example: ``` 2023/05/06 19:39:22 [E] Removed queue option: `[indexer].ISSUE_INDEXER_QUEUE_TYPE`. Use new options in `[queue.issue_indexer]` 2023/05/06 19:39:22 [E] Removed queue option: `[indexer].UPDATE_BUFFER_LEN`. Use new options in `[queue.issue_indexer]` 2023/05/06 19:39:22 [F] Please update your app.ini to remove deprecated config options ``` Many options in `[queue]` are are dropped, including: `WRAP_IF_NECESSARY`, `MAX_ATTEMPTS`, `TIMEOUT`, `WORKERS`, `BLOCK_TIMEOUT`, `BOOST_TIMEOUT`, `BOOST_WORKERS`, they can be removed from app.ini. # The problem The old queue package has some legacy problems: * complexity: I doubt few people could tell how it works. * maintainability: Too many channels and mutex/cond are mixed together, too many different structs/interfaces depends each other. * stability: due to the complexity & maintainability, sometimes there are strange bugs and difficult to debug, and some code doesn't have test (indeed some code is difficult to test because a lot of things are mixed together). * general applicability: although it is called "queue", its behavior is not a well-known queue. * scalability: it doesn't seem easy to make it work with a cluster without breaking its behaviors. It came from some very old code to "avoid breaking", however, its technical debt is too heavy now. It's a good time to introduce a better "queue" package. # The new queue package It keeps using old config and concept as much as possible. * It only contains two major kinds of concepts: * The "base queue": channel, levelqueue, redis * They have the same abstraction, the same interface, and they are tested by the same testing code. * The "WokerPoolQueue", it uses the "base queue" to provide "worker pool" function, calls the "handler" to process the data in the base queue. * The new code doesn't do "PushBack" * Think about a queue with many workers, the "PushBack" can't guarantee the order for re-queued unhandled items, so in new code it just does "normal push" * The new code doesn't do "pause/resume" * The "pause/resume" was designed to handle some handler's failure: eg: document indexer (elasticsearch) is down * If a queue is paused for long time, either the producers blocks or the new items are dropped. * The new code doesn't do such "pause/resume" trick, it's not a common queue's behavior and it doesn't help much. * If there are unhandled items, the "push" function just blocks for a few seconds and then re-queue them and retry. * The new code doesn't do "worker booster" * Gitea's queue's handlers are light functions, the cost is only the go-routine, so it doesn't make sense to "boost" them. * The new code only use "max worker number" to limit the concurrent workers. * The new "Push" never blocks forever * Instead of creating more and more blocking goroutines, return an error is more friendly to the server and to the end user. There are more details in code comments: eg: the "Flush" problem, the strange "code.index" hanging problem, the "immediate" queue problem. Almost ready for review. TODO: * [x] add some necessary comments during review * [x] add some more tests if necessary * [x] update documents and config options * [x] test max worker / active worker * [x] re-run the CI tasks to see whether any test is flaky * [x] improve the `handleOldLengthConfiguration` to provide more friendly messages * [x] fine tune default config values (eg: length?) ## Code coverage: 
		
			
				
	
	
		
			471 lines
		
	
	
		
			13 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			471 lines
		
	
	
		
			13 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2017 The Gitea Authors. All rights reserved.
 | 
						|
// SPDX-License-Identifier: MIT
 | 
						|
 | 
						|
//nolint:forbidigo
 | 
						|
package integration
 | 
						|
 | 
						|
import (
 | 
						|
	"bytes"
 | 
						|
	"context"
 | 
						|
	"fmt"
 | 
						|
	"hash"
 | 
						|
	"hash/fnv"
 | 
						|
	"io"
 | 
						|
	"net/http"
 | 
						|
	"net/http/cookiejar"
 | 
						|
	"net/http/httptest"
 | 
						|
	"net/url"
 | 
						|
	"os"
 | 
						|
	"path/filepath"
 | 
						|
	"strings"
 | 
						|
	"sync/atomic"
 | 
						|
	"testing"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models/auth"
 | 
						|
	"code.gitea.io/gitea/models/unittest"
 | 
						|
	gitea_context "code.gitea.io/gitea/modules/context"
 | 
						|
	"code.gitea.io/gitea/modules/graceful"
 | 
						|
	"code.gitea.io/gitea/modules/json"
 | 
						|
	"code.gitea.io/gitea/modules/log"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	"code.gitea.io/gitea/modules/testlogger"
 | 
						|
	"code.gitea.io/gitea/modules/util"
 | 
						|
	"code.gitea.io/gitea/modules/web"
 | 
						|
	"code.gitea.io/gitea/routers"
 | 
						|
	"code.gitea.io/gitea/tests"
 | 
						|
 | 
						|
	"github.com/PuerkitoBio/goquery"
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
	"github.com/xeipuuv/gojsonschema"
 | 
						|
)
 | 
						|
 | 
						|
var c *web.Route
 | 
						|
 | 
						|
type NilResponseRecorder struct {
 | 
						|
	httptest.ResponseRecorder
 | 
						|
	Length int
 | 
						|
}
 | 
						|
 | 
						|
func (n *NilResponseRecorder) Write(b []byte) (int, error) {
 | 
						|
	n.Length += len(b)
 | 
						|
	return len(b), nil
 | 
						|
}
 | 
						|
 | 
						|
// NewRecorder returns an initialized ResponseRecorder.
 | 
						|
func NewNilResponseRecorder() *NilResponseRecorder {
 | 
						|
	return &NilResponseRecorder{
 | 
						|
		ResponseRecorder: *httptest.NewRecorder(),
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
type NilResponseHashSumRecorder struct {
 | 
						|
	httptest.ResponseRecorder
 | 
						|
	Hash   hash.Hash
 | 
						|
	Length int
 | 
						|
}
 | 
						|
 | 
						|
func (n *NilResponseHashSumRecorder) Write(b []byte) (int, error) {
 | 
						|
	_, _ = n.Hash.Write(b)
 | 
						|
	n.Length += len(b)
 | 
						|
	return len(b), nil
 | 
						|
}
 | 
						|
 | 
						|
// NewRecorder returns an initialized ResponseRecorder.
 | 
						|
func NewNilResponseHashSumRecorder() *NilResponseHashSumRecorder {
 | 
						|
	return &NilResponseHashSumRecorder{
 | 
						|
		Hash:             fnv.New32(),
 | 
						|
		ResponseRecorder: *httptest.NewRecorder(),
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestMain(m *testing.M) {
 | 
						|
	defer log.Close()
 | 
						|
 | 
						|
	managerCtx, cancel := context.WithCancel(context.Background())
 | 
						|
	graceful.InitManager(managerCtx)
 | 
						|
	defer cancel()
 | 
						|
 | 
						|
	tests.InitTest(true)
 | 
						|
	c = routers.NormalRoutes(context.TODO())
 | 
						|
 | 
						|
	// integration test settings...
 | 
						|
	if setting.CfgProvider != nil {
 | 
						|
		testingCfg := setting.CfgProvider.Section("integration-tests")
 | 
						|
		testlogger.SlowTest = testingCfg.Key("SLOW_TEST").MustDuration(testlogger.SlowTest)
 | 
						|
		testlogger.SlowFlush = testingCfg.Key("SLOW_FLUSH").MustDuration(testlogger.SlowFlush)
 | 
						|
	}
 | 
						|
 | 
						|
	if os.Getenv("GITEA_SLOW_TEST_TIME") != "" {
 | 
						|
		duration, err := time.ParseDuration(os.Getenv("GITEA_SLOW_TEST_TIME"))
 | 
						|
		if err == nil {
 | 
						|
			testlogger.SlowTest = duration
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	if os.Getenv("GITEA_SLOW_FLUSH_TIME") != "" {
 | 
						|
		duration, err := time.ParseDuration(os.Getenv("GITEA_SLOW_FLUSH_TIME"))
 | 
						|
		if err == nil {
 | 
						|
			testlogger.SlowFlush = duration
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	os.Unsetenv("GIT_AUTHOR_NAME")
 | 
						|
	os.Unsetenv("GIT_AUTHOR_EMAIL")
 | 
						|
	os.Unsetenv("GIT_AUTHOR_DATE")
 | 
						|
	os.Unsetenv("GIT_COMMITTER_NAME")
 | 
						|
	os.Unsetenv("GIT_COMMITTER_EMAIL")
 | 
						|
	os.Unsetenv("GIT_COMMITTER_DATE")
 | 
						|
 | 
						|
	err := unittest.InitFixtures(
 | 
						|
		unittest.FixturesOptions{
 | 
						|
			Dir: filepath.Join(filepath.Dir(setting.AppPath), "models/fixtures/"),
 | 
						|
		},
 | 
						|
	)
 | 
						|
	if err != nil {
 | 
						|
		fmt.Printf("Error initializing test database: %v\n", err)
 | 
						|
		os.Exit(1)
 | 
						|
	}
 | 
						|
 | 
						|
	// FIXME: the console logger is deleted by mistake, so if there is any `log.Fatal`, developers won't see any error message.
 | 
						|
	// Instead, "No tests were found",  last nonsense log is "According to the configuration, subsequent logs will not be printed to the console"
 | 
						|
	exitCode := m.Run()
 | 
						|
 | 
						|
	testlogger.WriterCloser.Reset()
 | 
						|
 | 
						|
	if err = util.RemoveAll(setting.Indexer.IssuePath); err != nil {
 | 
						|
		fmt.Printf("util.RemoveAll: %v\n", err)
 | 
						|
		os.Exit(1)
 | 
						|
	}
 | 
						|
	if err = util.RemoveAll(setting.Indexer.RepoPath); err != nil {
 | 
						|
		fmt.Printf("Unable to remove repo indexer: %v\n", err)
 | 
						|
		os.Exit(1)
 | 
						|
	}
 | 
						|
 | 
						|
	os.Exit(exitCode)
 | 
						|
}
 | 
						|
 | 
						|
type TestSession struct {
 | 
						|
	jar http.CookieJar
 | 
						|
}
 | 
						|
 | 
						|
func (s *TestSession) GetCookie(name string) *http.Cookie {
 | 
						|
	baseURL, err := url.Parse(setting.AppURL)
 | 
						|
	if err != nil {
 | 
						|
		return nil
 | 
						|
	}
 | 
						|
 | 
						|
	for _, c := range s.jar.Cookies(baseURL) {
 | 
						|
		if c.Name == name {
 | 
						|
			return c
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
func (s *TestSession) MakeRequest(t testing.TB, req *http.Request, expectedStatus int) *httptest.ResponseRecorder {
 | 
						|
	t.Helper()
 | 
						|
	baseURL, err := url.Parse(setting.AppURL)
 | 
						|
	assert.NoError(t, err)
 | 
						|
	for _, c := range s.jar.Cookies(baseURL) {
 | 
						|
		req.AddCookie(c)
 | 
						|
	}
 | 
						|
	resp := MakeRequest(t, req, expectedStatus)
 | 
						|
 | 
						|
	ch := http.Header{}
 | 
						|
	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | 
						|
	cr := http.Request{Header: ch}
 | 
						|
	s.jar.SetCookies(baseURL, cr.Cookies())
 | 
						|
 | 
						|
	return resp
 | 
						|
}
 | 
						|
 | 
						|
func (s *TestSession) MakeRequestNilResponseRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseRecorder {
 | 
						|
	t.Helper()
 | 
						|
	baseURL, err := url.Parse(setting.AppURL)
 | 
						|
	assert.NoError(t, err)
 | 
						|
	for _, c := range s.jar.Cookies(baseURL) {
 | 
						|
		req.AddCookie(c)
 | 
						|
	}
 | 
						|
	resp := MakeRequestNilResponseRecorder(t, req, expectedStatus)
 | 
						|
 | 
						|
	ch := http.Header{}
 | 
						|
	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | 
						|
	cr := http.Request{Header: ch}
 | 
						|
	s.jar.SetCookies(baseURL, cr.Cookies())
 | 
						|
 | 
						|
	return resp
 | 
						|
}
 | 
						|
 | 
						|
func (s *TestSession) MakeRequestNilResponseHashSumRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseHashSumRecorder {
 | 
						|
	t.Helper()
 | 
						|
	baseURL, err := url.Parse(setting.AppURL)
 | 
						|
	assert.NoError(t, err)
 | 
						|
	for _, c := range s.jar.Cookies(baseURL) {
 | 
						|
		req.AddCookie(c)
 | 
						|
	}
 | 
						|
	resp := MakeRequestNilResponseHashSumRecorder(t, req, expectedStatus)
 | 
						|
 | 
						|
	ch := http.Header{}
 | 
						|
	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | 
						|
	cr := http.Request{Header: ch}
 | 
						|
	s.jar.SetCookies(baseURL, cr.Cookies())
 | 
						|
 | 
						|
	return resp
 | 
						|
}
 | 
						|
 | 
						|
const userPassword = "password"
 | 
						|
 | 
						|
func emptyTestSession(t testing.TB) *TestSession {
 | 
						|
	t.Helper()
 | 
						|
	jar, err := cookiejar.New(nil)
 | 
						|
	assert.NoError(t, err)
 | 
						|
 | 
						|
	return &TestSession{jar: jar}
 | 
						|
}
 | 
						|
 | 
						|
func getUserToken(t testing.TB, userName string, scope ...auth.AccessTokenScope) string {
 | 
						|
	return getTokenForLoggedInUser(t, loginUser(t, userName), scope...)
 | 
						|
}
 | 
						|
 | 
						|
func loginUser(t testing.TB, userName string) *TestSession {
 | 
						|
	t.Helper()
 | 
						|
 | 
						|
	return loginUserWithPassword(t, userName, userPassword)
 | 
						|
}
 | 
						|
 | 
						|
func loginUserWithPassword(t testing.TB, userName, password string) *TestSession {
 | 
						|
	t.Helper()
 | 
						|
	req := NewRequest(t, "GET", "/user/login")
 | 
						|
	resp := MakeRequest(t, req, http.StatusOK)
 | 
						|
 | 
						|
	doc := NewHTMLParser(t, resp.Body)
 | 
						|
	req = NewRequestWithValues(t, "POST", "/user/login", map[string]string{
 | 
						|
		"_csrf":     doc.GetCSRF(),
 | 
						|
		"user_name": userName,
 | 
						|
		"password":  password,
 | 
						|
	})
 | 
						|
	resp = MakeRequest(t, req, http.StatusSeeOther)
 | 
						|
 | 
						|
	ch := http.Header{}
 | 
						|
	ch.Add("Cookie", strings.Join(resp.Header()["Set-Cookie"], ";"))
 | 
						|
	cr := http.Request{Header: ch}
 | 
						|
 | 
						|
	session := emptyTestSession(t)
 | 
						|
 | 
						|
	baseURL, err := url.Parse(setting.AppURL)
 | 
						|
	assert.NoError(t, err)
 | 
						|
	session.jar.SetCookies(baseURL, cr.Cookies())
 | 
						|
 | 
						|
	return session
 | 
						|
}
 | 
						|
 | 
						|
// token has to be unique this counter take care of
 | 
						|
var tokenCounter int64
 | 
						|
 | 
						|
// getTokenForLoggedInUser returns a token for a logged in user.
 | 
						|
// The scope is an optional list of snake_case strings like the frontend form fields,
 | 
						|
// but without the "scope_" prefix.
 | 
						|
func getTokenForLoggedInUser(t testing.TB, session *TestSession, scopes ...auth.AccessTokenScope) string {
 | 
						|
	t.Helper()
 | 
						|
	var token string
 | 
						|
	req := NewRequest(t, "GET", "/user/settings/applications")
 | 
						|
	resp := session.MakeRequest(t, req, http.StatusOK)
 | 
						|
	var csrf string
 | 
						|
	for _, cookie := range resp.Result().Cookies() {
 | 
						|
		if cookie.Name != "_csrf" {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		csrf = cookie.Value
 | 
						|
		break
 | 
						|
	}
 | 
						|
	if csrf == "" {
 | 
						|
		doc := NewHTMLParser(t, resp.Body)
 | 
						|
		csrf = doc.GetCSRF()
 | 
						|
	}
 | 
						|
	assert.NotEmpty(t, csrf)
 | 
						|
	urlValues := url.Values{}
 | 
						|
	urlValues.Add("_csrf", csrf)
 | 
						|
	urlValues.Add("name", fmt.Sprintf("api-testing-token-%d", atomic.AddInt64(&tokenCounter, 1)))
 | 
						|
	for _, scope := range scopes {
 | 
						|
		urlValues.Add("scope", string(scope))
 | 
						|
	}
 | 
						|
	req = NewRequestWithURLValues(t, "POST", "/user/settings/applications", urlValues)
 | 
						|
	resp = session.MakeRequest(t, req, http.StatusSeeOther)
 | 
						|
 | 
						|
	// Log the flash values on failure
 | 
						|
	if !assert.Equal(t, resp.Result().Header["Location"], []string{"/user/settings/applications"}) {
 | 
						|
		for _, cookie := range resp.Result().Cookies() {
 | 
						|
			if cookie.Name != gitea_context.CookieNameFlash {
 | 
						|
				continue
 | 
						|
			}
 | 
						|
			flash, _ := url.ParseQuery(cookie.Value)
 | 
						|
			for key, value := range flash {
 | 
						|
				t.Logf("Flash %q: %q", key, value)
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	req = NewRequest(t, "GET", "/user/settings/applications")
 | 
						|
	resp = session.MakeRequest(t, req, http.StatusOK)
 | 
						|
	htmlDoc := NewHTMLParser(t, resp.Body)
 | 
						|
	token = htmlDoc.doc.Find(".ui.info p").Text()
 | 
						|
	assert.NotEmpty(t, token)
 | 
						|
	return token
 | 
						|
}
 | 
						|
 | 
						|
func NewRequest(t testing.TB, method, urlStr string) *http.Request {
 | 
						|
	t.Helper()
 | 
						|
	return NewRequestWithBody(t, method, urlStr, nil)
 | 
						|
}
 | 
						|
 | 
						|
func NewRequestf(t testing.TB, method, urlFormat string, args ...interface{}) *http.Request {
 | 
						|
	t.Helper()
 | 
						|
	return NewRequest(t, method, fmt.Sprintf(urlFormat, args...))
 | 
						|
}
 | 
						|
 | 
						|
func NewRequestWithValues(t testing.TB, method, urlStr string, values map[string]string) *http.Request {
 | 
						|
	t.Helper()
 | 
						|
	urlValues := url.Values{}
 | 
						|
	for key, value := range values {
 | 
						|
		urlValues[key] = []string{value}
 | 
						|
	}
 | 
						|
	return NewRequestWithURLValues(t, method, urlStr, urlValues)
 | 
						|
}
 | 
						|
 | 
						|
func NewRequestWithURLValues(t testing.TB, method, urlStr string, urlValues url.Values) *http.Request {
 | 
						|
	t.Helper()
 | 
						|
	req := NewRequestWithBody(t, method, urlStr, bytes.NewBufferString(urlValues.Encode()))
 | 
						|
	req.Header.Add("Content-Type", "application/x-www-form-urlencoded")
 | 
						|
	return req
 | 
						|
}
 | 
						|
 | 
						|
func NewRequestWithJSON(t testing.TB, method, urlStr string, v interface{}) *http.Request {
 | 
						|
	t.Helper()
 | 
						|
 | 
						|
	jsonBytes, err := json.Marshal(v)
 | 
						|
	assert.NoError(t, err)
 | 
						|
	req := NewRequestWithBody(t, method, urlStr, bytes.NewBuffer(jsonBytes))
 | 
						|
	req.Header.Add("Content-Type", "application/json")
 | 
						|
	return req
 | 
						|
}
 | 
						|
 | 
						|
func NewRequestWithBody(t testing.TB, method, urlStr string, body io.Reader) *http.Request {
 | 
						|
	t.Helper()
 | 
						|
	if !strings.HasPrefix(urlStr, "http") && !strings.HasPrefix(urlStr, "/") {
 | 
						|
		urlStr = "/" + urlStr
 | 
						|
	}
 | 
						|
	request, err := http.NewRequest(method, urlStr, body)
 | 
						|
	assert.NoError(t, err)
 | 
						|
	request.RequestURI = urlStr
 | 
						|
	return request
 | 
						|
}
 | 
						|
 | 
						|
func AddBasicAuthHeader(request *http.Request, username string) *http.Request {
 | 
						|
	request.SetBasicAuth(username, userPassword)
 | 
						|
	return request
 | 
						|
}
 | 
						|
 | 
						|
const NoExpectedStatus = -1
 | 
						|
 | 
						|
func MakeRequest(t testing.TB, req *http.Request, expectedStatus int) *httptest.ResponseRecorder {
 | 
						|
	t.Helper()
 | 
						|
	recorder := httptest.NewRecorder()
 | 
						|
	if req.RemoteAddr == "" {
 | 
						|
		req.RemoteAddr = "test-mock:12345"
 | 
						|
	}
 | 
						|
	c.ServeHTTP(recorder, req)
 | 
						|
	if expectedStatus != NoExpectedStatus {
 | 
						|
		if !assert.EqualValues(t, expectedStatus, recorder.Code, "Request: %s %s", req.Method, req.URL.String()) {
 | 
						|
			logUnexpectedResponse(t, recorder)
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return recorder
 | 
						|
}
 | 
						|
 | 
						|
func MakeRequestNilResponseRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseRecorder {
 | 
						|
	t.Helper()
 | 
						|
	recorder := NewNilResponseRecorder()
 | 
						|
	c.ServeHTTP(recorder, req)
 | 
						|
	if expectedStatus != NoExpectedStatus {
 | 
						|
		if !assert.EqualValues(t, expectedStatus, recorder.Code,
 | 
						|
			"Request: %s %s", req.Method, req.URL.String()) {
 | 
						|
			logUnexpectedResponse(t, &recorder.ResponseRecorder)
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return recorder
 | 
						|
}
 | 
						|
 | 
						|
func MakeRequestNilResponseHashSumRecorder(t testing.TB, req *http.Request, expectedStatus int) *NilResponseHashSumRecorder {
 | 
						|
	t.Helper()
 | 
						|
	recorder := NewNilResponseHashSumRecorder()
 | 
						|
	c.ServeHTTP(recorder, req)
 | 
						|
	if expectedStatus != NoExpectedStatus {
 | 
						|
		if !assert.EqualValues(t, expectedStatus, recorder.Code,
 | 
						|
			"Request: %s %s", req.Method, req.URL.String()) {
 | 
						|
			logUnexpectedResponse(t, &recorder.ResponseRecorder)
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return recorder
 | 
						|
}
 | 
						|
 | 
						|
// logUnexpectedResponse logs the contents of an unexpected response.
 | 
						|
func logUnexpectedResponse(t testing.TB, recorder *httptest.ResponseRecorder) {
 | 
						|
	t.Helper()
 | 
						|
	respBytes := recorder.Body.Bytes()
 | 
						|
	if len(respBytes) == 0 {
 | 
						|
		return
 | 
						|
	} else if len(respBytes) < 500 {
 | 
						|
		// if body is short, just log the whole thing
 | 
						|
		t.Log("Response: ", string(respBytes))
 | 
						|
		return
 | 
						|
	} else {
 | 
						|
		t.Log("Response length: ", len(respBytes))
 | 
						|
	}
 | 
						|
 | 
						|
	// log the "flash" error message, if one exists
 | 
						|
	// we must create a new buffer, so that we don't "use up" resp.Body
 | 
						|
	htmlDoc, err := goquery.NewDocumentFromReader(bytes.NewBuffer(respBytes))
 | 
						|
	if err != nil {
 | 
						|
		return // probably a non-HTML response
 | 
						|
	}
 | 
						|
	errMsg := htmlDoc.Find(".ui.negative.message").Text()
 | 
						|
	if len(errMsg) > 0 {
 | 
						|
		t.Log("A flash error message was found:", errMsg)
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func DecodeJSON(t testing.TB, resp *httptest.ResponseRecorder, v interface{}) {
 | 
						|
	t.Helper()
 | 
						|
 | 
						|
	decoder := json.NewDecoder(resp.Body)
 | 
						|
	assert.NoError(t, decoder.Decode(v))
 | 
						|
}
 | 
						|
 | 
						|
func VerifyJSONSchema(t testing.TB, resp *httptest.ResponseRecorder, schemaFile string) {
 | 
						|
	t.Helper()
 | 
						|
 | 
						|
	schemaFilePath := filepath.Join(filepath.Dir(setting.AppPath), "tests", "integration", "schemas", schemaFile)
 | 
						|
	_, schemaFileErr := os.Stat(schemaFilePath)
 | 
						|
	assert.Nil(t, schemaFileErr)
 | 
						|
 | 
						|
	schema, schemaFileReadErr := os.ReadFile(schemaFilePath)
 | 
						|
	assert.Nil(t, schemaFileReadErr)
 | 
						|
	assert.True(t, len(schema) > 0)
 | 
						|
 | 
						|
	nodeinfoSchema := gojsonschema.NewStringLoader(string(schema))
 | 
						|
	nodeinfoString := gojsonschema.NewStringLoader(resp.Body.String())
 | 
						|
	result, schemaValidationErr := gojsonschema.Validate(nodeinfoSchema, nodeinfoString)
 | 
						|
	assert.Nil(t, schemaValidationErr)
 | 
						|
	assert.Empty(t, result.Errors())
 | 
						|
	assert.True(t, result.Valid())
 | 
						|
}
 | 
						|
 | 
						|
func GetCSRF(t testing.TB, session *TestSession, urlStr string) string {
 | 
						|
	t.Helper()
 | 
						|
	req := NewRequest(t, "GET", urlStr)
 | 
						|
	resp := session.MakeRequest(t, req, http.StatusOK)
 | 
						|
	doc := NewHTMLParser(t, resp.Body)
 | 
						|
	return doc.GetCSRF()
 | 
						|
}
 |