mirror of
https://github.com/go-gitea/gitea
synced 2024-11-19 00:24:31 +00:00
4eb2a29910
The 4 functions are duplicated, especially as interface methods. I think we just need to keep `MustID` the only one and remove other 3. ``` MustID(b []byte) ObjectID MustIDFromString(s string) ObjectID NewID(b []byte) (ObjectID, error) NewIDFromString(s string) (ObjectID, error) ``` Introduced the new interfrace method `ComputeHash` which will replace the interface `HasherInterface`. Now we don't need to keep two interfaces. Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new function will detect the hash length to decide which objectformat of it. If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be right if the commitID is a full one. So the parameter should be always a full commit id. @AdamMajer Please review. |
||
|---|---|---|
| .. | ||
| check_test.go | ||
| check.go | ||
| comment.go | ||
| commit_status.go | ||
| edits.go | ||
| lfs.go | ||
| main_test.go | ||
| merge_merge.go | ||
| merge_prepare.go | ||
| merge_rebase.go | ||
| merge_squash.go | ||
| merge_test.go | ||
| merge.go | ||
| patch_unmerged.go | ||
| patch.go | ||
| pull_test.go | ||
| pull.go | ||
| review.go | ||
| temp_repo.go | ||
| update_rebase.go | ||
| update.go | ||