1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 09:04:26 +00:00
gitea/templates/repo/editor
silverwind 60e4a98ab0
Preserve BOM in web editor (#28935)
The `ToUTF8*` functions were stripping BOM, while BOM is actually valid
in UTF8, so the stripping must be optional depending on use case. This
does:

- Add a options struct to all `ToUTF8*` functions, that by default will
strip BOM to preserve existing behaviour
- Remove `ToUTF8` function, it was dead code
- Rename `ToUTF8WithErr` to `ToUTF8`
- Preserve BOM in Monaco Editor
- Remove a unnecessary newline in the textarea value. Browsers did
ignore it, it seems but it's better not to rely on this behaviour.

Fixes: https://github.com/go-gitea/gitea/issues/28743
Related: https://github.com/go-gitea/gitea/issues/6716 which seems to
have once introduced a mechanism that strips and re-adds the BOM, but
from what I can tell, this mechanism was removed at some point after
that PR.
2024-01-27 18:02:51 +00:00
..
cherry_pick.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
commit_form.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
delete.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
diff_preview.tmpl Fix broken code editor diff preview (#23307) 2023-03-06 09:37:58 +08:00
edit.tmpl Preserve BOM in web editor (#28935) 2024-01-27 18:02:51 +00:00
patch.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00
upload.tmpl Fix more "locale" usages (#27259) 2023-09-25 20:42:40 +08:00