mirror of
https://github.com/go-gitea/gitea
synced 2024-12-28 03:24:26 +00:00
423a0fccb6
* fix: primary email cannot be activated * Primary email should be activated together with user account when 'RegisterEmailConfirm' is enabled. * To fix the existing error state. When 'RegisterEmailConfirm' is enabled, the admin should have permission to modify the activations status of user email. And the user should be allowed to send activation to primary email. * Only judge whether email is primary from email_address table. * Improve logging and refactor isEmailActive Co-authored-by: zeripath <art27@cantab.net>
157 lines
4.1 KiB
Go
157 lines
4.1 KiB
Go
// Copyright 2020 The Gitea Authors.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package admin
|
|
|
|
import (
|
|
"bytes"
|
|
"net/http"
|
|
"net/url"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/base"
|
|
"code.gitea.io/gitea/modules/context"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/util"
|
|
)
|
|
|
|
const (
|
|
tplEmails base.TplName = "admin/emails/list"
|
|
)
|
|
|
|
// Emails show all emails
|
|
func Emails(ctx *context.Context) {
|
|
ctx.Data["Title"] = ctx.Tr("admin.emails")
|
|
ctx.Data["PageIsAdmin"] = true
|
|
ctx.Data["PageIsAdminEmails"] = true
|
|
|
|
opts := &models.SearchEmailOptions{
|
|
ListOptions: models.ListOptions{
|
|
PageSize: setting.UI.Admin.UserPagingNum,
|
|
Page: ctx.QueryInt("page"),
|
|
},
|
|
}
|
|
|
|
if opts.Page <= 1 {
|
|
opts.Page = 1
|
|
}
|
|
|
|
type ActiveEmail struct {
|
|
models.SearchEmailResult
|
|
CanChange bool
|
|
}
|
|
|
|
var (
|
|
baseEmails []*models.SearchEmailResult
|
|
emails []ActiveEmail
|
|
count int64
|
|
err error
|
|
orderBy models.SearchEmailOrderBy
|
|
)
|
|
|
|
ctx.Data["SortType"] = ctx.Query("sort")
|
|
switch ctx.Query("sort") {
|
|
case "email":
|
|
orderBy = models.SearchEmailOrderByEmail
|
|
case "reverseemail":
|
|
orderBy = models.SearchEmailOrderByEmailReverse
|
|
case "username":
|
|
orderBy = models.SearchEmailOrderByName
|
|
case "reverseusername":
|
|
orderBy = models.SearchEmailOrderByNameReverse
|
|
default:
|
|
ctx.Data["SortType"] = "email"
|
|
orderBy = models.SearchEmailOrderByEmail
|
|
}
|
|
|
|
opts.Keyword = ctx.QueryTrim("q")
|
|
opts.SortType = orderBy
|
|
if len(ctx.Query("is_activated")) != 0 {
|
|
opts.IsActivated = util.OptionalBoolOf(ctx.QueryBool("activated"))
|
|
}
|
|
if len(ctx.Query("is_primary")) != 0 {
|
|
opts.IsPrimary = util.OptionalBoolOf(ctx.QueryBool("primary"))
|
|
}
|
|
|
|
if len(opts.Keyword) == 0 || isKeywordValid(opts.Keyword) {
|
|
baseEmails, count, err = models.SearchEmails(opts)
|
|
if err != nil {
|
|
ctx.ServerError("SearchEmails", err)
|
|
return
|
|
}
|
|
emails = make([]ActiveEmail, len(baseEmails))
|
|
for i := range baseEmails {
|
|
emails[i].SearchEmailResult = *baseEmails[i]
|
|
// Don't let the admin deactivate its own primary email address
|
|
// We already know the user is admin
|
|
emails[i].CanChange = ctx.User.ID != emails[i].UID || !emails[i].IsPrimary
|
|
}
|
|
}
|
|
ctx.Data["Keyword"] = opts.Keyword
|
|
ctx.Data["Total"] = count
|
|
ctx.Data["Emails"] = emails
|
|
|
|
pager := context.NewPagination(int(count), opts.PageSize, opts.Page, 5)
|
|
pager.SetDefaultParams(ctx)
|
|
ctx.Data["Page"] = pager
|
|
|
|
ctx.HTML(http.StatusOK, tplEmails)
|
|
}
|
|
|
|
var (
|
|
nullByte = []byte{0x00}
|
|
)
|
|
|
|
func isKeywordValid(keyword string) bool {
|
|
return !bytes.Contains([]byte(keyword), nullByte)
|
|
}
|
|
|
|
// ActivateEmail serves a POST request for activating/deactivating a user's email
|
|
func ActivateEmail(ctx *context.Context) {
|
|
|
|
truefalse := map[string]bool{"1": true, "0": false}
|
|
|
|
uid := ctx.QueryInt64("uid")
|
|
email := ctx.Query("email")
|
|
primary, okp := truefalse[ctx.Query("primary")]
|
|
activate, oka := truefalse[ctx.Query("activate")]
|
|
|
|
if uid == 0 || len(email) == 0 || !okp || !oka {
|
|
ctx.Error(http.StatusBadRequest)
|
|
return
|
|
}
|
|
|
|
log.Info("Changing activation for User ID: %d, email: %s, primary: %v to %v", uid, email, primary, activate)
|
|
|
|
if err := models.ActivateUserEmail(uid, email, activate); err != nil {
|
|
log.Error("ActivateUserEmail(%v,%v,%v): %v", uid, email, activate, err)
|
|
if models.IsErrEmailAlreadyUsed(err) {
|
|
ctx.Flash.Error(ctx.Tr("admin.emails.duplicate_active"))
|
|
} else {
|
|
ctx.Flash.Error(ctx.Tr("admin.emails.not_updated", err))
|
|
}
|
|
} else {
|
|
log.Info("Activation for User ID: %d, email: %s, primary: %v changed to %v", uid, email, primary, activate)
|
|
ctx.Flash.Info(ctx.Tr("admin.emails.updated"))
|
|
}
|
|
|
|
redirect, _ := url.Parse(setting.AppSubURL + "/admin/emails")
|
|
q := url.Values{}
|
|
if val := ctx.QueryTrim("q"); len(val) > 0 {
|
|
q.Set("q", val)
|
|
}
|
|
if val := ctx.QueryTrim("sort"); len(val) > 0 {
|
|
q.Set("sort", val)
|
|
}
|
|
if val := ctx.QueryTrim("is_primary"); len(val) > 0 {
|
|
q.Set("is_primary", val)
|
|
}
|
|
if val := ctx.QueryTrim("is_activated"); len(val) > 0 {
|
|
q.Set("is_activated", val)
|
|
}
|
|
redirect.RawQuery = q.Encode()
|
|
ctx.Redirect(redirect.String())
|
|
}
|