1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 00:54:28 +00:00
gitea/templates
wxiaoguang 59d060622d
Improve RSS (#24335)
Follow  #22719

### Major changes

1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`


Screenshot of changed parts:

<details>


![image](https://user-images.githubusercontent.com/2114189/234315538-66603694-9093-48a8-af33-83575fd7a018.png)


![image](https://user-images.githubusercontent.com/2114189/234315786-f1efa60b-012e-490b-8ce2-d448dc6fe5c9.png)


![image](https://user-images.githubusercontent.com/2114189/234334941-446941bc-1baa-4256-8850-ccc439476cda.png)

</details>


### Other thoughts

Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.

---------

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
2023-04-25 22:53:44 -04:00
..
admin Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
api/packages/pypi Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
base Improve some modal action buttons (#24289) 2023-04-24 07:08:59 -04:00
code Use data-tooltip-content for tippy tooltip (#23649) 2023-03-24 18:35:38 +08:00
custom Add footer extra links template (#9576) 2020-01-03 20:41:56 +02:00
devtest Improve some modal action buttons (#24289) 2023-04-24 07:08:59 -04:00
explore Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
mail Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
org Improve some modal action buttons (#24289) 2023-04-24 07:08:59 -04:00
package Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
projects Improve some modal action buttons (#24289) 2023-04-24 07:08:59 -04:00
repo Improve RSS (#24335) 2023-04-25 22:53:44 -04:00
shared Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
status Fix template function DateTime (#24317) 2023-04-25 15:48:30 -04:00
swagger Fix typo in API route (#24310) 2023-04-24 20:44:27 +02:00
user Automatically select the org when click create repo from org dashboard (#24325) 2023-04-25 22:25:29 -04:00
home.tmpl Improve home page template, fix Sort dropdown menu flash (#23856) 2023-04-01 13:47:54 +08:00
install.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00
post-install.tmpl Remove incorrect HTML self close tag (#23748) 2023-03-27 18:05:51 +02:00