1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 17:14:27 +00:00
gitea/templates/repo/settings/webhook
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
base_list.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
base.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
delete_modal.tmpl Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
dingtalk.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
discord.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
feishu.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
gitea.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
gogs.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
history.tmpl Add user webhooks (#21563) 2023-03-10 08:28:32 -06:00
list.tmpl Merge default and system webhooks under one menu (#14244) 2021-01-15 01:24:03 +02:00
matrix.tmpl Add Webhook authorization header (#20926) 2022-11-03 20:23:20 +02:00
msteams.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
new.tmpl Add main landmark to templates and adjust titles (#22670) 2023-02-01 22:56:10 +00:00
packagist.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
settings.tmpl Refactor hiding-methods, remove jQuery show/hide, remove .hide class, remove inline style=display:none (#22950) 2023-02-19 12:06:14 +08:00
slack.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
telegram.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00
wechatwork.tmpl Refactor i18n to locale (#20153) 2022-06-27 15:58:46 -05:00