mirror of
https://github.com/go-gitea/gitea
synced 2024-11-16 23:24:25 +00:00
81fe5d6185
This improves a lot of accessibility shortcomings. Every possible instance of `<div class="button">` matching the command `ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'` has been converted when possible. divs with the `dropdown` class and their children were omitted as 1. more analysis must be conducted whether the dropdowns still work as intended when they are a `button` instead of a `div`. 2. most dropdowns have `div`s as children. The HTML standard disallows `div`s inside `button`s. 3. When a dropdown child that's part of the displayed text content is converted to a `button`, the dropdown can be focused twice Further changes include that all "gitea-managed" buttons with JS code received an `e.preventDefault()` so that they don't accidentally submit an underlying form, which would execute instead of cancel the action. Lastly, some minor issues were fixed as well during the refactoring. ## Future improvements As mentioned in https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391, `<a>`s without `href` attribute are not focusable. They should later on be converted to `<button>`s. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-authored-by: techknowlogick <techknowlogick@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
64 lines
2.5 KiB
Handlebars
64 lines
2.5 KiB
Handlebars
{{template "base/head" .}}
|
|
<div role="main" aria-label="{{.Title}}" class="page-content repository settings lfs">
|
|
{{template "repo/header" .}}
|
|
{{template "repo/settings/navbar" .}}
|
|
<div class="ui container">
|
|
{{template "base/alert" .}}
|
|
<h4 class="ui top attached header">
|
|
{{.locale.Tr "repo.settings.lfs_filelist"}} ({{.locale.Tr "admin.total" .Total}})
|
|
<div class="ui right">
|
|
<a class="ui tiny show-panel button" href="{{.Link}}/locks">{{.locale.Tr "repo.settings.lfs_locks"}}</a>
|
|
<a class="ui primary tiny show-panel button" href="{{.Link}}/pointers"> {{.locale.Tr "repo.settings.lfs_findpointerfiles"}}</a>
|
|
</div>
|
|
</h4>
|
|
<table id="lfs-files-table" class="ui attached segment single line table">
|
|
<tbody>
|
|
{{range .LFSFiles}}
|
|
<tr>
|
|
<td>
|
|
<span class="text sha label">
|
|
<a href="{{$.Link}}/show/{{.Oid}}" title="{{.Oid}}" class="ui detail icon button brown truncate">
|
|
{{ShortSha .Oid}}
|
|
</a>
|
|
</span>
|
|
</td>
|
|
<td>{{FileSize .Size}}</td>
|
|
<td>{{TimeSince .CreatedUnix.AsTime $.locale}}</td>
|
|
<td class="right aligned">
|
|
<a class="ui primary show-panel button" href="{{$.Link}}/find?oid={{.Oid}}&size={{.Size}}">{{$.locale.Tr "repo.settings.lfs_findcommits"}}</a>
|
|
<button class="ui basic show-modal icon button" data-modal="#delete-{{.Oid}}">
|
|
<span class="btn-octicon btn-octicon-danger tooltip" data-content="{{$.locale.Tr "repo.editor.delete_this_file"}}" data-position="bottom center">{{svg "octicon-trash"}}</span>
|
|
</button>
|
|
</td>
|
|
</tr>
|
|
{{else}}
|
|
<tr>
|
|
<td colspan="4">{{.locale.Tr "repo.settings.lfs_no_lfs_files"}}</td>
|
|
</tr>
|
|
{{end}}
|
|
</tbody>
|
|
</table>
|
|
{{template "base/paginate" .}}
|
|
{{range .LFSFiles}}
|
|
<div class="ui basic modal" id="delete-{{.Oid}}">
|
|
<div class="ui icon header">
|
|
{{$.locale.Tr "repo.settings.lfs_delete" .Oid}}
|
|
</div>
|
|
<div class="content center">
|
|
<p>
|
|
{{$.locale.Tr "repo.settings.lfs_delete_warning"}}
|
|
</p>
|
|
<form class="ui form" action="{{$.Link}}/delete/{{.Oid}}" method="post">
|
|
{{$.CsrfTokenHtml}}
|
|
<div class="center actions">{{/* TODO: Convert to base/delete_modal_actions */}}
|
|
<button class="ui basic cancel inverted button">{{$.locale.Tr "settings.cancel"}}</button>
|
|
<button class="ui basic inverted yellow button">{{$.locale.Tr "modal.yes"}}</button>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
</div>
|
|
{{end}}
|
|
</div>
|
|
</div>
|
|
{{template "base/footer" .}}
|