mirror of
				https://github.com/go-gitea/gitea
				synced 2025-11-04 13:28:25 +00:00 
			
		
		
		
	* Add missing `X-Total-Count` and fix some related bugs
Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions
I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.
Closes #13043
* fmt
* Update routers/api/v1/repo/issue_subscription.go
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
* Use FindAndCount
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
		
	
		
			
				
	
	
		
			86 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			86 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2020 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package code
 | 
						|
 | 
						|
import (
 | 
						|
	"path/filepath"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/models/unittest"
 | 
						|
 | 
						|
	_ "code.gitea.io/gitea/models"
 | 
						|
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
)
 | 
						|
 | 
						|
func TestMain(m *testing.M) {
 | 
						|
	unittest.MainTest(m, filepath.Join("..", "..", ".."))
 | 
						|
}
 | 
						|
 | 
						|
func testIndexer(name string, t *testing.T, indexer Indexer) {
 | 
						|
	t.Run(name, func(t *testing.T) {
 | 
						|
		var repoID int64 = 1
 | 
						|
		err := index(indexer, repoID)
 | 
						|
		assert.NoError(t, err)
 | 
						|
		var (
 | 
						|
			keywords = []struct {
 | 
						|
				RepoIDs []int64
 | 
						|
				Keyword string
 | 
						|
				IDs     []int64
 | 
						|
				Langs   int
 | 
						|
			}{
 | 
						|
				{
 | 
						|
					RepoIDs: nil,
 | 
						|
					Keyword: "Description",
 | 
						|
					IDs:     []int64{repoID},
 | 
						|
					Langs:   1,
 | 
						|
				},
 | 
						|
				{
 | 
						|
					RepoIDs: []int64{2},
 | 
						|
					Keyword: "Description",
 | 
						|
					IDs:     []int64{},
 | 
						|
					Langs:   0,
 | 
						|
				},
 | 
						|
				{
 | 
						|
					RepoIDs: nil,
 | 
						|
					Keyword: "repo1",
 | 
						|
					IDs:     []int64{repoID},
 | 
						|
					Langs:   1,
 | 
						|
				},
 | 
						|
				{
 | 
						|
					RepoIDs: []int64{2},
 | 
						|
					Keyword: "repo1",
 | 
						|
					IDs:     []int64{},
 | 
						|
					Langs:   0,
 | 
						|
				},
 | 
						|
				{
 | 
						|
					RepoIDs: nil,
 | 
						|
					Keyword: "non-exist",
 | 
						|
					IDs:     []int64{},
 | 
						|
					Langs:   0,
 | 
						|
				},
 | 
						|
			}
 | 
						|
		)
 | 
						|
 | 
						|
		for _, kw := range keywords {
 | 
						|
			t.Run(kw.Keyword, func(t *testing.T) {
 | 
						|
				total, res, langs, err := indexer.Search(kw.RepoIDs, "", kw.Keyword, 1, 10, false)
 | 
						|
				assert.NoError(t, err)
 | 
						|
				assert.EqualValues(t, len(kw.IDs), total)
 | 
						|
				assert.Len(t, langs, kw.Langs)
 | 
						|
 | 
						|
				var ids = make([]int64, 0, len(res))
 | 
						|
				for _, hit := range res {
 | 
						|
					ids = append(ids, hit.RepoID)
 | 
						|
					assert.EqualValues(t, "# repo1\n\nDescription for repo1", hit.Content)
 | 
						|
				}
 | 
						|
				assert.EqualValues(t, kw.IDs, ids)
 | 
						|
			})
 | 
						|
		}
 | 
						|
 | 
						|
		assert.NoError(t, indexer.Delete(repoID))
 | 
						|
	})
 | 
						|
}
 |