1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-24 09:34:26 +00:00
gitea/docs/content/doc/usage
zeripath dd12384f22
Fix --port setting (#13288)
* Fix --port setting

Unfortunately there was an error in #13195 which set the --port
option before the settings were read. This PR fixes this by
moving applying this option to after the the settings are read

However, on looking further into this code I believe that the setPort
code was slightly odd.

Firstly, it may make sense to run the install page on a different
temporary port to the full system and this should be possible with
a --install-port option.

Secondy, if the --port option is provided we should apply it to both
otherwise there will be unusual behaviour on graceful restart

Thirdly, the documentation for --port says that the setting is
temporary - it should therefore not save its result to the configuration

(This however, does mean that authorized_keys and internal links may
not be correct. - I think we need to discuss this option further.)

Fix #13277

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Update cmd/web.go

* Apply suggestions from code review

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
2020-10-30 15:26:03 -04:00
..
backup-and-restore.en-us.md Add charset handling to backup/restore doc (#11062) 2020-04-13 23:55:20 -03:00
backup-and-restore.zh-cn.md Add charset handling to backup/restore doc (#11062) 2020-04-13 23:55:20 -03:00
backup-and-restore.zh-tw.md Import docs into main repository (#2874) 2017-11-26 23:44:32 +02:00
command-line.en-us.md Fix --port setting (#13288) 2020-10-30 15:26:03 -04:00
email-setup.en-us.md Add warning to mailer documentation about authentication (#11563) 2020-05-24 23:56:18 +01:00
fail2ban-setup.en-us.md Fix hugo shortcode typo in faq (#12987) 2020-09-30 16:59:30 -04:00
git-lfs-support.md Doc added instructions for Git LFS support (#8391) 2019-10-06 12:38:09 +08:00
https-support.md Clarification on the use of certificate chains (#12986) 2020-09-30 12:16:13 -04:00
issue-pull-request-templates.en-us.md Issue templates directory (#11450) 2020-09-11 10:48:39 -04:00
issue-pull-request-templates.zh-cn.md ZH-CN translation of Usage part (#5086) 2018-10-17 14:19:04 -04:00
linked-references.en-us.md Add spent time to referenced issue in commit message (#12220) 2020-09-04 11:37:37 -04:00
pull-request.en-us.md Copyedit docs (#6275) 2019-03-09 16:15:45 -05:00
pull-request.zh-cn.md ZH-CN translation of Usage part (#5086) 2018-10-17 14:19:04 -04:00
push-options.en-us.md Initial support for push options (#12169) 2020-08-23 17:02:35 +01:00
reverse-proxies.en-us.md Use correct make target for building static assets (#12247) 2020-07-14 15:45:23 -04:00
reverse-proxies.zh-cn.md Fix regression in reverse proxy documentation (#7634) 2019-07-26 18:09:12 -04:00
template-repositories.md More expansions in template repositories (#10021) 2020-01-28 13:57:15 +00:00