1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 00:54:28 +00:00
gitea/models/repo
Jason Song 82728a7cec
Do not overwrite empty DefaultBranch (#22708)
Fix #21994. 
And fix #19470.

While generating new repo from a template, it does something like
"commit to git repo, re-fetch repo model from DB, and update default
branch if it's empty".


19d5b2f922/modules/repository/generate.go (L241-L253)

Unfortunately, when load repo from DB, the default branch will be set to
`setting.Repository.DefaultBranch` if it's empty:


19d5b2f922/models/repo/repo.go (L228-L233)

I believe it's a very old temporary patch but has been kept for many
years, see:
[2d2d85bb](https://github.com/go-gitea/gitea/commit/2d2d85bb#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8)

I know it's a risk to delete it, may lead to potential behavioral
changes, but we cannot keep the outdated `FIXME` forever. On the other
hand, an empty `DefaultBranch` does make sense: an empty repo doesn't
have one conceptually (actually, Gitea will still set it to
`setting.Repository.DefaultBranch` to make it safer).
2023-02-02 14:48:48 -06:00
..
archiver.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
avatar.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
collaboration_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
collaboration.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
fork_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
fork.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
git.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
language_stats.go Round language stats percentage using largest remainder (#22026) 2022-12-08 10:47:47 +08:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
mirror.go Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
pushmirror_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pushmirror.go Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
redirect_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
redirect.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
release.go Use ErrInvalidArgument in packages (#22268) 2022-12-31 12:49:37 +01:00
repo_indexer.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo_list_test.go Add a simple test for external renderer (#20033) 2022-12-12 20:45:21 +08:00
repo_list.go Fix Operator does not exist bug on explore page with ONLY_SHOW_RELEVANT_REPOS (#22454) 2023-01-16 11:25:22 +00:00
repo_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
repo_unit.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
repo.go Do not overwrite empty DefaultBranch (#22708) 2023-02-02 14:48:48 -06:00
star_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
star.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
topic_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
topic.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
update.go Fix error when calculate the repository size (#22392) 2023-01-13 18:54:02 +00:00
upload.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_repo_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
user_repo.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
watch_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
watch.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
wiki.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00