1
1
mirror of https://github.com/go-gitea/gitea synced 2024-11-16 07:04:25 +00:00
gitea/modules
zeripath 86863ae939
Prevent timer leaks in Workerpool and others (#11333) (#11340)
There is a potential memory leak in `Workerpool` due to the intricacies of
`time.Timer` stopping.

Whenever a `time.Timer` is `Stop`ped its channel must be cleared using a
`select` if the result of the `Stop()` is `false`.

Unfortunately in `Workerpool` these were checked the wrong way round.

However, there were a few other places that were not being checked.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2020-05-09 00:18:39 +08:00
..
auth Change admin dashboard to POST (#10465) (#10466) 2020-02-25 17:42:43 -06:00
avatar Improve handling of non-square avatars (#7025) 2019-05-25 14:46:14 +03:00
base Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
cache Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
charset deps: update and fix chardet import (#9351) 2019-12-14 02:15:48 +02:00
context api.Context.NotFound(...) should tolerate nil (#11288) (#11306) 2020-05-05 17:48:24 -05:00
convert Fix bug on branch API (#10767) (#10775) 2020-03-20 23:31:01 +02:00
cron Graceful: Xorm, RepoIndexer, Cron and Others (#9282) 2019-12-15 09:51:28 +00:00
generate Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
git Manage port in submodule refurl (#11305) (#11323) 2020-05-07 10:41:40 -05:00
gitgraph Move git graph from models to modules/graph (#9027) 2019-11-16 08:47:57 +08:00
graceful Prevent double waitgroup decrement (#10170) (#10175) 2020-02-07 17:12:49 +00:00
highlight Add a lot of extension to language mappings for syntax highlights (#7741) 2019-08-05 23:48:31 +08:00
httplib Add golangci (#6418) 2019-06-12 15:41:28 -04:00
indexer Stop hanging issue indexer initialisation from preventing shutdown (#10243) (#10249) 2020-02-12 12:22:10 +02:00
lfs Make repository management section handle lfs locks (#8726) 2019-12-12 21:18:07 +08:00
log Log: Ensure FLAGS=none is -1 (#9287) 2019-12-07 23:36:47 -05:00
markup Fix potential bugs (#10513) (#10518) 2020-02-28 00:12:23 -03:00
metrics Prometheus endpoint (#5256) 2018-11-04 22:20:00 -05:00
migrations Prevent timer leaks in Workerpool and others (#11333) (#11340) 2020-05-09 00:18:39 +08:00
notification Fix webhook bug (#10427) (#10432) 2020-02-24 01:48:30 -03:00
options Mulitple Gitea Doctor improvements (#10943) (#10990) (#10064) (#9095) (#10991) 2020-04-06 16:15:20 -04:00
password Add password requirement info on error (#9074) 2019-11-19 22:44:58 +00:00
pprof Add golangci (#6418) 2019-06-12 15:41:28 -04:00
private Batch hook pre- and post-receive calls (#8602) 2019-12-26 13:29:45 +02:00
process Graceful: Cancel Process on monitor pages & HammerTime (#9213) 2019-11-30 16:40:22 +02:00
public Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
queue Prevent timer leaks in Workerpool and others (#11333) (#11340) 2020-05-09 00:18:39 +08:00
recaptcha fixed reCAPTCHA URL (#9083) 2019-11-22 08:03:45 +00:00
references Change markdown rendering from blackfriday to goldmark (#9533) 2019-12-31 03:53:28 +02:00
repofiles Fix GetContents(): Dont't ignore Executables (#11192) (#11209) 2020-04-25 01:54:38 -03:00
repository Batch hook pre- and post-receive calls (#8602) 2019-12-26 13:29:45 +02:00
secret Integrate OAuth2 Provider (#5378) 2019-03-08 11:42:50 -05:00
session Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
setting Fix SQLite concurrency problems by using BEGIN IMMEDIATE (#10368) (#10493) 2020-02-26 23:30:57 -03:00
ssh Graceful: Xorm, RepoIndexer, Cron and Others (#9282) 2019-12-15 09:51:28 +00:00
structs Fix wrong hint when status checking is running on pull request view (#9886) (#9928) 2020-01-22 08:06:11 +02:00
sync Fix missing unlock in uniquequeue (#9791) 2020-01-16 01:09:31 +01:00
task Graceful Queues: Issue Indexing and Tasks (#9363) 2020-01-07 12:23:09 +01:00
templates Fix repository issues pagination bug when there are more than one label filter (#9512) 2019-12-28 14:43:46 +00:00
test Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
timeutil Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
upload Fix upload file type check (#7890) 2019-08-17 13:10:17 +03:00
user Add golangci (#6418) 2019-06-12 15:41:28 -04:00
util Prevent timer leaks in Workerpool and others (#11333) (#11340) 2020-05-09 00:18:39 +08:00
validation Implement webhook branch filter (#7791) 2019-09-09 08:48:21 +03:00
webhook Fix RocketChat (#9908) (#9921) 2020-01-21 17:24:18 -05:00