1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-22 16:44:26 +00:00
gitea/integrations
mrsdizzie 8d99ee2773
Add Organization Wide Labels (#10814)
* Add organization wide labels

Implement organization wide labels similar to organization wide
webhooks. This lets you create individual labels for organizations that can be used
for all repos under that organization (so being able to reuse the same
label across multiple repos).

This makes it possible for small organizations with many repos to use
labels effectively.

Fixes #7406

* Add migration

* remove comments

* fix tests

* Update options/locale/locale_en-US.ini

Removed unused translation string

* show org labels in issue search label filter

* Use more clear var name

* rename migration after merge from master

* comment typo

* update migration again after rebase with master

* check for orgID <=0 per guillep2k review

* fmt

* Apply suggestions from code review

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* remove unused code

* Make sure RepoID is 0 when searching orgID per code review

* more changes/code review requests

* More descriptive translation var per code review

* func description/delete comment when issue label deleted instead of hiding it

* remove comment

* only use issues in that repo when calculating number of open issues for org label on repo label page

* Add integration test for IssuesSearch API with labels

* remove unused function

* Update models/issue_label.go

Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>

* Use subquery in GetLabelIDsInReposByNames

* Fix tests to use correct orgID

* fix more tests

* IssuesSearch api now uses new BuildLabelNamesIssueIDsCondition. Add a few more tests as well

* update comment for clarity

* Revert previous code change now that we can use the new BuildLabelNamesIssueIDsCondition

* Don't sort repos by date in IssuesSearch API

After much debugging I've found a strange issue where in some cases MySQL will return a different result than other enigines if a query is sorted by a null collumn. For example with our integration test data where we don't set updated_unix in repository fixtures:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 45

Returns different results for MySQL than other engines. However, the similar query:

SELECT `id`, `owner_id`, `owner_name`, `lower_name`, `name`, `description`, `website`, `original_service_type`, `original_url`, `default_branch`, `num_watches`, `num_stars`, `num_forks`, `num_issues`, `num_closed_issues`, `num_pulls`, `num_closed_pulls`, `num_milestones`, `num_closed_milestones`, `is_private`, `is_empty`, `is_archived`, `is_mirror`, `status`, `is_fork`, `fork_id`, `is_template`, `template_id`, `size`, `is_fsck_enabled`, `close_issues_via_commit_in_any_branch`, `topics`, `avatar`, `created_unix`, `updated_unix` FROM `repository` ORDER BY updated_unix DESC LIMIT 15 OFFSET 30

Returns the same results.

This causes integration tests to fail on MySQL in certain cases but would never show up in a real installation. Since this API call always returns issues based on the optionally provided repo_priority_id or the issueID itself, there is no change to results by changing the repo sorting method used to get ids earlier in the function.

* linter is back!

* code review

* remove now unused option

* Fix newline at end of files

* more unused code

* update to master

* check for matching ids before query

* Update models/issue_label.go

Co-Authored-By: 6543 <6543@obermui.de>

* Update models/issue_label.go

* update comments

* Update routers/org/setting.go

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
Co-authored-by: 6543 <6543@obermui.de>
2020-04-01 01:14:46 -03:00
..
gitea-repositories-meta Fix wiki raw view on sub path (#10002) 2020-01-28 09:44:08 +00:00
migration-test Fix SQLite concurrency problems by using BEGIN IMMEDIATE (#10368) 2020-02-27 07:51:37 +08:00
api_admin_org_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_admin_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_branch_test.go Fix branch api canPush and canMerge (#10776) 2020-03-20 23:41:33 -04:00
api_comment_test.go [API] Add "before" query to ListIssueComments and ListRepoIssue… (#9685) 2020-01-13 17:02:24 +01:00
api_fork_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_gpg_keys_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_helper_for_declarative_test.go Sign merges, CRUD, Wiki and Repository initialisation with gpg key (#7631) 2019-10-16 14:42:42 +01:00
api_issue_label_test.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
api_issue_milestone_test.go Fix milestone API state parameter unhandled (#10049) 2020-01-29 08:36:32 +02:00
api_issue_reaction_test.go [API] Fix 9544 | return 200 when reaction already exist (#9550) 2019-12-31 03:21:21 -05:00
api_issue_stopwatch_test.go [API] extend StopWatch (#9196) 2019-12-11 23:23:05 -05:00
api_issue_test.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
api_issue_tracked_time_test.go times Add filters (#9373) 2020-01-08 16:14:00 -05:00
api_keys_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_notification_test.go [API] add endpoint to check notifications [Extend #9488] (#9595) 2020-01-14 16:37:19 +01:00
api_oauth2_apps_test.go adds API endpoints to manage OAuth2 Application (list/create/delete) (#10437) 2020-02-29 03:19:32 -03:00
api_org_test.go [API] add GET /orgs endpoint (#9560) 2020-01-12 23:43:44 +08:00
api_pull_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_releases_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_edit_test.go Api: advanced settings for repository (external wiki, issue tracker etc.) (#7756) 2019-10-02 17:30:41 +08:00
api_repo_file_create_test.go [API] Extend contents with dates (#9464) 2019-12-24 10:33:52 +08:00
api_repo_file_delete_test.go Fixes #7152 - Allow create/update/delete message to be empty, use default message (#7324) 2019-06-29 16:19:24 +01:00
api_repo_file_helpers.go Move sdk structs to modules/structs (#6905) 2019-05-11 18:21:34 +08:00
api_repo_file_update_test.go File Edit: Author/Committer interchanged [BugFix] (#9297) 2019-12-09 21:11:24 +08:00
api_repo_get_contents_list_test.go Move newbranch to standalone package (#9627) 2020-01-14 11:38:04 +08:00
api_repo_get_contents_test.go Move newbranch to standalone package (#9627) 2020-01-14 11:38:04 +08:00
api_repo_git_blobs_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_commits_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_hook_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_ref_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_tags_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_git_trees_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_lfs_locks_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_raw_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_tags_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_repo_test.go Fix "access" fixtures and tests (#10247) 2020-02-15 12:29:06 +08:00
api_repo_topic_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_team_test.go [API] orgEditTeam make Fields optional (#9556) 2020-01-09 13:15:14 +00:00
api_team_user_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_token_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_user_heatmap_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_user_orgs_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
api_user_search_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
attachment_test.go Fix missing defer prepareTestEnv(t)() on some tests (#9906) 2020-01-21 12:40:21 +01:00
auth_ldap_test.go Add restricted user filter to LDAP authentication (#10600) 2020-03-05 08:30:33 +02:00
benchmarks_test.go Missed defer prepareTestEnv (#9285) 2019-12-08 01:14:50 +00:00
branches_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
change_default_branch_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
cmd_keys_test.go In authorized_keys use double-quote for windows compatibility (#10841) 2020-03-27 09:49:39 +02:00
cors_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
create_no_session_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
delete_user_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
download_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
editor_test.go Add golangci (#6418) 2019-06-12 15:41:28 -04:00
empty_repo_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
explore_repos_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
git_helper_for_declarative_test.go Fix the intermittent TestGPGGit failures (#9360) 2019-12-15 16:21:16 +00:00
git_test.go Prevent panic on merge to PR (#10403) 2020-02-21 18:18:13 +00:00
gpg_git_test.go Fix the intermittent TestGPGGit failures (#9360) 2019-12-15 16:21:16 +00:00
html_helper.go integration tests: Use t.Helper() (#7654) 2019-07-29 12:15:18 +08:00
integration_test.go Add support for database schema in PostgreSQL (#8819) 2020-01-20 16:45:14 +01:00
issue_test.go Graceful Queues: Issue Indexing and Tasks (#9363) 2020-01-07 12:23:09 +01:00
lfs_getobject_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
links_test.go [BugFix] use default avatar for ghost user (fix 500 error) (#9536) 2019-12-29 16:24:50 +02:00
mssql.ini.tmpl Sign merges, CRUD, Wiki and Repository initialisation with gpg key (#7631) 2019-10-16 14:42:42 +01:00
mysql8.ini.tmpl Sign merges, CRUD, Wiki and Repository initialisation with gpg key (#7631) 2019-10-16 14:42:42 +01:00
mysql.ini.tmpl Issue search support elasticsearch (#9428) 2020-02-13 14:06:17 +08:00
nonascii_branches_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
oauth_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
org_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
pgsql.ini.tmpl Add support for database schema in PostgreSQL (#8819) 2020-01-20 16:45:14 +01:00
private-testing.key Fix the intermittent TestGPGGit failures (#9360) 2019-12-15 16:21:16 +00:00
pull_compare_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
pull_create_test.go Fix pull view when head repository or head branch missed and close related pull requests when delete head repository or head branch (#9927) 2020-01-25 10:48:22 +08:00
pull_merge_test.go Only check for conflicts/merging if the PR has not been merged in the interim (#10132) 2020-02-10 01:09:31 +02:00
pull_review_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
pull_status_test.go Fix wrong hint when status checking is running on pull request view (#9886) 2020-01-22 11:46:04 +08:00
pull_update_test.go Add "Update Branch" button to Pull Requests (#9784) 2020-01-17 08:03:40 +02:00
README_ZH.md Improve integration tests (#8276) 2019-09-25 14:13:18 +02:00
README.md update integration README (#10400) 2020-02-23 00:45:20 +02:00
release_test.go Change action GETs to POST (#10462) 2020-02-25 14:28:47 -06:00
repo_activity_test.go Fix activity count in TestRepoActivity (#9959) 2020-01-24 13:06:40 +00:00
repo_branch_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_commits_search_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_commits_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_fork_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_generate_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_migrate_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
repo_search_test.go Move code indexer related code to a new package (#9191) 2019-12-08 14:15:35 -05:00
repo_test.go Use local timezone to compare (#10446) 2020-02-25 11:05:00 +08:00
repo_watch_test.go Auto-subscribe user to repository when they commit/tag to it (#7657) 2019-11-10 09:22:19 +00:00
repofiles_delete_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
repofiles_update_test.go Code Refactor of IssueWatch related things (#10401) 2020-02-26 03:32:22 -03:00
setting_test.go Add a /user/login landing page option (#9622) 2020-01-06 17:50:44 +01:00
signin_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
signout_test.go Logout POST action (#10582) 2020-03-02 22:50:31 -06:00
signup_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
sqlite.ini Render READMEs in docs/ .gitea or .github from root (#10361) 2020-02-21 17:04:20 -06:00
ssh_key_test.go Use gitea forked macaron (#7933) 2019-08-23 12:40:29 -04:00
testlogger.go Language statistics bar for repositories (#8037) 2020-02-11 11:34:17 +02:00
timetracking_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
user_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
version_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00
xss_test.go Fix "data race" in testlogger (#9159) 2019-11-26 01:21:37 +02:00

Integrations tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-mysql
make test-pgsql
make test-sqlite

Make sure to perform a clean build before running tests:

make clean build

Run all tests via local drone

drone exec --local --build-event "pull_request"

Run sqlite integrations tests

Start tests

make test-sqlite

Run mysql integrations tests

Setup a mysql database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" -p 3306:3306 --rm --name mysql mysql:latest #(just ctrl-c to stop db and clean the container)
docker run -p 9200:9200 -p 9300:9300 -e "discovery.type=single-node" --rm --name elasticsearch elasticsearch:7.6.0 #(in a secound terminal, just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MYSQL_HOST=localhost:3306 TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integrations tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" -p 5432:5432 --rm --name pgsql postgres:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_PGSQL_HOST=localhost:5432 TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Run mssql integrations tests

Setup a mssql database inside docker

docker run -e "ACCEPT_EULA=Y" -e "MSSQL_PID=Standard" -e "SA_PASSWORD=MwantsaSecurePassword1" -p 1433:1433 --rm --name mssql microsoft/mssql-server-linux:latest #(just ctrl-c to stop db and clean the container)

Start tests based on the database container

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=gitea_test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql

Running individual tests

Example command to run GPG test:

For sqlite:

make test-sqlite#GPG

For other databases(replace MSSQL to MYSQL, MYSQL8, PGSQL):

TEST_MSSQL_HOST=localhost:1433 TEST_MSSQL_DBNAME=test TEST_MSSQL_USERNAME=sa TEST_MSSQL_PASSWORD=MwantsaSecurePassword1 make test-mssql#GPG