1
1
mirror of https://github.com/go-gitea/gitea synced 2024-10-31 23:34:25 +00:00
gitea/models/git
YR Chen 7443a10fc3
Move from max( id ) to max( index ) for latest commit statuses (#30076)
This PR replaces the use of `max( id )`, and instead using ``max(
`index` )`` for determining the latest commit status. Building business
logic over an `auto_increment` primary key like `id` is risky and
there’re already plenty of discussions on the Internet.

There‘s no guarantee for `auto_increment` values to be monotonic,
especially upon failures or with a cluster. In the specific case, we met
the problem of commit statuses being outdated when using TiDB as the
database. As [being
documented](https://docs.pingcap.com/tidb/stable/auto-increment),
`auto_increment` values assigned to an `insert` statement will only be
monotonic on a per server (node) basis.

Closes #30074.
2024-03-28 16:01:15 +08:00
..
branch_list.go Start to migrate from util.OptionalBool to optional.Option[bool] (#29329) 2024-02-23 02:18:33 +00:00
branch_test.go Start to migrate from util.OptionalBool to optional.Option[bool] (#29329) 2024-02-23 02:18:33 +00:00
branch.go Sync branches to DB immediately when handle git hook calling (#29493) 2024-03-06 16:47:52 +08:00
commit_status_test.go Add testing for CalcCommitStatus (#28823) 2024-01-17 13:27:59 +00:00
commit_status.go Move from max( id ) to max( index ) for latest commit statuses (#30076) 2024-03-28 16:01:15 +08:00
lfs_lock.go Introduce path Clean/Join helper functions (#23495) 2023-03-21 16:02:49 -04:00
lfs.go Remove GetByBean method because sometimes it's danger when query condition parameter is zero and also introduce new generic methods (#28220) 2023-12-07 15:27:36 +08:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
protected_banch_list_test.go Fix branch protection priority (#24045) 2023-04-11 13:22:49 -04:00
protected_branch_list.go Start to migrate from util.OptionalBool to optional.Option[bool] (#29329) 2024-02-23 02:18:33 +00:00
protected_branch_test.go Supports wildcard protected branch (#20825) 2023-01-16 16:00:22 +08:00
protected_branch.go Add branch protection setting for ignoring stale approvals (#28498) 2024-01-15 07:20:01 +00:00
protected_tag_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
protected_tag.go Refactor some legacy code and remove unused code (#28622) 2023-12-28 09:38:59 +00:00