1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-23 09:04:26 +00:00
gitea/models/db
Jason Song 1e76a824bc
Refactor and enhance issue indexer to support both searching, filtering and paging (#26012)
Fix #24662.

Replace #24822 and #25708 (although it has been merged)


## Background

In the past, Gitea supported issue searching with a keyword and
conditions in a less efficient way. It worked by searching for issues
with the keyword and obtaining limited IDs (as it is heavy to get all)
on the indexer (bleve/elasticsearch/meilisearch), and then querying with
conditions on the database to find a subset of the found IDs. This is
why the results could be incomplete.

To solve this issue, we need to store all fields that could be used as
conditions in the indexer and support both keyword and additional
conditions when searching with the indexer.

## Major changes

- Redefine `IndexerData` to include all fields that could be used as
filter conditions.
- Refactor `Search(ctx context.Context, kw string, repoIDs []int64,
limit, start int, state string)` to `Search(ctx context.Context, options
*SearchOptions)`, so it supports more conditions now.
- Change the data type stored in `issueIndexerQueue`. Use
`IndexerMetadata` instead of `IndexerData` in case the data has been
updated while it is in the queue. This also reduces the storage size of
the queue.
- Enhance searching with Bleve/Elasticsearch/Meilisearch, make them
fully support `SearchOptions`. Also, update the data versions.
- Keep most logic of database indexer, but remove
`issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is
the entry point to search issues.
- Start a Meilisearch instance to test it in unit tests.
- Add unit tests with almost full coverage to test
Bleve/Elasticsearch/Meilisearch indexer.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-07-31 06:28:53 +00:00
..
install Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
paginator Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
common.go Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 2023-07-31 06:28:53 +00:00
consistency.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
context_committer_test.go Fix halfCommitter and WithTx (#22366) 2023-01-09 12:19:19 -05:00
context_test.go Always reuse transaction (#22362) 2023-01-08 09:34:58 +08:00
context.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
convert.go Support converting varchar to nvarchar for mssql database (#24105) 2023-04-17 21:22:10 +08:00
engine_test.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
engine.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
error.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
index_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
index.go Fix index generation parallelly failure (#25235) 2023-06-15 02:14:43 +02:00
iterate_test.go Allow adding new files to an empty repo (#24164) 2023-04-19 21:40:42 +08:00
iterate.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
list_test.go Use more specific test methods (#24265) 2023-04-22 17:56:27 -04:00
list.go Fix db.Find bug (#23115) 2023-02-24 21:17:09 +08:00
log.go Replace interface{} with any (#25686) 2023-07-04 18:36:08 +00:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
name.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
search.go Split lfs size from repository size (#22900) 2023-06-28 22:41:02 +00:00
sequence.go Refactor setting.Database.UseXXX to methods (#23354) 2023-03-07 18:51:06 +08:00
sql_postgres_with_schema.go Fix .golangci.yml (#22868) 2023-02-11 21:44:53 +00:00