mirror of
https://github.com/go-gitea/gitea
synced 2024-06-02 01:15:48 +00:00
320031fce6
Backport #11843 It's possible to push quite pathological appearing branch names to gitea using git push gitea reasonable-branch:refs/heads/-- at which point large parts of the UI will break. Similarly you can git push origin reasonable-tag:refs/tags/-- which wil return an error. This PR fixes the problems these cause. It also changes the code from creating branches to pushing to ensure that branch restoration has to pass hooks. Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: techknowlogick <techknowlogick@gitea.io>
80 lines
2.1 KiB
Go
80 lines
2.1 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package integrations
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"testing"
|
|
|
|
"github.com/PuerkitoBio/goquery"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/unknwon/i18n"
|
|
)
|
|
|
|
func TestViewBranches(t *testing.T) {
|
|
defer prepareTestEnv(t)()
|
|
|
|
req := NewRequest(t, "GET", "/user2/repo1/branches")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
_, exists := htmlDoc.doc.Find(".delete-branch-button").Attr("data-url")
|
|
assert.False(t, exists, "The template has changed")
|
|
}
|
|
|
|
func TestDeleteBranch(t *testing.T) {
|
|
defer prepareTestEnv(t)()
|
|
|
|
deleteBranch(t)
|
|
}
|
|
|
|
func TestUndoDeleteBranch(t *testing.T) {
|
|
onGiteaRun(t, func(t *testing.T, u *url.URL) {
|
|
deleteBranch(t)
|
|
htmlDoc, name := branchAction(t, ".undo-button")
|
|
assert.Contains(t,
|
|
htmlDoc.doc.Find(".ui.positive.message").Text(),
|
|
i18n.Tr("en", "repo.branch.restore_success", name),
|
|
)
|
|
})
|
|
}
|
|
|
|
func deleteBranch(t *testing.T) {
|
|
htmlDoc, name := branchAction(t, ".delete-branch-button")
|
|
assert.Contains(t,
|
|
htmlDoc.doc.Find(".ui.positive.message").Text(),
|
|
i18n.Tr("en", "repo.branch.deletion_success", name),
|
|
)
|
|
}
|
|
|
|
func branchAction(t *testing.T, button string) (*HTMLDoc, string) {
|
|
session := loginUser(t, "user2")
|
|
req := NewRequest(t, "GET", "/user2/repo1/branches")
|
|
resp := session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
htmlDoc := NewHTMLParser(t, resp.Body)
|
|
link, exists := htmlDoc.doc.Find(button).Attr("data-url")
|
|
assert.True(t, exists, "The template has changed")
|
|
|
|
req = NewRequestWithValues(t, "POST", link, map[string]string{
|
|
"_csrf": getCsrf(t, htmlDoc.doc),
|
|
})
|
|
session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
url, err := url.Parse(link)
|
|
assert.NoError(t, err)
|
|
req = NewRequest(t, "GET", "/user2/repo1/branches")
|
|
resp = session.MakeRequest(t, req, http.StatusOK)
|
|
|
|
return NewHTMLParser(t, resp.Body), url.Query()["name"][0]
|
|
}
|
|
|
|
func getCsrf(t *testing.T, doc *goquery.Document) string {
|
|
csrf, exists := doc.Find("meta[name=\"_csrf\"]").Attr("content")
|
|
assert.True(t, exists)
|
|
return csrf
|
|
}
|