mirror of
https://github.com/go-gitea/gitea
synced 2024-11-01 07:44:25 +00:00
4eb2a29910
The 4 functions are duplicated, especially as interface methods. I think we just need to keep `MustID` the only one and remove other 3. ``` MustID(b []byte) ObjectID MustIDFromString(s string) ObjectID NewID(b []byte) (ObjectID, error) NewIDFromString(s string) (ObjectID, error) ``` Introduced the new interfrace method `ComputeHash` which will replace the interface `HasherInterface`. Now we don't need to keep two interfaces. Reintroduced `git.NewIDFromString` and `git.MustIDFromString`. The new function will detect the hash length to decide which objectformat of it. If it's 40, then it's SHA1. If it's 64, then it's SHA256. This will be right if the commitID is a full one. So the parameter should be always a full commit id. @AdamMajer Please review.
70 lines
1.7 KiB
Go
70 lines
1.7 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package git
|
|
|
|
import (
|
|
"fmt"
|
|
"io"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestRepository_GetBlob_Found(t *testing.T) {
|
|
repoPath := filepath.Join(testReposDir, "repo1_bare")
|
|
r, err := openRepositoryWithDefaultContext(repoPath)
|
|
assert.NoError(t, err)
|
|
defer r.Close()
|
|
|
|
testCases := []struct {
|
|
OID string
|
|
Data []byte
|
|
}{
|
|
{"e2129701f1a4d54dc44f03c93bca0a2aec7c5449", []byte("file1\n")},
|
|
{"6c493ff740f9380390d5c9ddef4af18697ac9375", []byte("file2\n")},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
blob, err := r.GetBlob(testCase.OID)
|
|
assert.NoError(t, err)
|
|
|
|
dataReader, err := blob.DataAsync()
|
|
assert.NoError(t, err)
|
|
|
|
data, err := io.ReadAll(dataReader)
|
|
assert.NoError(t, dataReader.Close())
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, testCase.Data, data)
|
|
}
|
|
}
|
|
|
|
func TestRepository_GetBlob_NotExist(t *testing.T) {
|
|
repoPath := filepath.Join(testReposDir, "repo1_bare")
|
|
r, err := openRepositoryWithDefaultContext(repoPath)
|
|
assert.NoError(t, err)
|
|
defer r.Close()
|
|
|
|
testCase := "0000000000000000000000000000000000000000"
|
|
testError := ErrNotExist{testCase, ""}
|
|
|
|
blob, err := r.GetBlob(testCase)
|
|
assert.Nil(t, blob)
|
|
assert.EqualError(t, err, testError.Error())
|
|
}
|
|
|
|
func TestRepository_GetBlob_NoId(t *testing.T) {
|
|
repoPath := filepath.Join(testReposDir, "repo1_bare")
|
|
r, err := openRepositoryWithDefaultContext(repoPath)
|
|
assert.NoError(t, err)
|
|
defer r.Close()
|
|
|
|
testCase := ""
|
|
testError := fmt.Errorf("length %d has no matched object format: %s", len(testCase), testCase)
|
|
|
|
blob, err := r.GetBlob(testCase)
|
|
assert.Nil(t, blob)
|
|
assert.EqualError(t, err, testError.Error())
|
|
}
|