mirror of
https://github.com/go-gitea/gitea
synced 2024-11-05 09:44:26 +00:00
a96c73f979
Fix regression from https://github.com/go-gitea/gitea/pull/24476 where
the `svg.svg` class misaligns SVG icons across the site and streched
buttons unintentionally in vertical height.
Before (button 30.3px):
<img width="157" alt="Screenshot 2023-05-11 at 22 09 42"
src="https://github.com/go-gitea/gitea/assets/115237/0fd137ab-ab52-4cf8-afca-c45776d526d0">
After (button 30px):
<img width="160" alt="Screenshot 2023-05-11 at 22 09 59"
src="https://github.com/go-gitea/gitea/assets/115237/4b741f4b-0fd2-4fae-9bee-16a7deb098e8">
[vertical-align:
middle](https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align)
is not suitable to align icons to text because
> Aligns the middle of the element with the baseline plus half the
x-height of the parent.
Example of `vertical-align: middle` from MDN:
<img width="232" alt="Screenshot 2023-05-11 at 22 29 28"
src="https://github.com/go-gitea/gitea/assets/115237/179fb756-85a1-4cab-8219-1a4958f333e2">
So I think the
[existing](
|
||
|---|---|---|
| .. | ||
| .eslintrc.yaml | ||
| ActionRunStatus.vue | ||
| ActivityHeatmap.vue | ||
| ContextPopup.vue | ||
| DashboardRepoList.vue | ||
| DiffFileList.vue | ||
| DiffFileTree.vue | ||
| DiffFileTreeItem.vue | ||
| PullRequestMergeForm.vue | ||
| RepoActionView.test.js | ||
| RepoActionView.vue | ||
| RepoActivityTopAuthors.vue | ||
| RepoBranchTagSelector.vue | ||