mirror of
https://github.com/go-gitea/gitea
synced 2024-11-18 16:14:26 +00:00
bb0ff77e46
The recovery, API, Web and package frameworks all create their own HTML Renderers. This increases the memory requirements of Gitea unnecessarily with duplicate templates being kept in memory. Further the reloading framework in dev mode for these involves locking and recompiling all of the templates on each load. This will potentially hide concurrency issues and it is inefficient. This PR stores the templates renderer in the context and stores this context in the NormalRoutes, it then creates a fsnotify.Watcher framework to watch files. The watching framework is then extended to the mailer templates which were previously not being reloaded in dev. Then the locales are simplified to a similar structure. Fix #20210 Fix #20211 Fix #20217 Signed-off-by: Andrew Thornton <art27@cantab.net>
122 lines
3.7 KiB
Go
122 lines
3.7 KiB
Go
// Copyright 2020 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package install
|
|
|
|
import (
|
|
goctx "context"
|
|
"fmt"
|
|
"net/http"
|
|
"path"
|
|
|
|
"code.gitea.io/gitea/modules/httpcache"
|
|
"code.gitea.io/gitea/modules/log"
|
|
"code.gitea.io/gitea/modules/public"
|
|
"code.gitea.io/gitea/modules/setting"
|
|
"code.gitea.io/gitea/modules/templates"
|
|
"code.gitea.io/gitea/modules/web"
|
|
"code.gitea.io/gitea/modules/web/middleware"
|
|
"code.gitea.io/gitea/routers/common"
|
|
"code.gitea.io/gitea/routers/web/healthcheck"
|
|
"code.gitea.io/gitea/services/forms"
|
|
|
|
"gitea.com/go-chi/session"
|
|
)
|
|
|
|
type dataStore map[string]interface{}
|
|
|
|
func (d *dataStore) GetData() map[string]interface{} {
|
|
return *d
|
|
}
|
|
|
|
func installRecovery(ctx goctx.Context) func(next http.Handler) http.Handler {
|
|
_, rnd := templates.HTMLRenderer(ctx)
|
|
return func(next http.Handler) http.Handler {
|
|
return http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) {
|
|
defer func() {
|
|
// Why we need this? The first recover will try to render a beautiful
|
|
// error page for user, but the process can still panic again, then
|
|
// we have to just recover twice and send a simple error page that
|
|
// should not panic any more.
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
combinedErr := fmt.Sprintf("PANIC: %v\n%s", err, log.Stack(2))
|
|
log.Error("%s", combinedErr)
|
|
if setting.IsProd {
|
|
http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusInternalServerError)
|
|
} else {
|
|
http.Error(w, combinedErr, http.StatusInternalServerError)
|
|
}
|
|
}
|
|
}()
|
|
|
|
if err := recover(); err != nil {
|
|
combinedErr := fmt.Sprintf("PANIC: %v\n%s", err, log.Stack(2))
|
|
log.Error("%s", combinedErr)
|
|
|
|
lc := middleware.Locale(w, req)
|
|
store := dataStore{
|
|
"Language": lc.Language(),
|
|
"CurrentURL": setting.AppSubURL + req.URL.RequestURI(),
|
|
"locale": lc,
|
|
"SignedUserID": int64(0),
|
|
"SignedUserName": "",
|
|
}
|
|
|
|
httpcache.AddCacheControlToHeader(w.Header(), 0, "no-transform")
|
|
w.Header().Set(`X-Frame-Options`, setting.CORSConfig.XFrameOptions)
|
|
|
|
if !setting.IsProd {
|
|
store["ErrorMsg"] = combinedErr
|
|
}
|
|
err = rnd.HTML(w, http.StatusInternalServerError, "status/500", templates.BaseVars().Merge(store))
|
|
if err != nil {
|
|
log.Error("%v", err)
|
|
}
|
|
}
|
|
}()
|
|
|
|
next.ServeHTTP(w, req)
|
|
})
|
|
}
|
|
}
|
|
|
|
// Routes registers the install routes
|
|
func Routes(ctx goctx.Context) *web.Route {
|
|
r := web.NewRoute()
|
|
for _, middle := range common.Middlewares() {
|
|
r.Use(middle)
|
|
}
|
|
|
|
r.Use(web.WrapWithPrefix(public.AssetsURLPathPrefix, public.AssetsHandlerFunc(&public.Options{
|
|
Directory: path.Join(setting.StaticRootPath, "public"),
|
|
Prefix: public.AssetsURLPathPrefix,
|
|
}), "InstallAssetsHandler"))
|
|
|
|
r.Use(session.Sessioner(session.Options{
|
|
Provider: setting.SessionConfig.Provider,
|
|
ProviderConfig: setting.SessionConfig.ProviderConfig,
|
|
CookieName: setting.SessionConfig.CookieName,
|
|
CookiePath: setting.SessionConfig.CookiePath,
|
|
Gclifetime: setting.SessionConfig.Gclifetime,
|
|
Maxlifetime: setting.SessionConfig.Maxlifetime,
|
|
Secure: setting.SessionConfig.Secure,
|
|
SameSite: setting.SessionConfig.SameSite,
|
|
Domain: setting.SessionConfig.Domain,
|
|
}))
|
|
|
|
r.Use(installRecovery(ctx))
|
|
r.Use(Init(ctx))
|
|
r.Get("/", Install)
|
|
r.Post("/", web.Bind(forms.InstallForm{}), SubmitInstall)
|
|
r.Get("/api/healthz", healthcheck.Check)
|
|
|
|
r.NotFound(web.Wrap(installNotFound))
|
|
return r
|
|
}
|
|
|
|
func installNotFound(w http.ResponseWriter, req *http.Request) {
|
|
http.Redirect(w, req, setting.AppURL, http.StatusFound)
|
|
}
|