mirror of
https://github.com/go-gitea/gitea
synced 2024-11-05 01:34:25 +00:00
722a7c902d
In investigating #7947 it has become clear that the storage component of go-git repositories needs closing. This PR adds this Close function and adds the Close functions as necessary. In TransferOwnership the ctx.Repo.GitRepo is closed if it is open to help prevent the risk of multiple open files. Fixes #7947
84 lines
2.5 KiB
Go
84 lines
2.5 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package repo
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/test"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestCleanUploadName(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
|
|
var kases = map[string]string{
|
|
".git/refs/master": "",
|
|
"/root/abc": "root/abc",
|
|
"./../../abc": "abc",
|
|
"a/../.git": "",
|
|
"a/../../../abc": "abc",
|
|
"../../../acd": "acd",
|
|
"../../.git/abc": "",
|
|
"..\\..\\.git/abc": "..\\..\\.git/abc",
|
|
"..\\../.git/abc": "",
|
|
"..\\../.git": "",
|
|
"abc/../def": "def",
|
|
".drone.yml": ".drone.yml",
|
|
".abc/def/.drone.yml": ".abc/def/.drone.yml",
|
|
"..drone.yml.": "..drone.yml.",
|
|
"..a.dotty...name...": "..a.dotty...name...",
|
|
"..a.dotty../.folder../.name...": "..a.dotty../.folder../.name...",
|
|
}
|
|
for k, v := range kases {
|
|
assert.EqualValues(t, cleanUploadFileName(k), v)
|
|
}
|
|
}
|
|
|
|
func TestGetUniquePatchBranchName(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
expectedBranchName := "user2-patch-1"
|
|
branchName := GetUniquePatchBranchName(ctx)
|
|
assert.Equal(t, expectedBranchName, branchName)
|
|
}
|
|
|
|
func TestGetClosestParentWithFiles(t *testing.T) {
|
|
models.PrepareTestEnv(t)
|
|
ctx := test.MockContext(t, "user2/repo1")
|
|
ctx.SetParams(":id", "1")
|
|
test.LoadRepo(t, ctx, 1)
|
|
test.LoadRepoCommit(t, ctx)
|
|
test.LoadUser(t, ctx, 2)
|
|
test.LoadGitRepo(t, ctx)
|
|
defer ctx.Repo.GitRepo.Close()
|
|
|
|
repo := ctx.Repo.Repository
|
|
branch := repo.DefaultBranch
|
|
gitRepo, _ := git.OpenRepository(repo.RepoPath())
|
|
defer gitRepo.Close()
|
|
commit, _ := gitRepo.GetBranchCommit(branch)
|
|
expectedTreePath := ""
|
|
|
|
expectedTreePath = "" // Should return the root dir, empty string, since there are no subdirs in this repo
|
|
for _, deletedFile := range []string{
|
|
"dir1/dir2/dir3/file.txt",
|
|
"file.txt",
|
|
} {
|
|
treePath := GetClosestParentWithFiles(deletedFile, commit)
|
|
assert.Equal(t, expectedTreePath, treePath)
|
|
}
|
|
}
|