mirror of
https://github.com/go-gitea/gitea
synced 2024-11-16 07:04:25 +00:00
1751d5fcf2
* Restricted users (#4334): initial implementation
* Add User.IsRestricted & UI to edit it
* Pass user object instead of user id to places where IsRestricted flag matters
* Restricted users: maintain access rows for all referenced repos (incl public)
* Take logged in user & IsRestricted flag into account in org/repo listings, searches and accesses
* Add basic repo access tests for restricted users
Signed-off-by: Manush Dodunekov <manush@stendahls.se>
* Mention restricted users in the faq
Signed-off-by: Manush Dodunekov <manush@stendahls.se>
* Revert unnecessary change `.isUserPartOfOrg` -> `.IsUserPartOfOrg`
Signed-off-by: Manush Dodunekov <manush@stendahls.se>
* Remove unnecessary `org.IsOrganization()` call
Signed-off-by: Manush Dodunekov <manush@stendahls.se>
* Revert to an `int64` keyed `accessMap`
* Add type `userAccess`
* Add convenience func updateUserAccess()
* Turn accessMap into a `map[int64]userAccess`
Signed-off-by: Manush Dodunekov <manush@stendahls.se>
* or even better: `map[int64]*userAccess`
* updateUserAccess(): use tighter syntax as suggested by lafriks
* even tighter
* Avoid extra loop
* Don't disclose limited orgs to unauthenticated users
* Don't assume block only applies to orgs
* Use an array of `VisibleType` for filtering
* fix yet another thinko
* Ok - no need for u
* Revert "Ok - no need for u"
This reverts commit 5c3e886aab
.
Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
Co-authored-by: Lauris BH <lauris@nix.lv>
172 lines
5.1 KiB
Go
172 lines
5.1 KiB
Go
// Copyright 2017 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package models
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAccessLevel(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
user2 := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
|
|
user5 := AssertExistsAndLoadBean(t, &User{ID: 5}).(*User)
|
|
user29 := AssertExistsAndLoadBean(t, &User{ID: 29}).(*User)
|
|
// A public repository owned by User 2
|
|
repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
|
|
assert.False(t, repo1.IsPrivate)
|
|
// A private repository owned by Org 3
|
|
repo3 := AssertExistsAndLoadBean(t, &Repository{ID: 3}).(*Repository)
|
|
assert.True(t, repo3.IsPrivate)
|
|
|
|
// Another public repository
|
|
repo4 := AssertExistsAndLoadBean(t, &Repository{ID: 4}).(*Repository)
|
|
assert.False(t, repo4.IsPrivate)
|
|
// org. owned private repo
|
|
repo24 := AssertExistsAndLoadBean(t, &Repository{ID: 24}).(*Repository)
|
|
|
|
level, err := AccessLevel(user2, repo1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeOwner, level)
|
|
|
|
level, err = AccessLevel(user2, repo3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeOwner, level)
|
|
|
|
level, err = AccessLevel(user5, repo1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeRead, level)
|
|
|
|
level, err = AccessLevel(user5, repo3)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeNone, level)
|
|
|
|
// restricted user has no access to a public repo
|
|
level, err = AccessLevel(user29, repo1)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeNone, level)
|
|
|
|
// ... unless he's a collaborator
|
|
level, err = AccessLevel(user29, repo4)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeWrite, level)
|
|
|
|
// ... or a team member
|
|
level, err = AccessLevel(user29, repo24)
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, AccessModeRead, level)
|
|
}
|
|
|
|
func TestHasAccess(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
user1 := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
|
|
user2 := AssertExistsAndLoadBean(t, &User{ID: 5}).(*User)
|
|
// A public repository owned by User 2
|
|
repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
|
|
assert.False(t, repo1.IsPrivate)
|
|
// A private repository owned by Org 3
|
|
repo2 := AssertExistsAndLoadBean(t, &Repository{ID: 3}).(*Repository)
|
|
assert.True(t, repo2.IsPrivate)
|
|
|
|
has, err := HasAccess(user1.ID, repo1)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
|
|
_, err = HasAccess(user1.ID, repo2)
|
|
assert.NoError(t, err)
|
|
|
|
_, err = HasAccess(user2.ID, repo1)
|
|
assert.NoError(t, err)
|
|
|
|
_, err = HasAccess(user2.ID, repo2)
|
|
assert.NoError(t, err)
|
|
}
|
|
|
|
func TestUser_GetRepositoryAccesses(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
user1 := AssertExistsAndLoadBean(t, &User{ID: 1}).(*User)
|
|
accesses, err := user1.GetRepositoryAccesses()
|
|
assert.NoError(t, err)
|
|
assert.Len(t, accesses, 0)
|
|
|
|
user29 := AssertExistsAndLoadBean(t, &User{ID: 29}).(*User)
|
|
accesses, err = user29.GetRepositoryAccesses()
|
|
assert.NoError(t, err)
|
|
assert.Len(t, accesses, 2)
|
|
}
|
|
|
|
func TestUser_GetAccessibleRepositories(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
user1 := AssertExistsAndLoadBean(t, &User{ID: 1}).(*User)
|
|
repos, err := user1.GetAccessibleRepositories(0)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, repos, 0)
|
|
|
|
user2 := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
|
|
repos, err = user2.GetAccessibleRepositories(0)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, repos, 1)
|
|
|
|
user29 := AssertExistsAndLoadBean(t, &User{ID: 29}).(*User)
|
|
repos, err = user29.GetAccessibleRepositories(0)
|
|
assert.NoError(t, err)
|
|
assert.Len(t, repos, 2)
|
|
}
|
|
|
|
func TestRepository_RecalculateAccesses(t *testing.T) {
|
|
// test with organization repo
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 3}).(*Repository)
|
|
assert.NoError(t, repo1.GetOwner())
|
|
|
|
_, err := x.Delete(&Collaboration{UserID: 2, RepoID: 3})
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, repo1.RecalculateAccesses())
|
|
|
|
access := &Access{UserID: 2, RepoID: 3}
|
|
has, err := x.Get(access)
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
assert.Equal(t, AccessModeOwner, access.Mode)
|
|
}
|
|
|
|
func TestRepository_RecalculateAccesses2(t *testing.T) {
|
|
// test with non-organization repo
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
repo1 := AssertExistsAndLoadBean(t, &Repository{ID: 4}).(*Repository)
|
|
assert.NoError(t, repo1.GetOwner())
|
|
|
|
_, err := x.Delete(&Collaboration{UserID: 4, RepoID: 4})
|
|
assert.NoError(t, err)
|
|
assert.NoError(t, repo1.RecalculateAccesses())
|
|
|
|
has, err := x.Get(&Access{UserID: 4, RepoID: 4})
|
|
assert.NoError(t, err)
|
|
assert.False(t, has)
|
|
}
|
|
|
|
func TestRepository_RecalculateAccesses3(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
team5 := AssertExistsAndLoadBean(t, &Team{ID: 5}).(*Team)
|
|
user29 := AssertExistsAndLoadBean(t, &User{ID: 29}).(*User)
|
|
|
|
has, err := x.Get(&Access{UserID: 29, RepoID: 23})
|
|
assert.NoError(t, err)
|
|
assert.False(t, has)
|
|
|
|
// adding user29 to team5 should add an explicit access row for repo 23
|
|
// even though repo 23 is public
|
|
assert.NoError(t, AddTeamMember(team5, user29.ID))
|
|
|
|
has, err = x.Get(&Access{UserID: 29, RepoID: 23})
|
|
assert.NoError(t, err)
|
|
assert.True(t, has)
|
|
}
|