mirror of
				https://github.com/go-gitea/gitea
				synced 2025-11-04 05:18:25 +00:00 
			
		
		
		
	Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			181 lines
		
	
	
		
			4.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			181 lines
		
	
	
		
			4.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2020 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package misc
 | 
						|
 | 
						|
import (
 | 
						|
	"io/ioutil"
 | 
						|
	"net/http"
 | 
						|
	"net/http/httptest"
 | 
						|
	"net/url"
 | 
						|
	"strings"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/modules/context"
 | 
						|
	"code.gitea.io/gitea/modules/setting"
 | 
						|
	api "code.gitea.io/gitea/modules/structs"
 | 
						|
	"code.gitea.io/gitea/modules/templates"
 | 
						|
	"code.gitea.io/gitea/modules/util"
 | 
						|
	"code.gitea.io/gitea/modules/web"
 | 
						|
 | 
						|
	"github.com/stretchr/testify/assert"
 | 
						|
)
 | 
						|
 | 
						|
const AppURL = "http://localhost:3000/"
 | 
						|
const Repo = "gogits/gogs"
 | 
						|
const AppSubURL = AppURL + Repo + "/"
 | 
						|
 | 
						|
func createContext(req *http.Request) (*context.Context, *httptest.ResponseRecorder) {
 | 
						|
	var rnd = templates.HTMLRenderer()
 | 
						|
	resp := httptest.NewRecorder()
 | 
						|
	c := &context.Context{
 | 
						|
		Req:    req,
 | 
						|
		Resp:   context.NewResponse(resp),
 | 
						|
		Render: rnd,
 | 
						|
		Data:   make(map[string]interface{}),
 | 
						|
	}
 | 
						|
	return c, resp
 | 
						|
}
 | 
						|
 | 
						|
func wrap(ctx *context.Context) *context.APIContext {
 | 
						|
	return &context.APIContext{
 | 
						|
		Context: ctx,
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestAPI_RenderGFM(t *testing.T) {
 | 
						|
	setting.AppURL = AppURL
 | 
						|
 | 
						|
	options := api.MarkdownOption{
 | 
						|
		Mode:    "gfm",
 | 
						|
		Text:    "",
 | 
						|
		Context: Repo,
 | 
						|
		Wiki:    true,
 | 
						|
	}
 | 
						|
	requrl, _ := url.Parse(util.URLJoin(AppURL, "api", "v1", "markdown"))
 | 
						|
	req := &http.Request{
 | 
						|
		Method: "POST",
 | 
						|
		URL:    requrl,
 | 
						|
	}
 | 
						|
	m, resp := createContext(req)
 | 
						|
	ctx := wrap(m)
 | 
						|
 | 
						|
	testCases := []string{
 | 
						|
		// dear imgui wiki markdown extract: special wiki syntax
 | 
						|
		`Wiki! Enjoy :)
 | 
						|
- [[Links, Language bindings, Engine bindings|Links]]
 | 
						|
- [[Tips]]
 | 
						|
- Bezier widget (by @r-lyeh) https://github.com/ocornut/imgui/issues/786`,
 | 
						|
		// rendered
 | 
						|
		`<p>Wiki! Enjoy :)</p>
 | 
						|
<ul>
 | 
						|
<li><a href="` + AppSubURL + `wiki/Links" rel="nofollow">Links, Language bindings, Engine bindings</a></li>
 | 
						|
<li><a href="` + AppSubURL + `wiki/Tips" rel="nofollow">Tips</a></li>
 | 
						|
<li>Bezier widget (by <a href="` + AppURL + `r-lyeh" rel="nofollow">@r-lyeh</a>) <a href="https://github.com/ocornut/imgui/issues/786" rel="nofollow">https://github.com/ocornut/imgui/issues/786</a></li>
 | 
						|
</ul>
 | 
						|
`,
 | 
						|
		// wine-staging wiki home extract: special wiki syntax, images
 | 
						|
		`## What is Wine Staging?
 | 
						|
**Wine Staging** on website [wine-staging.com](http://wine-staging.com).
 | 
						|
 | 
						|
## Quick Links
 | 
						|
Here are some links to the most important topics. You can find the full list of pages at the sidebar.
 | 
						|
 | 
						|
[[Configuration]]
 | 
						|
[[images/icon-bug.png]]
 | 
						|
`,
 | 
						|
		// rendered
 | 
						|
		`<h2 id="user-content-what-is-wine-staging">What is Wine Staging?</h2>
 | 
						|
<p><strong>Wine Staging</strong> on website <a href="http://wine-staging.com" rel="nofollow">wine-staging.com</a>.</p>
 | 
						|
<h2 id="user-content-quick-links">Quick Links</h2>
 | 
						|
<p>Here are some links to the most important topics. You can find the full list of pages at the sidebar.</p>
 | 
						|
<p><a href="` + AppSubURL + `wiki/Configuration" rel="nofollow">Configuration</a>
 | 
						|
<a href="` + AppSubURL + `wiki/raw/images/icon-bug.png" rel="nofollow"><img src="` + AppSubURL + `wiki/raw/images/icon-bug.png" title="icon-bug.png" alt="images/icon-bug.png"/></a></p>
 | 
						|
`,
 | 
						|
		// Guard wiki sidebar: special syntax
 | 
						|
		`[[Guardfile-DSL / Configuring-Guard|Guardfile-DSL---Configuring-Guard]]`,
 | 
						|
		// rendered
 | 
						|
		`<p><a href="` + AppSubURL + `wiki/Guardfile-DSL---Configuring-Guard" rel="nofollow">Guardfile-DSL / Configuring-Guard</a></p>
 | 
						|
`,
 | 
						|
		// special syntax
 | 
						|
		`[[Name|Link]]`,
 | 
						|
		// rendered
 | 
						|
		`<p><a href="` + AppSubURL + `wiki/Link" rel="nofollow">Name</a></p>
 | 
						|
`,
 | 
						|
		// empty
 | 
						|
		``,
 | 
						|
		// rendered
 | 
						|
		``,
 | 
						|
	}
 | 
						|
 | 
						|
	for i := 0; i < len(testCases); i += 2 {
 | 
						|
		options.Text = testCases[i]
 | 
						|
		web.SetForm(ctx, &options)
 | 
						|
		Markdown(ctx)
 | 
						|
		assert.Equal(t, testCases[i+1], resp.Body.String())
 | 
						|
		resp.Body.Reset()
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
var simpleCases = []string{
 | 
						|
	// Guard wiki sidebar: special syntax
 | 
						|
	`[[Guardfile-DSL / Configuring-Guard|Guardfile-DSL---Configuring-Guard]]`,
 | 
						|
	// rendered
 | 
						|
	`<p>[[Guardfile-DSL / Configuring-Guard|Guardfile-DSL---Configuring-Guard]]</p>
 | 
						|
`,
 | 
						|
	// special syntax
 | 
						|
	`[[Name|Link]]`,
 | 
						|
	// rendered
 | 
						|
	`<p>[[Name|Link]]</p>
 | 
						|
`,
 | 
						|
	// empty
 | 
						|
	``,
 | 
						|
	// rendered
 | 
						|
	``,
 | 
						|
}
 | 
						|
 | 
						|
func TestAPI_RenderSimple(t *testing.T) {
 | 
						|
	setting.AppURL = AppURL
 | 
						|
 | 
						|
	options := api.MarkdownOption{
 | 
						|
		Mode:    "markdown",
 | 
						|
		Text:    "",
 | 
						|
		Context: Repo,
 | 
						|
	}
 | 
						|
	requrl, _ := url.Parse(util.URLJoin(AppURL, "api", "v1", "markdown"))
 | 
						|
	req := &http.Request{
 | 
						|
		Method: "POST",
 | 
						|
		URL:    requrl,
 | 
						|
	}
 | 
						|
	m, resp := createContext(req)
 | 
						|
	ctx := wrap(m)
 | 
						|
 | 
						|
	for i := 0; i < len(simpleCases); i += 2 {
 | 
						|
		options.Text = simpleCases[i]
 | 
						|
		web.SetForm(ctx, &options)
 | 
						|
		Markdown(ctx)
 | 
						|
		assert.Equal(t, simpleCases[i+1], resp.Body.String())
 | 
						|
		resp.Body.Reset()
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
func TestAPI_RenderRaw(t *testing.T) {
 | 
						|
	setting.AppURL = AppURL
 | 
						|
 | 
						|
	requrl, _ := url.Parse(util.URLJoin(AppURL, "api", "v1", "markdown"))
 | 
						|
	req := &http.Request{
 | 
						|
		Method: "POST",
 | 
						|
		URL:    requrl,
 | 
						|
	}
 | 
						|
	m, resp := createContext(req)
 | 
						|
	ctx := wrap(m)
 | 
						|
 | 
						|
	for i := 0; i < len(simpleCases); i += 2 {
 | 
						|
		ctx.Req.Body = ioutil.NopCloser(strings.NewReader(simpleCases[i]))
 | 
						|
		MarkdownRaw(ctx)
 | 
						|
		assert.Equal(t, simpleCases[i+1], resp.Body.String())
 | 
						|
		resp.Body.Reset()
 | 
						|
	}
 | 
						|
}
 |