mirror of
https://github.com/go-gitea/gitea
synced 2024-11-16 15:14:24 +00:00
5d2e11eedb
`models` does far too much. In particular it handles all `UserSignin`. It shouldn't be responsible for calling LDAP, SMTP or PAM for signing in. Therefore we should move this code out of `models`. This code has to depend on `models` - therefore it belongs in `services`. There is a package in `services` called `auth` and clearly this functionality belongs in there. Plan: - [x] Change `auth.Auth` to `auth.Method` - as they represent methods of authentication. - [x] Move `models.UserSignIn` into `auth` - [x] Move `models.ExternalUserLogin` - [x] Move most of the `LoginVia*` methods to `auth` or subpackages - [x] Move Resynchronize functionality to `auth` - Involved some restructuring of `models/ssh_key.go` to reduce the size of this massive file and simplify its files. - [x] Move the rest of the LDAP functionality in to the ldap subpackage - [x] Re-factor the login sources to express an interfaces `auth.Source`? - I've done this through some smaller interfaces Authenticator and Synchronizable - which would allow us to extend things in future - [x] Now LDAP is out of models - need to think about modules/auth/ldap and I think all of that functionality might just be moveable - [x] Similarly a lot Oauth2 functionality need not be in models too and should be moved to services/auth/source/oauth2 - [x] modules/auth/oauth2/oauth2.go uses xorm... This is naughty - probably need to move this into models. - [x] models/oauth2.go - mostly should be in modules/auth/oauth2 or services/auth/source/oauth2 - [x] More simplifications of login_source.go may need to be done - Allow wiring in of notify registration - *this can now easily be done - but I think we should do it in another PR* - see #16178 - More refactors...? - OpenID should probably become an auth Method but I think that can be left for another PR - Methods should also probably be cleaned up - again another PR I think. - SSPI still needs more refactors.* Rename auth.Auth auth.Method * Restructure ssh_key.go - move functions from models/user.go that relate to ssh_key to ssh_key - split ssh_key.go to try create clearer function domains for allow for future refactors here. Signed-off-by: Andrew Thornton <art27@cantab.net>
114 lines
2.7 KiB
Go
114 lines
2.7 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package auth
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"code.gitea.io/gitea/models"
|
|
"code.gitea.io/gitea/modules/log"
|
|
|
|
// Register the sources
|
|
_ "code.gitea.io/gitea/services/auth/source/db"
|
|
_ "code.gitea.io/gitea/services/auth/source/ldap"
|
|
_ "code.gitea.io/gitea/services/auth/source/oauth2"
|
|
_ "code.gitea.io/gitea/services/auth/source/pam"
|
|
_ "code.gitea.io/gitea/services/auth/source/smtp"
|
|
_ "code.gitea.io/gitea/services/auth/source/sspi"
|
|
)
|
|
|
|
// UserSignIn validates user name and password.
|
|
func UserSignIn(username, password string) (*models.User, error) {
|
|
var user *models.User
|
|
if strings.Contains(username, "@") {
|
|
user = &models.User{Email: strings.ToLower(strings.TrimSpace(username))}
|
|
// check same email
|
|
cnt, err := models.Count(user)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if cnt > 1 {
|
|
return nil, models.ErrEmailAlreadyUsed{
|
|
Email: user.Email,
|
|
}
|
|
}
|
|
} else {
|
|
trimmedUsername := strings.TrimSpace(username)
|
|
if len(trimmedUsername) == 0 {
|
|
return nil, models.ErrUserNotExist{Name: username}
|
|
}
|
|
|
|
user = &models.User{LowerName: strings.ToLower(trimmedUsername)}
|
|
}
|
|
|
|
hasUser, err := models.GetUser(user)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if hasUser {
|
|
source, err := models.GetLoginSourceByID(user.LoginSource)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if !source.IsActive {
|
|
return nil, models.ErrLoginSourceNotActived
|
|
}
|
|
|
|
authenticator, ok := source.Cfg.(PasswordAuthenticator)
|
|
if !ok {
|
|
return nil, models.ErrUnsupportedLoginType
|
|
}
|
|
|
|
user, err := authenticator.Authenticate(user, username, password)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// WARN: DON'T check user.IsActive, that will be checked on reqSign so that
|
|
// user could be hint to resend confirm email.
|
|
if user.ProhibitLogin {
|
|
return nil, models.ErrUserProhibitLogin{UID: user.ID, Name: user.Name}
|
|
}
|
|
|
|
return user, nil
|
|
}
|
|
|
|
sources, err := models.AllActiveLoginSources()
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, source := range sources {
|
|
if !source.IsActive {
|
|
// don't try to authenticate non-active sources
|
|
continue
|
|
}
|
|
|
|
authenticator, ok := source.Cfg.(PasswordAuthenticator)
|
|
if !ok {
|
|
continue
|
|
}
|
|
|
|
authUser, err := authenticator.Authenticate(nil, username, password)
|
|
|
|
if err == nil {
|
|
if !authUser.ProhibitLogin {
|
|
return authUser, nil
|
|
}
|
|
err = models.ErrUserProhibitLogin{UID: authUser.ID, Name: authUser.Name}
|
|
}
|
|
|
|
if models.IsErrUserNotExist(err) {
|
|
log.Debug("Failed to login '%s' via '%s': %v", username, source.Name, err)
|
|
} else {
|
|
log.Warn("Failed to login '%s' via '%s': %v", username, source.Name, err)
|
|
}
|
|
}
|
|
|
|
return nil, models.ErrUserNotExist{Name: username}
|
|
}
|