1
1
mirror of https://github.com/go-gitea/gitea synced 2024-12-26 02:24:27 +00:00
gitea/modules/markup/markdown
mrsdizzie 4529a262c0
Don't manually replace whitespace during render (#10291) (#10315)
* Don't manually replace whitespace during render

For historical reasons Gitea manually alters the urlPrefix and replaces
a whitespace with a +. This Works for URLs, but we're also passing
urlPrefix to git calls and adding the + is breaking the tree path.

Goldmark will automatically convert a white space to the proper %20, so
we should leave the string as is which lets us pass it to git unmodified
and then let Goldmark fix it.

Also fixed separate bug in URLJoin I noticed while testing where it will
silently discard sections of a path that have # in them (possibly
others). We should just escape it first.

Fixes 10156

* Escape elems as well

* Revert "Escape elems as well"

This reverts commit 8bf49596fe.

* restart ci

* remove changes to URLJoin

* restart ci

Co-authored-by: techknowlogick <matti@mdranta.net>

Co-authored-by: techknowlogick <matti@mdranta.net>
2020-02-17 19:46:28 +02:00
..
goldmark.go Don't manually replace whitespace during render (#10291) (#10315) 2020-02-17 19:46:28 +02:00
markdown_test.go Change markdown rendering from blackfriday to goldmark (#9533) 2019-12-31 03:53:28 +02:00
markdown.go Don't convert ellipsis in markdown (#9905) (#9937) 2020-01-22 16:24:04 +00:00